From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: agross@kernel.org, lee.jones@linaro.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com,
b.zolnierkie@samsung.com, kgunda@codeaurora.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] backlight: qcom-wled: fix unsigned comparison to zero
Date: Tue, 21 Jan 2020 16:39:32 -0800 [thread overview]
Message-ID: <20200122003932.GA3948@builder> (raw)
In-Reply-To: <20200120130143.35363-1-chenzhou10@huawei.com>
On Mon 20 Jan 05:01 PST 2020, Chen Zhou wrote:
> Fixes coccicheck warning:
> ./drivers/video/backlight/qcom-wled.c:1104:5-15:
> WARNING: Unsigned expression compared with zero: string_len > 0
>
> The unsigned variable string_len is assigned a return value from the call
> to wled_configure, which may return negative error code.
>
Afaict string_len is the return value of
of_property_count_elems_of_size(), rather than wled_configure(). (And
please append () to function names to make it even more obvious)
Except for that your patch looks good, so please update the commit
message and add my Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/video/backlight/qcom-wled.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> index d46052d..3d276b3 100644
> --- a/drivers/video/backlight/qcom-wled.c
> +++ b/drivers/video/backlight/qcom-wled.c
> @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version)
> struct wled_config *cfg = &wled->cfg;
> struct device *dev = wled->dev;
> const __be32 *prop_addr;
> - u32 size, val, c, string_len;
> - int rc, i, j;
> + u32 size, val, c;
> + int rc, i, j, string_len;
>
> const struct wled_u32_opts *u32_opts = NULL;
> const struct wled_u32_opts wled3_opts[] = {
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: daniel.thompson@linaro.org, kgunda@codeaurora.org,
b.zolnierkie@samsung.com, jingoohan1@gmail.com,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, lee.jones@linaro.org
Subject: Re: [PATCH -next] backlight: qcom-wled: fix unsigned comparison to zero
Date: Wed, 22 Jan 2020 00:39:32 +0000 [thread overview]
Message-ID: <20200122003932.GA3948@builder> (raw)
In-Reply-To: <20200120130143.35363-1-chenzhou10@huawei.com>
On Mon 20 Jan 05:01 PST 2020, Chen Zhou wrote:
> Fixes coccicheck warning:
> ./drivers/video/backlight/qcom-wled.c:1104:5-15:
> WARNING: Unsigned expression compared with zero: string_len > 0
>
> The unsigned variable string_len is assigned a return value from the call
> to wled_configure, which may return negative error code.
>
Afaict string_len is the return value of
of_property_count_elems_of_size(), rather than wled_configure(). (And
please append () to function names to make it even more obvious)
Except for that your patch looks good, so please update the commit
message and add my Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/video/backlight/qcom-wled.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> index d46052d..3d276b3 100644
> --- a/drivers/video/backlight/qcom-wled.c
> +++ b/drivers/video/backlight/qcom-wled.c
> @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version)
> struct wled_config *cfg = &wled->cfg;
> struct device *dev = wled->dev;
> const __be32 *prop_addr;
> - u32 size, val, c, string_len;
> - int rc, i, j;
> + u32 size, val, c;
> + int rc, i, j, string_len;
>
> const struct wled_u32_opts *u32_opts = NULL;
> const struct wled_u32_opts wled3_opts[] = {
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: daniel.thompson@linaro.org, kgunda@codeaurora.org,
b.zolnierkie@samsung.com, jingoohan1@gmail.com,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, lee.jones@linaro.org
Subject: Re: [PATCH -next] backlight: qcom-wled: fix unsigned comparison to zero
Date: Tue, 21 Jan 2020 16:39:32 -0800 [thread overview]
Message-ID: <20200122003932.GA3948@builder> (raw)
In-Reply-To: <20200120130143.35363-1-chenzhou10@huawei.com>
On Mon 20 Jan 05:01 PST 2020, Chen Zhou wrote:
> Fixes coccicheck warning:
> ./drivers/video/backlight/qcom-wled.c:1104:5-15:
> WARNING: Unsigned expression compared with zero: string_len > 0
>
> The unsigned variable string_len is assigned a return value from the call
> to wled_configure, which may return negative error code.
>
Afaict string_len is the return value of
of_property_count_elems_of_size(), rather than wled_configure(). (And
please append () to function names to make it even more obvious)
Except for that your patch looks good, so please update the commit
message and add my Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/video/backlight/qcom-wled.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> index d46052d..3d276b3 100644
> --- a/drivers/video/backlight/qcom-wled.c
> +++ b/drivers/video/backlight/qcom-wled.c
> @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version)
> struct wled_config *cfg = &wled->cfg;
> struct device *dev = wled->dev;
> const __be32 *prop_addr;
> - u32 size, val, c, string_len;
> - int rc, i, j;
> + u32 size, val, c;
> + int rc, i, j, string_len;
>
> const struct wled_u32_opts *u32_opts = NULL;
> const struct wled_u32_opts wled3_opts[] = {
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-22 0:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 13:01 [PATCH -next] backlight: qcom-wled: fix unsigned comparison to zero Chen Zhou
2020-01-20 13:01 ` Chen Zhou
2020-01-20 13:01 ` Chen Zhou
2020-01-22 0:39 ` Bjorn Andersson [this message]
2020-01-22 0:39 ` Bjorn Andersson
2020-01-22 0:39 ` Bjorn Andersson
2020-01-22 1:21 ` Chen Zhou
2020-01-22 1:21 ` Chen Zhou
2020-01-22 1:21 ` Chen Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122003932.GA3948@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=chenzhou10@huawei.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.