All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "T.Kohada" <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
Cc: Mori.Takahiro@ab.mitsubishielectric.co.jp,
	motai.hirotaka@aj.mitsubishielectric.co.jp,
	Valdis Kletnieks <valdis.kletnieks@vt.edu>,
	linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: remove fs_func struct.
Date: Wed, 22 Jan 2020 09:57:37 +0100	[thread overview]
Message-ID: <20200122085737.GA2511011@kroah.com> (raw)
In-Reply-To: <20200117062046.20491-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>

On Fri, Jan 17, 2020 at 03:20:46PM +0900, T.Kohada wrote:
> Remove 'fs_func struct' and change indirect calls to direct calls.
> 
> The following issues are described in exfat's TODO.
> > Create helper function for exfat_set_entry_time () and
> > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through  the fs_func struc ponters ...
> 
> The fs_func struct was used for switching the helper functions of fat16/fat32/exfat.
> Now, it has lost the role of switching, just making the code less readable.
> 
> Signed-off-by: T.Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>

We need a "full" name here, not just an abbreviation, use what you would
for a document.

Also the patch does not apply to the linux-next tree at all, so I can't
take it.  Please rebase and resend.

thanks,

greg k-h

  reply	other threads:[~2020-01-22  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17  6:20 [PATCH] staging: exfat: remove fs_func struct T.Kohada
2020-01-22  8:57 ` Greg Kroah-Hartman [this message]
2020-01-23  6:38   ` Kohada.Tetsuhiro
2020-01-23  6:52     ` Dan Carpenter
2020-01-23  7:04     ` me
2020-01-23  7:25       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200122085737.GA2511011@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp \
    --cc=Mori.Takahiro@ab.mitsubishielectric.co.jp \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.