From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] vhost: coding style fix
Date: Wed, 22 Jan 2020 09:45:17 +0000 [thread overview]
Message-ID: <20200122094517.GB3263@work-vm> (raw)
In-Reply-To: <20200122080840.592054-1-mst@redhat.com>
* Michael S. Tsirkin (mst@redhat.com) wrote:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Oops apologies for that.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> mrs_host);
>
> - if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> /* Round the section to it's page size */
> /* First align the start down to a page boundary */
> size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> if (alignage) {
> mrs_size += mrs_page - alignage;
> }
> - trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> - mrs_host);
> + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> + mrs_size, mrs_host);
> }
>
> if (dev->n_tmp_sections) {
> --
> MST
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-01-22 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 8:08 [PATCH] vhost: coding style fix Michael S. Tsirkin
2020-01-22 9:45 ` Dr. David Alan Gilbert [this message]
2020-01-22 10:25 ` Alex Bennée
2020-01-22 11:33 ` Stefan Hajnoczi
2020-01-22 13:06 ` Wainer dos Santos Moschetta
2020-01-22 13:47 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122094517.GB3263@work-vm \
--to=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.