All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [PATCH] vhost: coding style fix
Date: Wed, 22 Jan 2020 08:47:07 -0500	[thread overview]
Message-ID: <20200122084644-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <2b0670f2-f14e-b4f6-ad01-d1b2b28bdf06@redhat.com>

On Wed, Jan 22, 2020 at 11:06:53AM -0200, Wainer dos Santos Moschetta wrote:
> 
> On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
> > Drop a trailing whitespace. Make line shorter.
> 
> 
> hmmm... wondering why Patchew didn't catch that. Any idea?
> 
> - Wainer

It did.

> > 
> > Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   hw/virtio/vhost.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> > index 25fd469179..9edfadc81d 100644
> > --- a/hw/virtio/vhost.c
> > +++ b/hw/virtio/vhost.c
> > @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> >       trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> >                                      mrs_host);
> > -    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> > +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> >           /* Round the section to it's page size */
> >           /* First align the start down to a page boundary */
> >           size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> > @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> >           if (alignage) {
> >               mrs_size += mrs_page - alignage;
> >           }
> > -        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> > -                                               mrs_host);
> > +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> > +                                               mrs_size, mrs_host);
> >       }
> >       if (dev->n_tmp_sections) {



      reply	other threads:[~2020-01-22 13:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22  8:08 [PATCH] vhost: coding style fix Michael S. Tsirkin
2020-01-22  9:45 ` Dr. David Alan Gilbert
2020-01-22 10:25 ` Alex Bennée
2020-01-22 11:33 ` Stefan Hajnoczi
2020-01-22 13:06 ` Wainer dos Santos Moschetta
2020-01-22 13:47   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200122084644-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.