* Re: [PATCH] vhost: coding style fix
2020-01-22 8:08 [PATCH] vhost: coding style fix Michael S. Tsirkin
@ 2020-01-22 9:45 ` Dr. David Alan Gilbert
2020-01-22 10:25 ` Alex Bennée
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2020-01-22 9:45 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
* Michael S. Tsirkin (mst@redhat.com) wrote:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Oops apologies for that.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> mrs_host);
>
> - if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> /* Round the section to it's page size */
> /* First align the start down to a page boundary */
> size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> if (alignage) {
> mrs_size += mrs_page - alignage;
> }
> - trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> - mrs_host);
> + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> + mrs_size, mrs_host);
> }
>
> if (dev->n_tmp_sections) {
> --
> MST
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vhost: coding style fix
2020-01-22 8:08 [PATCH] vhost: coding style fix Michael S. Tsirkin
2020-01-22 9:45 ` Dr. David Alan Gilbert
@ 2020-01-22 10:25 ` Alex Bennée
2020-01-22 11:33 ` Stefan Hajnoczi
2020-01-22 13:06 ` Wainer dos Santos Moschetta
3 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2020-01-22 10:25 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: dgilbert, qemu-devel
Michael S. Tsirkin <mst@redhat.com> writes:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> mrs_host);
>
> - if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> /* Round the section to it's page size */
> /* First align the start down to a page boundary */
> size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> if (alignage) {
> mrs_size += mrs_page - alignage;
> }
> - trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> - mrs_host);
> + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> + mrs_size, mrs_host);
> }
>
> if (dev->n_tmp_sections) {
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vhost: coding style fix
2020-01-22 8:08 [PATCH] vhost: coding style fix Michael S. Tsirkin
2020-01-22 9:45 ` Dr. David Alan Gilbert
2020-01-22 10:25 ` Alex Bennée
@ 2020-01-22 11:33 ` Stefan Hajnoczi
2020-01-22 13:06 ` Wainer dos Santos Moschetta
3 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2020-01-22 11:33 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, dgilbert
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
On Wed, Jan 22, 2020 at 03:08:49AM -0500, Michael S. Tsirkin wrote:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vhost: coding style fix
2020-01-22 8:08 [PATCH] vhost: coding style fix Michael S. Tsirkin
` (2 preceding siblings ...)
2020-01-22 11:33 ` Stefan Hajnoczi
@ 2020-01-22 13:06 ` Wainer dos Santos Moschetta
2020-01-22 13:47 ` Michael S. Tsirkin
3 siblings, 1 reply; 6+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-01-22 13:06 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: dgilbert
On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
> Drop a trailing whitespace. Make line shorter.
hmmm... wondering why Patchew didn't catch that. Any idea?
- Wainer
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> mrs_host);
>
> - if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> /* Round the section to it's page size */
> /* First align the start down to a page boundary */
> size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> if (alignage) {
> mrs_size += mrs_page - alignage;
> }
> - trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> - mrs_host);
> + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> + mrs_size, mrs_host);
> }
>
> if (dev->n_tmp_sections) {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vhost: coding style fix
2020-01-22 13:06 ` Wainer dos Santos Moschetta
@ 2020-01-22 13:47 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2020-01-22 13:47 UTC (permalink / raw)
To: Wainer dos Santos Moschetta; +Cc: qemu-devel, dgilbert
On Wed, Jan 22, 2020 at 11:06:53AM -0200, Wainer dos Santos Moschetta wrote:
>
> On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
> > Drop a trailing whitespace. Make line shorter.
>
>
> hmmm... wondering why Patchew didn't catch that. Any idea?
>
> - Wainer
It did.
> >
> > Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/virtio/vhost.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> > index 25fd469179..9edfadc81d 100644
> > --- a/hw/virtio/vhost.c
> > +++ b/hw/virtio/vhost.c
> > @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> > trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> > mrs_host);
> > - if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> > + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> > /* Round the section to it's page size */
> > /* First align the start down to a page boundary */
> > size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> > @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> > if (alignage) {
> > mrs_size += mrs_page - alignage;
> > }
> > - trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> > - mrs_host);
> > + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> > + mrs_size, mrs_host);
> > }
> > if (dev->n_tmp_sections) {
^ permalink raw reply [flat|nested] 6+ messages in thread