From: Rob Herring <robh@kernel.org>
To: Charles-Antoine Couret <charles-antoine.couret@essensium.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: tas5756m: Add DT binding document
Date: Wed, 22 Jan 2020 10:15:56 -0600 [thread overview]
Message-ID: <20200122161556.GA23997@bogus> (raw)
In-Reply-To: <20200118092315.10384-2-charles-antoine.couret@essensium.com>
On Sat, Jan 18, 2020 at 10:23:15AM +0100, Charles-Antoine Couret wrote:
> Document the bindings for the tas5756m driver.
> ---
> .../devicetree/bindings/sound/tas5756m.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.txt
Can you make this a DT schema.
>
> diff --git a/Documentation/devicetree/bindings/sound/tas5756m.txt b/Documentation/devicetree/bindings/sound/tas5756m.txt
> new file mode 100644
> index 000000000000..293eaf20d008
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tas5756m.txt
> @@ -0,0 +1,25 @@
> +TAS5756M audio CODEC
> +
> +Required properties:
> +
> + - compatible: should be one of the following:
> + - "ti,tas5756m"
> + - "ti,tas5754m"
> + - reg: the I2C address of the device for I2C.
> +
> +Optional properties:
> +
> + - mute-gpio : GPIO wired to the mute pin.
mute-gpios is the preferred form.
> + - hybridflow : an integer between 1 and 9 to select the HybridFlow program.
> + if not supplied default DSP program is used.
Needs a vendor prefix.
Is this something fixed for the life of a board or something users would
want to change at runtime?
> +
> +Example:
> +
> + tas5756m: tas5756m@4c {
> + compatible = "ti,tas5756m";
> + reg = <0x4c>;
> + #sound-dai-cells = <0>;
Not documented.
> +
> + hybridflow = <6>;
> + mute-gpio = <&gpio1 11 GPIO_ACTIVE_LOW>;
> + };
> --
> 2.24.1
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Charles-Antoine Couret <charles-antoine.couret@essensium.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: tas5756m: Add DT binding document
Date: Wed, 22 Jan 2020 10:15:56 -0600 [thread overview]
Message-ID: <20200122161556.GA23997@bogus> (raw)
In-Reply-To: <20200118092315.10384-2-charles-antoine.couret@essensium.com>
On Sat, Jan 18, 2020 at 10:23:15AM +0100, Charles-Antoine Couret wrote:
> Document the bindings for the tas5756m driver.
> ---
> .../devicetree/bindings/sound/tas5756m.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.txt
Can you make this a DT schema.
>
> diff --git a/Documentation/devicetree/bindings/sound/tas5756m.txt b/Documentation/devicetree/bindings/sound/tas5756m.txt
> new file mode 100644
> index 000000000000..293eaf20d008
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tas5756m.txt
> @@ -0,0 +1,25 @@
> +TAS5756M audio CODEC
> +
> +Required properties:
> +
> + - compatible: should be one of the following:
> + - "ti,tas5756m"
> + - "ti,tas5754m"
> + - reg: the I2C address of the device for I2C.
> +
> +Optional properties:
> +
> + - mute-gpio : GPIO wired to the mute pin.
mute-gpios is the preferred form.
> + - hybridflow : an integer between 1 and 9 to select the HybridFlow program.
> + if not supplied default DSP program is used.
Needs a vendor prefix.
Is this something fixed for the life of a board or something users would
want to change at runtime?
> +
> +Example:
> +
> + tas5756m: tas5756m@4c {
> + compatible = "ti,tas5756m";
> + reg = <0x4c>;
> + #sound-dai-cells = <0>;
Not documented.
> +
> + hybridflow = <6>;
> + mute-gpio = <&gpio1 11 GPIO_ACTIVE_LOW>;
> + };
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-01-22 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 9:23 [alsa-devel] [PATCH 1/2] ASoC: add TAS5756m driver Charles-Antoine Couret
2020-01-18 9:23 ` [alsa-devel] [PATCH 2/2] ASoC: tas5756m: Add DT binding document Charles-Antoine Couret
2020-01-18 9:23 ` Charles-Antoine Couret
2020-01-22 16:15 ` Rob Herring [this message]
2020-01-22 16:15 ` Rob Herring
2020-01-22 21:23 ` [alsa-devel] " Couret Charles-Antoine
2020-01-22 21:23 ` Couret Charles-Antoine
2020-01-22 16:16 ` [alsa-devel] " Rob Herring
2020-01-22 16:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122161556.GA23997@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=charles-antoine.couret@essensium.com \
--cc=devicetree@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.