From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>, mszeredi@redhat.com
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open
Date: Wed, 22 Jan 2020 18:41:25 +0000 [thread overview]
Message-ID: <20200122184125.GR3263@work-vm> (raw)
In-Reply-To: <20200120025330.32140-1-misono.tomohiro@jp.fujitsu.com>
* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> Since keep_cache(FOPEN_KEEP_CACHE) has no effect for directory as
> described in fuse_common.h, use cache_readdir(FOPNE_CACHE_DIR) for
> diretory open when cache=always mode.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
cc'ing Miklos.
> ---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 5519682daa..088fef08f1 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -1674,7 +1674,7 @@ static void lo_opendir(fuse_req_t req, fuse_ino_t ino,
>
> fi->fh = fh;
> if (lo->cache == CACHE_ALWAYS) {
> - fi->keep_cache = 1;
> + fi->cache_readdir = 1;
> }
> fuse_reply_open(req, fi);
> return;
> --
> 2.21.1
>
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-01-22 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 2:53 [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open Misono Tomohiro
2020-01-22 18:41 ` Dr. David Alan Gilbert [this message]
2020-01-22 18:55 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122184125.GR3263@work-vm \
--to=dgilbert@redhat.com \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=mszeredi@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.