* [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open
@ 2020-01-20 2:53 Misono Tomohiro
2020-01-22 18:41 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Misono Tomohiro @ 2020-01-20 2:53 UTC (permalink / raw)
To: virtio-fs
Since keep_cache(FOPEN_KEEP_CACHE) has no effect for directory as
described in fuse_common.h, use cache_readdir(FOPNE_CACHE_DIR) for
diretory open when cache=always mode.
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
---
tools/virtiofsd/passthrough_ll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 5519682daa..088fef08f1 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -1674,7 +1674,7 @@ static void lo_opendir(fuse_req_t req, fuse_ino_t ino,
fi->fh = fh;
if (lo->cache == CACHE_ALWAYS) {
- fi->keep_cache = 1;
+ fi->cache_readdir = 1;
}
fuse_reply_open(req, fi);
return;
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open
2020-01-20 2:53 [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open Misono Tomohiro
@ 2020-01-22 18:41 ` Dr. David Alan Gilbert
2020-01-22 18:55 ` Miklos Szeredi
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2020-01-22 18:41 UTC (permalink / raw)
To: Misono Tomohiro, mszeredi; +Cc: virtio-fs
* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> Since keep_cache(FOPEN_KEEP_CACHE) has no effect for directory as
> described in fuse_common.h, use cache_readdir(FOPNE_CACHE_DIR) for
> diretory open when cache=always mode.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
cc'ing Miklos.
> ---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 5519682daa..088fef08f1 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -1674,7 +1674,7 @@ static void lo_opendir(fuse_req_t req, fuse_ino_t ino,
>
> fi->fh = fh;
> if (lo->cache == CACHE_ALWAYS) {
> - fi->keep_cache = 1;
> + fi->cache_readdir = 1;
> }
> fuse_reply_open(req, fi);
> return;
> --
> 2.21.1
>
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open
2020-01-22 18:41 ` Dr. David Alan Gilbert
@ 2020-01-22 18:55 ` Miklos Szeredi
0 siblings, 0 replies; 3+ messages in thread
From: Miklos Szeredi @ 2020-01-22 18:55 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: virtio-fs-list
On Wed, Jan 22, 2020 at 7:41 PM Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> > Since keep_cache(FOPEN_KEEP_CACHE) has no effect for directory as
> > described in fuse_common.h, use cache_readdir(FOPNE_CACHE_DIR) for
> > diretory open when cache=always mode.
> >
> > Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
>
> cc'ing Miklos.
Looks good, ack.
>
> > ---
> > tools/virtiofsd/passthrough_ll.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> > index 5519682daa..088fef08f1 100644
> > --- a/tools/virtiofsd/passthrough_ll.c
> > +++ b/tools/virtiofsd/passthrough_ll.c
> > @@ -1674,7 +1674,7 @@ static void lo_opendir(fuse_req_t req, fuse_ino_t ino,
> >
> > fi->fh = fh;
> > if (lo->cache == CACHE_ALWAYS) {
> > - fi->keep_cache = 1;
> > + fi->cache_readdir = 1;
> > }
> > fuse_reply_open(req, fi);
> > return;
> > --
> > 2.21.1
> >
> >
> > _______________________________________________
> > Virtio-fs mailing list
> > Virtio-fs@redhat.com
> > https://www.redhat.com/mailman/listinfo/virtio-fs
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-22 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-20 2:53 [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: Use cache_readdir for directory open Misono Tomohiro
2020-01-22 18:41 ` Dr. David Alan Gilbert
2020-01-22 18:55 ` Miklos Szeredi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.