From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: "Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: [PATCH 4/6] tests/acceptance/virtio_seg_max_adjust: Only test Xen as superuser
Date: Wed, 22 Jan 2020 23:32:45 +0100 [thread overview]
Message-ID: <20200122223247.30419-5-philmd@redhat.com> (raw)
In-Reply-To: <20200122223247.30419-1-philmd@redhat.com>
When running the test unprivileged, we get:
$ avocado --show=app,machine run tests/acceptance/virtio_seg_max_adjust.py
JOB ID : b631d5d692e49b791b211d33b80730315d561d45
JOB LOG : job-results/job-2020-01-22T17.56-b631d5d/job.log
(1/1) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types:
machine: {'name': 'pc-i440fx-2.12', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
machine: {'name': 'pc-i440fx-2.0', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
machine: {'name': 'xenpv', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
FAIL: machine type xenpv: <class 'qemu.qmp.QMPConnectError'> (0.40 s)
Looking at the job.log file we find:
xencall: error: Could not obtain handle on privileged command interface: No such file or directory
xen be core: xen be core: can't open xen interface
Do not run this test on Xen machines if not superuser.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/acceptance/virtio_seg_max_adjust.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py
index f679b0eec7..ad736bcda3 100755
--- a/tests/acceptance/virtio_seg_max_adjust.py
+++ b/tests/acceptance/virtio_seg_max_adjust.py
@@ -118,6 +118,8 @@ class VirtioMaxSegSettingsCheck(Test):
def test_machine_types(self):
EXCLUDED_MACHINES = ['none', 'isapc', 'microvm']
+ if os.geteuid() != 0:
+ EXCLUDED_MACHINES += ['xenfv', 'xenpv']
# collect all machine types except the ones in EXCLUDED_MACHINES
with QEMUMachine(self.qemu_bin) as vm:
vm.launch()
--
2.21.1
next prev parent reply other threads:[~2020-01-22 22:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 22:32 [PATCH 0/6] tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86 Philippe Mathieu-Daudé
2020-01-22 22:32 ` [PATCH 1/6] tests/acceptance/virtio_seg_max_adjust: Only remove listed machines Philippe Mathieu-Daudé
2020-01-23 11:20 ` Cornelia Huck
2020-01-23 13:55 ` Wainer dos Santos Moschetta
2020-01-22 22:32 ` [PATCH 2/6] tests/acceptance/virtio_seg_max_adjust: Improve exception logging Philippe Mathieu-Daudé
2020-01-22 22:32 ` [PATCH 3/6] tests/acceptance/virtio_seg_max_adjust: List machine being tested Philippe Mathieu-Daudé
2020-01-22 22:32 ` Philippe Mathieu-Daudé [this message]
2020-01-23 11:28 ` [PATCH 4/6] tests/acceptance/virtio_seg_max_adjust: Only test Xen as superuser Cornelia Huck
2020-01-22 22:32 ` [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture Philippe Mathieu-Daudé
2020-01-23 11:48 ` Cornelia Huck
2020-01-23 13:36 ` Wainer dos Santos Moschetta
2020-01-23 16:00 ` Cornelia Huck
2020-01-22 22:32 ` [PATCH 6/6] tests/acceptance/virtio_seg_max_adjust: Restrict to Linux host Philippe Mathieu-Daudé
2020-01-23 11:51 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122223247.30419-5-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.