From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: "Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: [PATCH 6/6] tests/acceptance/virtio_seg_max_adjust: Restrict to Linux host
Date: Wed, 22 Jan 2020 23:32:47 +0100 [thread overview]
Message-ID: <20200122223247.30419-7-philmd@redhat.com> (raw)
In-Reply-To: <20200122223247.30419-1-philmd@redhat.com>
This test is failing on OSX:
TestFail: machine type pc-i440fx-2.0: <class 'TypeError'>
Looking at the job.log:
Unexpected error in object_property_find() at qom/object.c:1201:
qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found
Which makes sense looking at hw/block/virtio-blk.c:
1261 static Property virtio_blk_properties[] = {
1262 DEFINE_BLOCK_PROPERTIES(VirtIOBlock, conf.conf),
...
1268 #ifdef __linux__
1269 DEFINE_PROP_BIT64("scsi", VirtIOBlock, host_features,
1270 VIRTIO_BLK_F_SCSI, false),
1271 #endif
Fix by only running this test on a Linux host:
(38/55) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types: SKIP: Host OS is not Linux
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/acceptance/virtio_seg_max_adjust.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py
index 2fc6bfcbd8..f8fd03e3b6 100755
--- a/tests/acceptance/virtio_seg_max_adjust.py
+++ b/tests/acceptance/virtio_seg_max_adjust.py
@@ -27,6 +27,7 @@ sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
from qemu.machine import QEMUMachine
from avocado_qemu import Test
from avocado.core.exceptions import TestSkipError
+from avocado import skipUnless
#list of machine types and virtqueue properties to test
VIRTIO_SCSI_PROPS = {'seg_max_adjust': 'seg_max_adjust'}
@@ -117,6 +118,8 @@ class VirtioMaxSegSettingsCheck(Test):
return True
return False
+
+ @skipUnless(sys.platform.startswith('linux'), 'Host OS is not Linux')
def test_machine_types(self):
"""
:avocado: tags=arch:i386
--
2.21.1
next prev parent reply other threads:[~2020-01-22 22:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 22:32 [PATCH 0/6] tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86 Philippe Mathieu-Daudé
2020-01-22 22:32 ` [PATCH 1/6] tests/acceptance/virtio_seg_max_adjust: Only remove listed machines Philippe Mathieu-Daudé
2020-01-23 11:20 ` Cornelia Huck
2020-01-23 13:55 ` Wainer dos Santos Moschetta
2020-01-22 22:32 ` [PATCH 2/6] tests/acceptance/virtio_seg_max_adjust: Improve exception logging Philippe Mathieu-Daudé
2020-01-22 22:32 ` [PATCH 3/6] tests/acceptance/virtio_seg_max_adjust: List machine being tested Philippe Mathieu-Daudé
2020-01-22 22:32 ` [PATCH 4/6] tests/acceptance/virtio_seg_max_adjust: Only test Xen as superuser Philippe Mathieu-Daudé
2020-01-23 11:28 ` Cornelia Huck
2020-01-22 22:32 ` [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture Philippe Mathieu-Daudé
2020-01-23 11:48 ` Cornelia Huck
2020-01-23 13:36 ` Wainer dos Santos Moschetta
2020-01-23 16:00 ` Cornelia Huck
2020-01-22 22:32 ` Philippe Mathieu-Daudé [this message]
2020-01-23 11:51 ` [PATCH 6/6] tests/acceptance/virtio_seg_max_adjust: Restrict to Linux host Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122223247.30419-7-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.