From: Rob Herring <robh@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David Lechner" <david@lechnology.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Noralf Trønnes" <noralf@tronnes.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Chris Brandt" <chris.brandt@renesas.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
Date: Thu, 23 Jan 2020 08:41:55 -0600 [thread overview]
Message-ID: <20200123144155.GA29553@bogus> (raw)
In-Reply-To: <20200120190249.GA9619@ravnborg.org>
On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote:
> Hi David.
>
> > > +allOf:
> > > + - $ref: panel/panel-common.yaml#
> >
> > not all of these properties are applicable.
> >
>
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - dc-gpios
> > > + - reset-gpios
> >
> > Missing optional rotation and backlight properties.
>
> Thanks for catching this. I have written a little .yaml files
> since I applied this - and learned a little more of the syntax.
>
> See attached patch for my attempt to fix this.
> Please review.
>
> Sam
>
> From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Mon, 20 Jan 2020 19:55:04 +0100
> Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
>
> David Lechner noticed (paraphrased):
> - not all properties from panel-common are applicable.
> - missing optional rotation and backlight properties
>
> Fix this by listing all allowed properties, and do not allow other properties.
>
> Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
> Reported-by: David Lechner <david@lechnology.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: David Lechner <david@lechnology.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Lechner <david@lechnology.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
David Airlie <airlied@linux.ie>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Chris Brandt <chris.brandt@renesas.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
Date: Thu, 23 Jan 2020 08:41:55 -0600 [thread overview]
Message-ID: <20200123144155.GA29553@bogus> (raw)
In-Reply-To: <20200120190249.GA9619@ravnborg.org>
On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote:
> Hi David.
>
> > > +allOf:
> > > + - $ref: panel/panel-common.yaml#
> >
> > not all of these properties are applicable.
> >
>
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - dc-gpios
> > > + - reset-gpios
> >
> > Missing optional rotation and backlight properties.
>
> Thanks for catching this. I have written a little .yaml files
> since I applied this - and learned a little more of the syntax.
>
> See attached patch for my attempt to fix this.
> Please review.
>
> Sam
>
> From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Mon, 20 Jan 2020 19:55:04 +0100
> Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
>
> David Lechner noticed (paraphrased):
> - not all properties from panel-common are applicable.
> - missing optional rotation and backlight properties
>
> Fix this by listing all allowed properties, and do not allow other properties.
>
> Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
> Reported-by: David Lechner <david@lechnology.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: David Lechner <david@lechnology.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-23 14:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 12:45 [PATCH v2 0/5] drm: Add support for Okaya RH128128T Geert Uytterhoeven
2020-01-15 12:45 ` Geert Uytterhoeven
2020-01-15 12:45 ` [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema Geert Uytterhoeven
2020-01-15 12:45 ` [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven
2020-01-15 21:01 ` [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: " Sam Ravnborg
2020-01-15 21:01 ` Sam Ravnborg
2020-01-15 22:06 ` Geert Uytterhoeven
2020-01-15 22:06 ` [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven
2020-01-20 16:00 ` [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: " David Lechner
2020-01-20 16:00 ` [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: " David Lechner
2020-01-20 19:02 ` [PATCH] dt-bindings: restrict properties for sitronix,st7735r Sam Ravnborg
2020-01-20 19:02 ` Sam Ravnborg
2020-01-23 7:24 ` Sam Ravnborg
2020-01-23 7:24 ` Sam Ravnborg
2020-01-23 7:43 ` Geert Uytterhoeven
2020-01-23 7:43 ` Geert Uytterhoeven
2020-01-23 18:19 ` Sam Ravnborg
2020-01-23 18:19 ` Sam Ravnborg
2020-01-23 14:41 ` Rob Herring [this message]
2020-01-23 14:41 ` Rob Herring
2020-01-15 12:45 ` [PATCH v2 2/5] dt-bindings: display: sitronix,st7735r: Add Okaya RH128128T Geert Uytterhoeven
2020-01-15 12:45 ` [PATCH v2 2/5] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven
2020-01-15 21:01 ` [PATCH v2 2/5] dt-bindings: display: sitronix,st7735r: " Sam Ravnborg
2020-01-15 21:01 ` [PATCH v2 2/5] dt-bindings: display: sitronix, st7735r: " Sam Ravnborg
2020-01-15 12:45 ` [PATCH v2 3/5] drm/mipi_dbi: Add support for display offsets Geert Uytterhoeven
2020-01-15 12:45 ` Geert Uytterhoeven
2020-01-17 21:12 ` Sam Ravnborg
2020-01-17 21:12 ` Sam Ravnborg
2020-01-19 16:03 ` Noralf Trønnes
2020-01-19 16:03 ` Noralf Trønnes
2020-01-15 12:45 ` [PATCH v2 4/5] drm: tiny: st7735r: Prepare for adding support for more displays Geert Uytterhoeven
2020-01-15 12:45 ` Geert Uytterhoeven
2020-01-15 12:45 ` [PATCH v2 5/5] drm: tiny: st7735r: Add support for Okaya RH128128T Geert Uytterhoeven
2020-01-15 12:45 ` Geert Uytterhoeven
2020-01-19 17:15 ` [PATCH v2 0/5] drm: " Sam Ravnborg
2020-01-19 17:15 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123144155.GA29553@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=chris.brandt@renesas.com \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.