From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de, pmeerw@pmeerw.net,
fabrice.gasnier@st.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com,
knaack.h@gmx.de, linux-stm32@st-md-mailman.stormreply.com,
jic23@kernel.org
Subject: Re: [alsa-devel] [PATCH] dt-bindings: stm32: convert dfsdm to json-schema
Date: Thu, 23 Jan 2020 09:30:02 -0600 [thread overview]
Message-ID: <20200123153002.GA14241@bogus> (raw)
In-Reply-To: <20200123083432.21997-1-olivier.moysan@st.com>
On Thu, Jan 23, 2020 at 09:34:31AM +0100, Olivier Moysan wrote:
> Convert the STM32 DFSDM bindings to DT schema format
> using json-schema.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> ---
> The DT check still returns some warnings on this bindings:
> dfsdm@4400d000: filter@4: 'st,adc-channels' is a required property
> dfsdm@4400d000: filter@5: 'st,adc-channels' is a required property ...
>
> These warnings occur because some disabled nodes do not provides the
> required properties. These nodes are included from SoC DT,
> and do not provides by default the properties which are board dependent.
We handle disabled nodes, but not when they are child nodes.
> As workaround in DFSDM yaml bindings, the properties
> (like st,adc-channels) could be defined as required,
> only for the nodes which are in enabled state.
We should handle this in the tooling, not the schemas. I entered an
issue to track this[1].
> ---
> .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 135 -------
> .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 332 ++++++++++++++++++
> 2 files changed, 332 insertions(+), 135 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
Applied.
[1] https://github.com/devicetree-org/dt-schema/issues/32
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: jic23@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
mark.rutland@arm.com, mcoquelin.stm32@gmail.com, lars@metafoo.de,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: stm32: convert dfsdm to json-schema
Date: Thu, 23 Jan 2020 09:30:02 -0600 [thread overview]
Message-ID: <20200123153002.GA14241@bogus> (raw)
In-Reply-To: <20200123083432.21997-1-olivier.moysan@st.com>
On Thu, Jan 23, 2020 at 09:34:31AM +0100, Olivier Moysan wrote:
> Convert the STM32 DFSDM bindings to DT schema format
> using json-schema.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> ---
> The DT check still returns some warnings on this bindings:
> dfsdm@4400d000: filter@4: 'st,adc-channels' is a required property
> dfsdm@4400d000: filter@5: 'st,adc-channels' is a required property ...
>
> These warnings occur because some disabled nodes do not provides the
> required properties. These nodes are included from SoC DT,
> and do not provides by default the properties which are board dependent.
We handle disabled nodes, but not when they are child nodes.
> As workaround in DFSDM yaml bindings, the properties
> (like st,adc-channels) could be defined as required,
> only for the nodes which are in enabled state.
We should handle this in the tooling, not the schemas. I entered an
issue to track this[1].
> ---
> .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 135 -------
> .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 332 ++++++++++++++++++
> 2 files changed, 332 insertions(+), 135 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
Applied.
[1] https://github.com/devicetree-org/dt-schema/issues/32
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de, pmeerw@pmeerw.net,
fabrice.gasnier@st.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com,
knaack.h@gmx.de, perex@perex.cz,
linux-stm32@st-md-mailman.stormreply.com, jic23@kernel.org
Subject: Re: [PATCH] dt-bindings: stm32: convert dfsdm to json-schema
Date: Thu, 23 Jan 2020 09:30:02 -0600 [thread overview]
Message-ID: <20200123153002.GA14241@bogus> (raw)
In-Reply-To: <20200123083432.21997-1-olivier.moysan@st.com>
On Thu, Jan 23, 2020 at 09:34:31AM +0100, Olivier Moysan wrote:
> Convert the STM32 DFSDM bindings to DT schema format
> using json-schema.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> ---
> The DT check still returns some warnings on this bindings:
> dfsdm@4400d000: filter@4: 'st,adc-channels' is a required property
> dfsdm@4400d000: filter@5: 'st,adc-channels' is a required property ...
>
> These warnings occur because some disabled nodes do not provides the
> required properties. These nodes are included from SoC DT,
> and do not provides by default the properties which are board dependent.
We handle disabled nodes, but not when they are child nodes.
> As workaround in DFSDM yaml bindings, the properties
> (like st,adc-channels) could be defined as required,
> only for the nodes which are in enabled state.
We should handle this in the tooling, not the schemas. I entered an
issue to track this[1].
> ---
> .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 135 -------
> .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 332 ++++++++++++++++++
> 2 files changed, 332 insertions(+), 135 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
Applied.
[1] https://github.com/devicetree-org/dt-schema/issues/32
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-23 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 8:34 [alsa-devel] [PATCH] dt-bindings: stm32: convert dfsdm to json-schema Olivier Moysan
2020-01-23 8:34 ` Olivier Moysan
2020-01-23 8:34 ` Olivier Moysan
2020-01-23 15:30 ` Rob Herring [this message]
2020-01-23 15:30 ` Rob Herring
2020-01-23 15:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123153002.GA14241@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=pmeerw@pmeerw.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.