From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
maz@kernel.org, suzuki.poulose@arm.com, sudeep.holla@arm.com,
dietmar.eggemann@arm.com, peterz@infradead.org, mingo@redhat.com,
ggherdovich@suse.cz, vincent.guittot@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Steve Capper <steve.capper@arm.com>
Subject: Re: [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0
Date: Thu, 23 Jan 2020 17:34:56 +0000 [thread overview]
Message-ID: <20200123173456.GA20475@arm.com> (raw)
In-Reply-To: <dcecb179-02f1-0608-6a84-5b2dd0bbcdb3@arm.com>
On Thursday 23 Jan 2020 at 17:04:32 (+0000), Valentin Schneider wrote:
> On 18/12/2019 18:26, Ionela Voinescu wrote:
> > +/*
> > + * reset_amuserenr_el0 - reset AMUSERENR_EL0 if AMUv1 present
> > + */
> > + .macro reset_amuserenr_el0, tmpreg
> > + mrs \tmpreg, id_aa64pfr0_el1 // Check ID_AA64PFR0_EL1
> > + ubfx \tmpreg, \tmpreg, #ID_AA64PFR0_AMU_SHIFT, #4
> > + cbz \tmpreg, 9000f // Skip if no AMU present
> > + msr_s SYS_AMUSERENR_EL0, xzr // Disable AMU access from EL0
> > +9000:
>
> AIUI you can steer away from the obscure numbering scheme and define the
> label using the macro counter:
>
> cbz \tmpreg, .Lskip_\@
> [...]
> .Lskip_\@:
> .endm
>
Cool, good to know! Although calling it "obscure numbering scheme" does
make it more appealing to use.
Thanks, I'll change it in the next version :).
Ionela.
>
> > + .endm
WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: mark.rutland@arm.com, maz@kernel.org, suzuki.poulose@arm.com,
peterz@infradead.org, catalin.marinas@arm.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, ggherdovich@suse.cz, sudeep.holla@arm.com,
will@kernel.org, dietmar.eggemann@arm.com,
linux-arm-kernel@lists.infradead.org,
Steve Capper <steve.capper@arm.com>
Subject: Re: [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0
Date: Thu, 23 Jan 2020 17:34:56 +0000 [thread overview]
Message-ID: <20200123173456.GA20475@arm.com> (raw)
In-Reply-To: <dcecb179-02f1-0608-6a84-5b2dd0bbcdb3@arm.com>
On Thursday 23 Jan 2020 at 17:04:32 (+0000), Valentin Schneider wrote:
> On 18/12/2019 18:26, Ionela Voinescu wrote:
> > +/*
> > + * reset_amuserenr_el0 - reset AMUSERENR_EL0 if AMUv1 present
> > + */
> > + .macro reset_amuserenr_el0, tmpreg
> > + mrs \tmpreg, id_aa64pfr0_el1 // Check ID_AA64PFR0_EL1
> > + ubfx \tmpreg, \tmpreg, #ID_AA64PFR0_AMU_SHIFT, #4
> > + cbz \tmpreg, 9000f // Skip if no AMU present
> > + msr_s SYS_AMUSERENR_EL0, xzr // Disable AMU access from EL0
> > +9000:
>
> AIUI you can steer away from the obscure numbering scheme and define the
> label using the macro counter:
>
> cbz \tmpreg, .Lskip_\@
> [...]
> .Lskip_\@:
> .endm
>
Cool, good to know! Although calling it "obscure numbering scheme" does
make it more appealing to use.
Thanks, I'll change it in the next version :).
Ionela.
>
> > + .endm
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-23 17:35 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 18:26 [PATCH v2 0/6] arm64: ARMv8.4 Activity Monitors support Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2019-12-18 18:26 ` [PATCH v2 1/6] arm64: add support for the AMU extension v1 Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2020-01-23 17:04 ` Valentin Schneider
2020-01-23 17:04 ` Valentin Schneider
2020-01-23 18:32 ` Ionela Voinescu
2020-01-23 18:32 ` Ionela Voinescu
2020-01-24 12:00 ` Valentin Schneider
2020-01-24 12:00 ` Valentin Schneider
2020-01-28 11:00 ` Ionela Voinescu
2020-01-28 11:00 ` Ionela Voinescu
2020-01-28 16:34 ` Suzuki Kuruppassery Poulose
2020-01-28 16:34 ` Suzuki Kuruppassery Poulose
2020-01-29 16:42 ` Ionela Voinescu
2020-01-29 16:42 ` Ionela Voinescu
2019-12-18 18:26 ` [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0 Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2020-01-23 17:04 ` Valentin Schneider
2020-01-23 17:04 ` Valentin Schneider
2020-01-23 17:34 ` Ionela Voinescu [this message]
2020-01-23 17:34 ` Ionela Voinescu
2019-12-18 18:26 ` [PATCH v2 3/6] arm64/kvm: disable access to AMU registers from kvm guests Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2020-01-27 15:33 ` Valentin Schneider
2020-01-27 15:33 ` Valentin Schneider
2020-01-28 15:48 ` Ionela Voinescu
2020-01-28 15:48 ` Ionela Voinescu
2020-01-28 17:26 ` Suzuki Kuruppassery Poulose
2020-01-28 17:26 ` Suzuki Kuruppassery Poulose
2020-01-28 17:37 ` Valentin Schneider
2020-01-28 17:37 ` Valentin Schneider
2020-01-28 17:52 ` Ionela Voinescu
2020-01-28 17:52 ` Ionela Voinescu
2019-12-18 18:26 ` [PATCH v2 4/6] Documentation: arm64: document support for the AMU extension Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2020-01-27 16:47 ` Valentin Schneider
2020-01-27 16:47 ` Valentin Schneider
2020-01-28 16:53 ` Ionela Voinescu
2020-01-28 16:53 ` Ionela Voinescu
2020-01-28 18:36 ` Valentin Schneider
2020-01-28 18:36 ` Valentin Schneider
2020-01-30 15:04 ` Suzuki Kuruppassery Poulose
2020-01-30 15:04 ` Suzuki Kuruppassery Poulose
2020-01-30 16:45 ` Ionela Voinescu
2020-01-30 16:45 ` Ionela Voinescu
2020-01-30 18:26 ` Suzuki K Poulose
2020-01-30 18:26 ` Suzuki K Poulose
2020-01-31 9:54 ` Ionela Voinescu
2020-01-31 9:54 ` Ionela Voinescu
2019-12-18 18:26 ` [PATCH v2 5/6] TEMP: sched: add interface for counter-based frequency invariance Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2020-01-29 19:37 ` Peter Zijlstra
2020-01-29 19:37 ` Peter Zijlstra
2020-01-30 15:33 ` Ionela Voinescu
2020-01-30 15:33 ` Ionela Voinescu
2019-12-18 18:26 ` [PATCH v2 6/6] arm64: use activity monitors for " Ionela Voinescu
2019-12-18 18:26 ` Ionela Voinescu
2020-01-23 11:49 ` Lukasz Luba
2020-01-23 11:49 ` Lukasz Luba
2020-01-23 17:07 ` Ionela Voinescu
2020-01-23 17:07 ` Ionela Voinescu
2020-01-24 1:19 ` Lukasz Luba
2020-01-24 1:19 ` Lukasz Luba
2020-01-24 13:12 ` Ionela Voinescu
2020-01-24 13:12 ` Ionela Voinescu
2020-01-24 15:17 ` Lukasz Luba
2020-01-24 15:17 ` Lukasz Luba
2020-01-28 17:36 ` Ionela Voinescu
2020-01-28 17:36 ` Ionela Voinescu
2020-01-29 17:13 ` Valentin Schneider
2020-01-29 17:13 ` Valentin Schneider
2020-01-29 17:52 ` Ionela Voinescu
2020-01-29 17:52 ` Ionela Voinescu
2020-01-29 23:39 ` Valentin Schneider
2020-01-29 23:39 ` Valentin Schneider
2020-01-30 15:49 ` Ionela Voinescu
2020-01-30 15:49 ` Ionela Voinescu
2020-01-30 16:11 ` Valentin Schneider
2020-01-30 16:11 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123173456.GA20475@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ggherdovich@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=steve.capper@arm.com \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.