All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: peng.fan@nxp.com, arnd@arndb.de, jassisinghbrar@gmail.com,
	linux-kernel@vger.kernel.org, peter.hilber@opensynergy.com,
	linux-arm-kernel@lists.infradead.org,
	Sudeep Holla <sudeep.holla@arm.com>,
	cristian.marussi@arm.com
Subject: Re: [PATCH V4] firmware: arm_scmi: Make scmi core independent of the transport type
Date: Fri, 24 Jan 2020 11:22:35 +0000	[thread overview]
Message-ID: <20200124112235.GA40307@bogus> (raw)
In-Reply-To: <20200124030212.qjlzz75dgt5kla7t@vireshk-i7>

On Fri, Jan 24, 2020 at 08:32:12AM +0530, Viresh Kumar wrote:

[...]

>
> I think this defines the problem somewhat, though I wasn't able to
> reproduce the problem on my platform :)

No worries, I found the issue. It's devm_kzalloc in mailbox_chan_setup.
You need to pin the allocation with dev the main scmi platform device and
not individual protocol specific scmi_device. Basically, change cdev to
dev in there. It fixed the issue. You have it correct later for payload
devm_ioremap. I couldn't review the change in detail yet, allow me today.
You can post next version next week, anyways too late for v5.6 ;).

Peng, Peter,

Any comments on this ? I hope you are happy with this for SMC and virtio
based transport.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: arnd@arndb.de, jassisinghbrar@gmail.com,
	cristian.marussi@arm.com, peng.fan@nxp.com,
	peter.hilber@opensynergy.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH V4] firmware: arm_scmi: Make scmi core independent of the transport type
Date: Fri, 24 Jan 2020 11:22:35 +0000	[thread overview]
Message-ID: <20200124112235.GA40307@bogus> (raw)
In-Reply-To: <20200124030212.qjlzz75dgt5kla7t@vireshk-i7>

On Fri, Jan 24, 2020 at 08:32:12AM +0530, Viresh Kumar wrote:

[...]

>
> I think this defines the problem somewhat, though I wasn't able to
> reproduce the problem on my platform :)

No worries, I found the issue. It's devm_kzalloc in mailbox_chan_setup.
You need to pin the allocation with dev the main scmi platform device and
not individual protocol specific scmi_device. Basically, change cdev to
dev in there. It fixed the issue. You have it correct later for payload
devm_ioremap. I couldn't review the change in detail yet, allow me today.
You can post next version next week, anyways too late for v5.6 ;).

Peng, Peter,

Any comments on this ? I hope you are happy with this for SMC and virtio
based transport.

--
Regards,
Sudeep

  reply	other threads:[~2020-01-24 11:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  8:27 [PATCH V3] firmware: arm_scmi: Make scmi core independent of the transport type Viresh Kumar
2020-01-21  8:27 ` Viresh Kumar
2020-01-21 15:11 ` Arnd Bergmann
2020-01-21 15:11   ` Arnd Bergmann
2020-01-21 18:38   ` Sudeep Holla
2020-01-21 18:38     ` Sudeep Holla
2020-01-22  2:36     ` [PATCH V4] " Viresh Kumar
2020-01-22  2:36       ` Viresh Kumar
2020-01-22 12:15       ` Sudeep Holla
2020-01-22 12:15         ` Sudeep Holla
2020-01-23 10:30         ` Sudeep Holla
2020-01-23 10:30           ` Sudeep Holla
2020-01-23 11:27           ` Viresh Kumar
2020-01-23 11:27             ` Viresh Kumar
2020-01-23 11:37             ` Cristian Marussi
2020-01-23 11:37               ` Cristian Marussi
2020-01-23 15:17             ` Sudeep Holla
2020-01-23 15:17               ` Sudeep Holla
2020-01-24  3:02           ` Viresh Kumar
2020-01-24  3:02             ` Viresh Kumar
2020-01-24 11:22             ` Sudeep Holla [this message]
2020-01-24 11:22               ` Sudeep Holla
2020-01-24 12:15       ` Peter Hilber
2020-01-24 12:15         ` Peter Hilber
2020-01-24 18:28         ` Jassi Brar
2020-01-24 18:28           ` Jassi Brar
2020-01-22 12:44 ` [PATCH V3] " Cristian Marussi
2020-01-22 12:44   ` Cristian Marussi
2020-01-23  2:39   ` Viresh Kumar
2020-01-23  2:39     ` Viresh Kumar
2020-01-23 11:06     ` Cristian Marussi
2020-01-23 11:06       ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124112235.GA40307@bogus \
    --to=sudeep.holla@arm.com \
    --cc=arnd@arndb.de \
    --cc=cristian.marussi@arm.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peter.hilber@opensynergy.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.