All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Jitao Shi <jitao.shi@mediatek.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing
Date: Sat, 25 Jan 2020 07:12:36 +0100	[thread overview]
Message-ID: <20200125061236.GA25729@ravnborg.org> (raw)
In-Reply-To: <20200125050256.107404-1-drinkcat@chromium.org>

Hi Nicolas.

On Sat, Jan 25, 2020 at 01:02:56PM +0800, Nicolas Boichat wrote:
> The datasheet suggests 60 for tHFP, so let's adjust the number
> accordingly.
> 
> This also makes the framerate be 60Hz as intended:
> 159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10))
> => 60.00 Hz
> 
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>

Thanks. Added Fixes: tag and applied to drm-misc-next.

	Sam


> 
> ---
> 
> This also matches the values that we use in our chromeos-4.19
> vendor kernel.
> 
> Applies on top or drm-misc/drm-misc-next.
> 
>  drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 01faf8597700005..48a164257d18c35 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = {
>  	.hdisplay = 1200,
>  	.hsync_start = 1200 + 80,
>  	.hsync_end = 1200 + 80 + 24,
> -	.htotal = 1200 + 80 + 24 + 40,
> +	.htotal = 1200 + 80 + 24 + 60,
>  	.vdisplay = 1920,
>  	.vsync_start = 1920 + 20,
>  	.vsync_end = 1920 + 20 + 4,
> -- 
> 2.25.0.341.g760bfbb309-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Jitao Shi <jitao.shi@mediatek.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing
Date: Sat, 25 Jan 2020 07:12:36 +0100	[thread overview]
Message-ID: <20200125061236.GA25729@ravnborg.org> (raw)
In-Reply-To: <20200125050256.107404-1-drinkcat@chromium.org>

Hi Nicolas.

On Sat, Jan 25, 2020 at 01:02:56PM +0800, Nicolas Boichat wrote:
> The datasheet suggests 60 for tHFP, so let's adjust the number
> accordingly.
> 
> This also makes the framerate be 60Hz as intended:
> 159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10))
> => 60.00 Hz
> 
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>

Thanks. Added Fixes: tag and applied to drm-misc-next.

	Sam


> 
> ---
> 
> This also matches the values that we use in our chromeos-4.19
> vendor kernel.
> 
> Applies on top or drm-misc/drm-misc-next.
> 
>  drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 01faf8597700005..48a164257d18c35 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = {
>  	.hdisplay = 1200,
>  	.hsync_start = 1200 + 80,
>  	.hsync_end = 1200 + 80 + 24,
> -	.htotal = 1200 + 80 + 24 + 40,
> +	.htotal = 1200 + 80 + 24 + 60,
>  	.vdisplay = 1920,
>  	.vsync_start = 1920 + 20,
>  	.vsync_end = 1920 + 20 + 4,
> -- 
> 2.25.0.341.g760bfbb309-goog

  reply	other threads:[~2020-01-25  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-25  5:02 [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing Nicolas Boichat
2020-01-25  5:02 ` Nicolas Boichat
2020-01-25  6:12 ` Sam Ravnborg [this message]
2020-01-25  6:12   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200125061236.GA25729@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drinkcat@chromium.org \
    --cc=jitao.shi@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.