From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Anilkumar Kolli <akolli@codeaurora.org>,
Manikanta Pubbisetty <mpubbise@codeaurora.org>,
Sven Eckelmann <seckelmann@datto.com>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath11k: ensure ts.flags is initialized before bit-wise or'ing in values
Date: Sun, 26 Jan 2020 10:45:45 +0000 [thread overview]
Message-ID: <20200126104545.83226C447A2@smtp.codeaurora.org> (raw)
In-Reply-To: <20191221004046.15859-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> Currently the structure ts is not inititalized and ts.flags contains
> garbage values from the stack. This is being passed into function
> ath11k_dp_tx_status_parse that bit-wise or'ing in settings into the
> ts.flags field. To avoid flags (and other fields) from containing
> garbage, initialize the structure to zero before use.
>
> Addresses-Coverity: ("Uninitialized scalar variable)"
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
eefca584140b ath11k: ensure ts.flags is initialized before bit-wise or'ing in values
--
https://patchwork.kernel.org/patch/11306545/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Anilkumar Kolli <akolli@codeaurora.org>,
Manikanta Pubbisetty <mpubbise@codeaurora.org>,
Sven Eckelmann <seckelmann@datto.com>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath11k: ensure ts.flags is initialized before bit-wise or'ing in values
Date: Sun, 26 Jan 2020 10:45:45 +0000 (UTC) [thread overview]
Message-ID: <20200126104545.83226C447A2@smtp.codeaurora.org> (raw)
In-Reply-To: <20191221004046.15859-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> Currently the structure ts is not inititalized and ts.flags contains
> garbage values from the stack. This is being passed into function
> ath11k_dp_tx_status_parse that bit-wise or'ing in settings into the
> ts.flags field. To avoid flags (and other fields) from containing
> garbage, initialize the structure to zero before use.
>
> Addresses-Coverity: ("Uninitialized scalar variable)"
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
eefca584140b ath11k: ensure ts.flags is initialized before bit-wise or'ing in values
--
https://patchwork.kernel.org/patch/11306545/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-01-26 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 0:40 [PATCH] ath11k: ensure ts.flags is initialized before bit-wise or'ing in values Colin King
2019-12-21 0:40 ` Colin King
2020-01-26 10:45 ` Kalle Valo [this message]
2020-01-26 10:45 ` Kalle Valo
2020-01-26 10:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126104545.83226C447A2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=seckelmann@datto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.