All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Peter Chen <peter.chen-3arQi8VN3Tc@public.gmane.org>,
	Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: chipidea: tegra: fix hardlock with invalid dr mode
Date: Mon, 27 Jan 2020 08:17:58 +0100	[thread overview]
Message-ID: <20200127071758.GD279449@kroah.com> (raw)
In-Reply-To: <20200127023548.27107-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Sun, Jan 26, 2020 at 09:35:48PM -0500, Peter Geis wrote:
> The ci_hdrc_tegra driver does not currently support dual role mode, but
> it does not explicitly prevent its use.
> Certain devices support dual role mode, but not automatic role switch.
> This can cause the device to lock up during initialization of the
> driver.
> 
> Detect this state by checking for the extcon phandle when dual role mode
> is set to otg.
> If it doesn't exist request the driver to only enable manual role
> switching.
> 
> Fixes: dfebb5f ("usb: chipidea: Add support for Tegra20/30/114/124")

Please use 12 digits for kernel sha1 values, this should be:
Fixes: dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124")

As proof of the need of this, just using the values you gave here causes
git to complain:

$ git show dfebb5f
error: short SHA1 dfebb5f is ambiguous
hint: The candidates are:
hint:   dfebb5f43a78 commit 2017-08-16 - usb: chipidea: Add support for Tegra20/30/114/124
hint:   dfebb5fec744 tree
fatal: ambiguous argument 'dfebb5f': unknown revision or path not in the working tree.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Peter Chen <peter.chen@nxp.com>,
	Thierry Reding <treding@nvidia.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: tegra: fix hardlock with invalid dr mode
Date: Mon, 27 Jan 2020 08:17:58 +0100	[thread overview]
Message-ID: <20200127071758.GD279449@kroah.com> (raw)
In-Reply-To: <20200127023548.27107-1-pgwipeout@gmail.com>

On Sun, Jan 26, 2020 at 09:35:48PM -0500, Peter Geis wrote:
> The ci_hdrc_tegra driver does not currently support dual role mode, but
> it does not explicitly prevent its use.
> Certain devices support dual role mode, but not automatic role switch.
> This can cause the device to lock up during initialization of the
> driver.
> 
> Detect this state by checking for the extcon phandle when dual role mode
> is set to otg.
> If it doesn't exist request the driver to only enable manual role
> switching.
> 
> Fixes: dfebb5f ("usb: chipidea: Add support for Tegra20/30/114/124")

Please use 12 digits for kernel sha1 values, this should be:
Fixes: dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124")

As proof of the need of this, just using the values you gave here causes
git to complain:

$ git show dfebb5f
error: short SHA1 dfebb5f is ambiguous
hint: The candidates are:
hint:   dfebb5f43a78 commit 2017-08-16 - usb: chipidea: Add support for Tegra20/30/114/124
hint:   dfebb5fec744 tree
fatal: ambiguous argument 'dfebb5f': unknown revision or path not in the working tree.

thanks,

greg k-h

  parent reply	other threads:[~2020-01-27  7:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27  2:35 [PATCH] usb: chipidea: tegra: fix hardlock with invalid dr mode Peter Geis
2020-01-27  2:35 ` Peter Geis
     [not found] ` <20200127023548.27107-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-27  7:17   ` Greg KH [this message]
2020-01-27  7:17     ` Greg KH
     [not found]     ` <20200127071758.GD279449-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2020-01-27 15:25       ` Peter Geis
2020-01-27 15:25         ` Peter Geis
     [not found]         ` <CAMdYzYqctkfqhHN0-WDvX9kKdXH-AVir193SpcrR_t3K=VN=0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-27 15:38           ` Dmitry Osipenko
2020-01-27 15:38             ` Dmitry Osipenko
2020-01-31  5:27   ` Peter Chen
2020-01-31  5:27     ` Peter Chen
2020-01-31 20:43     ` Peter Geis
2020-01-31 20:43       ` Peter Geis
     [not found]       ` <CAMdYzYqwz9HLsjvc1hDmovzWqiV_Vswe57d_gWhwBnvb2aNPyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-01  6:13         ` Peter Chen
2020-02-01  6:13           ` Peter Chen
2020-02-03 17:22           ` Peter Geis
2020-02-03 17:22             ` Peter Geis
     [not found]             ` <CAMdYzYrbvsTunwxJLcC_-ZhczsQfyDLOjTnZ+eorb325qO-QhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-04  7:44               ` Peter Chen
2020-02-04  7:44                 ` Peter Chen
2020-02-04 14:35                 ` Peter Geis
2020-02-04 14:35                   ` Peter Geis
     [not found]                   ` <CAMdYzYo8Vgw8h=LtfLnQNF4j-rVzgKJTp1hCyf7BFKrdhAhAHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-05 11:17                     ` Peter Chen
2020-02-05 11:17                       ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200127071758.GD279449@kroah.com \
    --to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
    --cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.chen-3arQi8VN3Tc@public.gmane.org \
    --cc=pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.