From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY
Date: Mon, 27 Jan 2020 11:46:00 +0000 [thread overview]
Message-ID: <20200127114600.GU25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <BN8PR12MB3266714AE9EC1A97218120B3D30B0@BN8PR12MB3266.namprd12.prod.outlook.com>
On Mon, Jan 27, 2020 at 11:38:05AM +0000, Jose Abreu wrote:
> From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> Date: Jan/27/2020, 11:21:02 (UTC+00:00)
>
> > On Mon, Jan 27, 2020 at 12:09:11PM +0100, Jose Abreu wrote:
> > > When we don't have any real PHY driver connected and we get link up from
> > > PCS we shall configure MAC and PCS for the desired speed and also
> > > resolve the flow control settings from MAC side.
> >
> > This is certainly the wrong place for it. Please hold off on this patch
> > for the time being. Thanks.
>
> This is actually the change that makes everything work ...
>
> I need to configure PCS before Aneg is complete and then I need to
> configure MAC once Aneg is done and link is up with the outcome speed and
> flow control.
Yes, I realise that, but it comes with the expense of potentially
breaking mvneta and mvpp2, where the settings are automatically
passed between the PCS and MAC in hardware. I also believe DSA
works around this, and I need to look at that.
However, right now I'm in the middle of rebasing my git tree on
top of v5.5 and can't say much more until I've finished that.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY
Date: Mon, 27 Jan 2020 11:46:00 +0000 [thread overview]
Message-ID: <20200127114600.GU25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <BN8PR12MB3266714AE9EC1A97218120B3D30B0@BN8PR12MB3266.namprd12.prod.outlook.com>
On Mon, Jan 27, 2020 at 11:38:05AM +0000, Jose Abreu wrote:
> From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> Date: Jan/27/2020, 11:21:02 (UTC+00:00)
>
> > On Mon, Jan 27, 2020 at 12:09:11PM +0100, Jose Abreu wrote:
> > > When we don't have any real PHY driver connected and we get link up from
> > > PCS we shall configure MAC and PCS for the desired speed and also
> > > resolve the flow control settings from MAC side.
> >
> > This is certainly the wrong place for it. Please hold off on this patch
> > for the time being. Thanks.
>
> This is actually the change that makes everything work ...
>
> I need to configure PCS before Aneg is complete and then I need to
> configure MAC once Aneg is done and link is up with the outcome speed and
> flow control.
Yes, I realise that, but it comes with the expense of potentially
breaking mvneta and mvpp2, where the settings are automatically
passed between the PCS and MAC in hardware. I also believe DSA
works around this, and I need to look at that.
However, right now I'm in the middle of rebasing my git tree on
top of v5.5 and can't say much more until I've finished that.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-01-27 11:46 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 11:09 [RFC net-next 0/8] net: Add support for Synopsys DesignWare XPCS Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:09 ` [RFC net-next 1/8] net: stmmac: selftests: Do not fail if PHY is not attached Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:09 ` [RFC net-next 2/8] net: phylink: Add phylink_and and phylink_andnot Helpers Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:16 ` Russell King - ARM Linux admin
2020-01-27 11:16 ` Russell King - ARM Linux admin
2020-01-27 11:09 ` [RFC net-next 3/8] net: stmmac: Switch to phylink_and()/phylink_andnot() Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:09 ` [RFC net-next 4/8] net: stmmac: Fallback to dev_fwnode() if needed Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:09 ` [RFC net-next 5/8] net: phylink: Add missing Backplane speeds Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:09 ` [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:21 ` Russell King - ARM Linux admin
2020-01-27 11:21 ` Russell King - ARM Linux admin
2020-01-27 11:38 ` Jose Abreu
2020-01-27 11:38 ` Jose Abreu
2020-01-27 11:46 ` Russell King - ARM Linux admin [this message]
2020-01-27 11:46 ` Russell King - ARM Linux admin
2020-01-27 12:50 ` Jose Abreu
2020-01-27 12:50 ` Jose Abreu
2020-01-27 13:37 ` Russell King - ARM Linux admin
2020-01-27 13:37 ` Russell King - ARM Linux admin
2020-01-27 13:57 ` Jose Abreu
2020-01-27 13:57 ` Jose Abreu
2020-01-27 14:00 ` Andrew Lunn
2020-01-27 14:00 ` Andrew Lunn
2020-01-27 14:08 ` Russell King - ARM Linux admin
2020-01-27 14:08 ` Russell King - ARM Linux admin
2020-01-27 14:51 ` Andrew Lunn
2020-01-27 14:51 ` Andrew Lunn
2020-01-27 16:11 ` Russell King - ARM Linux admin
2020-01-27 16:11 ` Russell King - ARM Linux admin
2020-01-27 16:22 ` Andrew Lunn
2020-01-27 16:22 ` Andrew Lunn
2020-01-27 19:28 ` Heiner Kallweit
2020-01-27 19:28 ` Heiner Kallweit
2020-01-28 11:12 ` Jose Abreu
2020-01-28 11:12 ` Jose Abreu
2020-02-04 17:26 ` Russell King - ARM Linux admin
2020-02-04 17:26 ` Russell King - ARM Linux admin
2020-02-04 17:43 ` Andrew Lunn
2020-02-04 17:43 ` Andrew Lunn
2020-02-04 19:32 ` Russell King - ARM Linux admin
2020-02-04 19:32 ` Russell King - ARM Linux admin
2020-02-05 12:27 ` Russell King - ARM Linux admin
2020-02-05 12:27 ` Russell King - ARM Linux admin
2020-02-07 11:21 ` Russell King - ARM Linux admin
2020-02-07 11:21 ` Russell King - ARM Linux admin
2020-01-27 16:32 ` Andrew Lunn
2020-01-27 16:32 ` Andrew Lunn
2020-01-27 17:56 ` Russell King - ARM Linux admin
2020-01-27 17:56 ` Russell King - ARM Linux admin
2020-01-28 18:08 ` Russell King - ARM Linux admin
2020-01-28 18:08 ` Russell King - ARM Linux admin
2020-01-28 18:25 ` Andrew Lunn
2020-01-28 18:25 ` Andrew Lunn
2020-01-27 11:09 ` [RFC net-next 7/8] net: phy: Add Synopsys DesignWare XPCS MDIO module Jose Abreu
2020-01-27 11:09 ` Jose Abreu
2020-01-27 11:09 ` [RFC net-next 8/8] net: stmmac: Integrate it with DesignWare XPCS Jose Abreu
2020-01-27 11:09 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127114600.GU25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.