Re: [PATCH v4 5/7] iio: temperature: Add support for Azoteq IQS620AT temperature sensor

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Wed, 22 Jan 2020 03:28:28 +0000
Jeff LaBundy <jeff@labundy.com> wrote:

> Hi Jonathan,
> 
> I just wanted to give a heads up that I'm making a couple of very minor
> changes to the lot of IIO patches in this series in response to changes
> to include/linux/mfd/iqs62x.h for v5, namely:
> 
> - Replaced iqs62x->map with iqs62x->regmap
> - Dropped #defines for platform_driver name and alias in favor of the
>   actual string names (e.g. IQS620_DRV_NAME_TEMP --> "iqs620at-temp")
> 
> For small changes like these, I plan to retain your Reviewed-by trailer
> when I send out v5 even though the file would have changed slightly. If
> you would prefer I let you re-review first, please let me know.

I'm fine with you keeping it.  Thanks for checking though.

Jonathan
> 
> On Thu, Jan 16, 2020 at 08:36:08PM -0600, Jeff LaBundy wrote:
> > This patch adds support for the Azoteq IQS620AT temperature sensor,
> > capable of reporting its absolute die temperature.
> > 
> > Signed-off-by: Jeff LaBundy <jeff@labundy.com>
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > Changes in v4:
> >   - None
> > 
> > Changes in v3:
> >   - Added Reviewed-by trailer
> > 
> > Changes in v2:
> >   - Moved the driver from hwmon to iio
> >   - Merged 'Copyright' and 'Author' lines into one in introductory comments
> >   - Replaced 'error' with 'ret' throughout
> >   - Eliminated tabbed alignment of platform_driver struct members
> >   - Changed Kconfig "depends on" logic to MFD_IQS62X || COMPILE_TEST
> > 
> >  drivers/iio/temperature/Kconfig         | 10 ++++
> >  drivers/iio/temperature/Makefile        |  1 +
> >  drivers/iio/temperature/iqs620at-temp.c | 97 +++++++++++++++++++++++++++++++++
> >  3 files changed, 108 insertions(+)
> >  create mode 100644 drivers/iio/temperature/iqs620at-temp.c
> >   
> 
> Kind regards,
> Jeff LaBundy