From: Oleg Nesterov <oleg@redhat.com>
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Linux API <linux-api@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux Security Module <linux-security-module@vger.kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail.com>,
"Dmitry V . Levin" <ldv@altlinux.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
"J . Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>,
Jonathan Corbet <corbet@lwn.net>,
Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Solar Designer <solar@openwall.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v7 02/11] proc: add proc_fs_info struct to store proc information
Date: Tue, 28 Jan 2020 15:58:38 +0100 [thread overview]
Message-ID: <20200128145837.GD17943@redhat.com> (raw)
In-Reply-To: <20200128134337.GC17943@redhat.com>
On 01/28, Oleg Nesterov wrote:
>
> On 01/25, Alexey Gladkov wrote:
> >
> > static int proc_init_fs_context(struct fs_context *fc)
> > {
> > struct proc_fs_context *ctx;
> > + struct pid_namespace *pid_ns;
> >
> > ctx = kzalloc(sizeof(struct proc_fs_context), GFP_KERNEL);
> > if (!ctx)
> > return -ENOMEM;
> >
> > - ctx->pid_ns = get_pid_ns(task_active_pid_ns(current));
> > + pid_ns = get_pid_ns(task_active_pid_ns(current));
> > +
> > + if (!pid_ns->proc_mnt) {
> > + ctx->fs_info = kzalloc(sizeof(struct proc_fs_info), GFP_KERNEL);
> > + if (!ctx->fs_info) {
> > + kfree(ctx);
> > + return -ENOMEM;
> > + }
> > + ctx->fs_info->pid_ns = pid_ns;
> > + } else {
> > + ctx->fs_info = proc_sb_info(pid_ns->proc_mnt->mnt_sb);
> > + }
> > +
>
> it seems that this code lacks put_pid_ns() if pid_ns->proc_mnt != NULL
> or if kzalloc() fails?
OK, this is fixed in 6/11.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Linux API <linux-api@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux Security Module <linux-security-module@vger.kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail.com>,
"Dmitry V . Levin" <ldv@altlinux.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
"J . Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>
Subject: Re: [PATCH v7 02/11] proc: add proc_fs_info struct to store proc information
Date: Tue, 28 Jan 2020 15:58:38 +0100 [thread overview]
Message-ID: <20200128145837.GD17943@redhat.com> (raw)
In-Reply-To: <20200128134337.GC17943@redhat.com>
On 01/28, Oleg Nesterov wrote:
>
> On 01/25, Alexey Gladkov wrote:
> >
> > static int proc_init_fs_context(struct fs_context *fc)
> > {
> > struct proc_fs_context *ctx;
> > + struct pid_namespace *pid_ns;
> >
> > ctx = kzalloc(sizeof(struct proc_fs_context), GFP_KERNEL);
> > if (!ctx)
> > return -ENOMEM;
> >
> > - ctx->pid_ns = get_pid_ns(task_active_pid_ns(current));
> > + pid_ns = get_pid_ns(task_active_pid_ns(current));
> > +
> > + if (!pid_ns->proc_mnt) {
> > + ctx->fs_info = kzalloc(sizeof(struct proc_fs_info), GFP_KERNEL);
> > + if (!ctx->fs_info) {
> > + kfree(ctx);
> > + return -ENOMEM;
> > + }
> > + ctx->fs_info->pid_ns = pid_ns;
> > + } else {
> > + ctx->fs_info = proc_sb_info(pid_ns->proc_mnt->mnt_sb);
> > + }
> > +
>
> it seems that this code lacks put_pid_ns() if pid_ns->proc_mnt != NULL
> or if kzalloc() fails?
OK, this is fixed in 6/11.
Oleg.
next prev parent reply other threads:[~2020-01-28 14:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 13:05 [PATCH v7 00/11] proc: modernize proc to support multiple private instances Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 01/11] proc: Rename struct proc_fs_info to proc_fs_opts Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 02/11] proc: add proc_fs_info struct to store proc information Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-28 13:43 ` Oleg Nesterov
2020-01-28 13:43 ` Oleg Nesterov
2020-01-28 14:58 ` Oleg Nesterov [this message]
2020-01-28 14:58 ` Oleg Nesterov
2020-01-25 13:05 ` [PATCH v7 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 04/11] proc: move hide_pid, pid_gid from pid_namespace " Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 05/11] proc: add helpers to set and get proc hidepid and gid mount options Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 06/11] proc: support mounting procfs instances inside same pid namespace Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 07/11] proc: flush task dcache entries from all procfs instances Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 18:45 ` Linus Torvalds
2020-01-25 18:45 ` Linus Torvalds
2020-01-27 23:23 ` Alexey Gladkov
2020-01-27 23:23 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 08/11] proc: instantiate only pids that we can ptrace on 'hidepid=4' mount option Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 09/11] proc: add option to mount only a pids subset Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 10/11] docs: proc: add documentation for "hidepid=4" and "subset=pidfs" options and new mount behavior Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
2020-01-25 13:05 ` [PATCH v7 11/11] proc: Move hidepid values to uapi as they are user interface to mount Alexey Gladkov
2020-01-25 13:05 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128145837.GD17943@redhat.com \
--to=oleg@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=corbet@lwn.net \
--cc=danielmicay@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gladkov.alexey@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@poochiereds.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=solar@openwall.com \
--cc=tixxdz@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.