Re: [EXTERNAL] Re: [thud/zeus/master][PATCH] recipes-graphics: Add recipe for DevIL

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Jan 29, 2020 at 12:27:50PM -0500, Tammana, Gowtham wrote:
> 
> 
> >>recipe for DevIL
> >>
> >>On Wed, Jan 22, 2020 at 11:36:26AM -0600, Gowtham Tammana wrote:
> >>> Developers Image Library (DevIL) is a cross-platfor image utility
> >>> library with simple syntax (openil.sourceforge.net). Adding recipe to
> >>> build from sources.
> >>
> >>Where is it coming from? I see there are many copies in other layers - is it
> >>based on something or completely done from scratch?
> >
> >Do you mean the recipe, if so yes its done from scratch.
> >
> >>
> >>> index 00000000..6ba7f34b
> >>> --- /dev/null
> >>> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> >>> @@ -0,0 +1,30 @@
> >>> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image
> >>\
> >>> +               library utilizing simple syntax to load, save, convert, \
> >>> +               manipulate, filter and display a variety of images."
> >>
> >>Would also need a short SUMMARY set.
> >
> >Ok, let me add include that.
> >
> >>
> >>> +HOMEPAGE = "https://github.com/DentonW/DevIL"
> >>> +LICENSE = "LGPLv2"
> >>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
> >>> +
> >>> +SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
> >>> +           file://Remove-ILUT-dependency.patch"
> >>> +
> >>> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
> >>> +
> >>> +COMPATIBLE_MACHINE = "j7-evm"
> >>
> >>Is it really compatible with j7 only? Looks to me as rather generic...
> >
> >Yes, it is generic but haven't had chance to test on other platform. So
> >included for J7 for now.
> >
> >>
> >>> +
> >>> +PR = "r1"
> >>> +S = "${WORKDIR}/git"
> >>> +
> >>> +# Build only DevIL
> >>> +OECMAKE_SOURCEPATH = "${S}/DevIL"
> >>> +
> >>> +PACKAGECONFIG ??= "png"
> >>> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
> >>> +
> >>> +DEPENDS += "libpng"
> >>
> >>Dependency on libpng should be taken care by the PACKAGECONFIG above.
> >
> >I see, will remove it.
> >
> >>
> >>> +inherit pkgconfig cmake
> >>> +
> >>> +INSANE_SKIP_${PN} += "file-rdeps dev-so"
> >>> +FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
> >>> +FILES_SOLIBSDEV = ""
> >>
> >>Any way to package the libraries properly and not suppress QA checks?
> >
> >dev-so was needed, else it would complain on the symlinks. File-rdeps I

If it produces proper library libfoo.so.X.Y.Z with symlinks libfoo.so.X and 
libfoo.so, then just let the framework package everything automatically by 
removing FILES_*.


> >couldn't quite resolve without suppressing them.
> 
> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained in package devil requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS_devil? [file-rdeps]
> ERROR: devil-1.8.0-r2 do_package_qa: QA Issue: /usr/lib/libIL.so.1 contained in package devil requires libstdc++.so.6()(64bit), but no providers found in RDEPENDS_devil? [file-rdeps]
> 
> What does RDEPENDS_devil take the library target name or the recipe name.

DEPENDS is build-time dependency and takes recipe names.
RDEPENDS is run-time dependency and takes package names.

But libc and libstdc++ dependencies are normally taken care by the framework. 
The only exception when you would see such errors is when the library was 
built outside of the framework, i.e. consumed as a binary in the recipe, not 
built from sources.

-- 
Denys