[PATCH 0/2] Add support for EDT ETM043080DH6-GP

[PATCH 0/2] Add support for EDT ETM043080DH6-GP

[Marian-Cristian Rotariu]

This small patch-set adds support for EDT ETM043080DH6-GP. This is a
480x272 TFT Display with capacitive touchscreen and it is compatible with
simple panel driver.

We have tested it with our iWave-G22D Generic SODIMM Development Board.

Marian-Cristian Rotariu (2):
  dt-bindings: display: Add bindings for EDT panel
  drm/panel: simple: Add EDT panel support

 .../bindings/display/panel/edt,et-series.txt       |  3 ++
 drivers/gpu/drm/panel/panel-simple.c               | 33 ++++++++++++++++++++++
 2 files changed, 36 insertions(+)

-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] dt-bindings: display: Add bindings for EDT panel

[Marian-Cristian Rotariu]

Document the Emerging Display Technology Corp. (EDT) ETM043080DH6-GP
display, which is a 480x272 4.3" TFT display with capacitive touchscreen.

Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 Documentation/devicetree/bindings/display/panel/edt,et-series.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/edt,et-series.txt b/Documentation/devicetree/bindings/display/panel/edt,et-series.txt
index b7ac1c7..cedbbe6 100644
--- a/Documentation/devicetree/bindings/display/panel/edt,et-series.txt
+++ b/Documentation/devicetree/bindings/display/panel/edt,et-series.txt
@@ -22,6 +22,9 @@ simple-panel.txt
 +=================+=====================+=====================================+
 | ETM0430G0DH6    | edt,etm0430g0dh6    | 480x272 TFT Display                 |
 +-----------------+---------------------+-------------------------------------+
+| ETM043080DH6-GP | edt,etm043080dh6gp  | 480x272 TFT Display with capacitive |
+|                 |                     | Touchscreen                         |
++-----------------+---------------------+-------------------------------------+
 
 5,7" WVGA TFT Panels
 --------------------
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/panel: simple: Add EDT panel support

[Marian-Cristian Rotariu]

EDT ET043080DH6-GP is a 4.3" WQVGA 480x272 RGB LCD panel used on the iWave
Generic SODIMM Development Platform.

Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5d48768..aa64790 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1268,6 +1268,36 @@ static const struct panel_desc edt_et035012dm6 = {
 	.bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
 };
 
+static const struct drm_display_mode edt_etm043080dh6gp_mode = {
+	.clock = 10870,
+	.hdisplay = 480,
+	.hsync_start = 480 + 8,
+	.hsync_end = 480 + 8 + 4,
+	.htotal = 480 + 8 + 4 + 41,
+
+	/*
+	 * IWG22M: Y resolution changed for "dc_linuxfb" module crashing while
+	 * fb_align
+	 */
+
+	.vdisplay = 288,
+	.vsync_start = 288 + 2,
+	.vsync_end = 288 + 2 + 4,
+	.vtotal = 288 + 2 + 4 + 10,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc edt_etm043080dh6gp = {
+	.modes = &edt_etm043080dh6gp_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 100,
+		.height = 65,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};
+
 static const struct drm_display_mode edt_etm0430g0dh6_mode = {
 	.clock = 9000,
 	.hdisplay = 480,
@@ -3189,6 +3219,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "edt,et035012dm6",
 		.data = &edt_et035012dm6,
 	}, {
+		.compatible = "edt,etm043080dh6gp",
+		.data = &edt_etm043080dh6gp,
+	}, {
 		.compatible = "edt,etm0430g0dh6",
 		.data = &edt_etm0430g0dh6,
 	}, {
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] dt-bindings: display: Add bindings for EDT panel

[Sam Ravnborg]

Hi Marian-Cristian

On Wed, Jan 29, 2020 at 05:01:57PM +0000, Marian-Cristian Rotariu wrote:
> Document the Emerging Display Technology Corp. (EDT) ETM043080DH6-GP
> display, which is a 480x272 4.3" TFT display with capacitive touchscreen.
> 
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The compatibles for simple panels - like this - are all moved to a single file:

Documentation/devicetree/bindings/display/panel/panel-simple.yaml

And the file you patch here no logner exists.

Please redo your patch on top of drm-misc-next.

	Sam

> ---
>  Documentation/devicetree/bindings/display/panel/edt,et-series.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/edt,et-series.txt b/Documentation/devicetree/bindings/display/panel/edt,et-series.txt
> index b7ac1c7..cedbbe6 100644
> --- a/Documentation/devicetree/bindings/display/panel/edt,et-series.txt
> +++ b/Documentation/devicetree/bindings/display/panel/edt,et-series.txt
> @@ -22,6 +22,9 @@ simple-panel.txt
>  +=================+=====================+=====================================+
>  | ETM0430G0DH6    | edt,etm0430g0dh6    | 480x272 TFT Display                 |
>  +-----------------+---------------------+-------------------------------------+
> +| ETM043080DH6-GP | edt,etm043080dh6gp  | 480x272 TFT Display with capacitive |
> +|                 |                     | Touchscreen                         |
> ++-----------------+---------------------+-------------------------------------+
>  
>  5,7" WVGA TFT Panels
>  --------------------
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/panel: simple: Add EDT panel support

[Sam Ravnborg]

Hi Marian-Cristian

On Wed, Jan 29, 2020 at 05:01:58PM +0000, Marian-Cristian Rotariu wrote:
> EDT ET043080DH6-GP is a 4.3" WQVGA 480x272 RGB LCD panel used on the iWave
> Generic SODIMM Development Platform.
> 
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5d48768..aa64790 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1268,6 +1268,36 @@ static const struct panel_desc edt_et035012dm6 = {
>  	.bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
>  };
>  
> +static const struct drm_display_mode edt_etm043080dh6gp_mode = {
> +	.clock = 10870,
> +	.hdisplay = 480,
> +	.hsync_start = 480 + 8,
> +	.hsync_end = 480 + 8 + 4,
> +	.htotal = 480 + 8 + 4 + 41,
> +
> +	/*
> +	 * IWG22M: Y resolution changed for "dc_linuxfb" module crashing while
> +	 * fb_align
> +	 */
> +
> +	.vdisplay = 288,
> +	.vsync_start = 288 + 2,
> +	.vsync_end = 288 + 2 + 4,
> +	.vtotal = 288 + 2 + 4 + 10,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc edt_etm043080dh6gp = {
> +	.modes = &edt_etm043080dh6gp_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 100,
> +		.height = 65,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +};

As a minimum you must specify the connector_type too.
If you have the datesheet for the panel then please use
display_timings so you can specify min, typ, max timing.

	Sam


> +
>  static const struct drm_display_mode edt_etm0430g0dh6_mode = {
>  	.clock = 9000,
>  	.hdisplay = 480,
> @@ -3189,6 +3219,9 @@ static const struct of_device_id platform_of_match[] = {
>  		.compatible = "edt,et035012dm6",
>  		.data = &edt_et035012dm6,
>  	}, {
> +		.compatible = "edt,etm043080dh6gp",
> +		.data = &edt_etm043080dh6gp,
> +	}, {
>  		.compatible = "edt,etm0430g0dh6",
>  		.data = &edt_etm0430g0dh6,
>  	}, {
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/2] Add support for EDT ETM043080DH6-GP

[Sam Ravnborg]

Hi Marian-Cristian.

On Wed, Jan 29, 2020 at 05:01:56PM +0000, Marian-Cristian Rotariu wrote:
> This small patch-set adds support for EDT ETM043080DH6-GP. This is a
> 480x272 TFT Display with capacitive touchscreen and it is compatible with
> simple panel driver.
> 
> We have tested it with our iWave-G22D Generic SODIMM Development Board.
> 
> Marian-Cristian Rotariu (2):
>   dt-bindings: display: Add bindings for EDT panel
>   drm/panel: simple: Add EDT panel support

Thanks for your patches. I have commented on the individual patches.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel