All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
	Loic PALLARDY <loic.pallardy@st.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lkml@metux.net" <lkml@metux.net>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
	"fabio.estevam@nxp.com" <fabio.estevam@nxp.com>,
	"stefano.stabellini@xilinx.com" <stefano.stabellini@xilinx.com>,
	"system-dt@lists.openampproject.org"
	<system-dt@lists.openampproject.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/7] bus: Introduce firewall controller framework
Date: Fri, 31 Jan 2020 10:06:50 +0100	[thread overview]
Message-ID: <20200131090650.GA2267325@kroah.com> (raw)
In-Reply-To: <0b109c05-24cf-a1c4-6072-9af8a61f45b2@st.com>

On Fri, Jan 31, 2020 at 08:37:27AM +0000, Benjamin GAIGNARD wrote:
> 
> On 1/29/20 12:17 PM, Mark Brown wrote:
> > On Wed, Jan 29, 2020 at 10:52:40AM +0100, Greg KH wrote:
> >
> >> It just needs to be part of the bus logic for the specific bus that this
> >> "firewall" is on.  Just like we do the same thing for USB or thunderbolt
> >> devices.  Put this in the bus-specific code please.
> > I'd expect that this is going to affect at least platform and AMBA
> > buses.
> 
> Correct me if I'm wrong but creating a new type of bus would mean
> that all the drivers living on this bus must be changed to register 
> themselves on this bus ?

Yes.

> Or does a solution exist to let them live on the platform bus and call 
> firewalled bus before been probed ?

Why do people want to abuse the platform bus so much?  If a device is on
a bus that can have such a controller, then it is on a real bus, use it!

> All the impacted drivers could work on the existing bus with or without 
> the firewall so I don't want to break

break what?

> 
> that.

Odd line-break :)

Just register the driver on both busses, no big deal.

Stop abusing the platform bus code for things that it is not for.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"robh@kernel.org" <robh@kernel.org>,
	Loic PALLARDY <loic.pallardy@st.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"system-dt@lists.openampproject.org" 
	<system-dt@lists.openampproject.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lkml@metux.net" <lkml@metux.net>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
	"fabio.estevam@nxp.com" <fabio.estevam@nxp.com>,
	"stefano.stabellini@xilinx.com" <stefano.stabellini@xilinx.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/7] bus: Introduce firewall controller framework
Date: Fri, 31 Jan 2020 10:06:50 +0100	[thread overview]
Message-ID: <20200131090650.GA2267325@kroah.com> (raw)
In-Reply-To: <0b109c05-24cf-a1c4-6072-9af8a61f45b2@st.com>

On Fri, Jan 31, 2020 at 08:37:27AM +0000, Benjamin GAIGNARD wrote:
> 
> On 1/29/20 12:17 PM, Mark Brown wrote:
> > On Wed, Jan 29, 2020 at 10:52:40AM +0100, Greg KH wrote:
> >
> >> It just needs to be part of the bus logic for the specific bus that this
> >> "firewall" is on.  Just like we do the same thing for USB or thunderbolt
> >> devices.  Put this in the bus-specific code please.
> > I'd expect that this is going to affect at least platform and AMBA
> > buses.
> 
> Correct me if I'm wrong but creating a new type of bus would mean
> that all the drivers living on this bus must be changed to register 
> themselves on this bus ?

Yes.

> Or does a solution exist to let them live on the platform bus and call 
> firewalled bus before been probed ?

Why do people want to abuse the platform bus so much?  If a device is on
a bus that can have such a controller, then it is on a real bus, use it!

> All the impacted drivers could work on the existing bus with or without 
> the firewall so I don't want to break

break what?

> 
> that.

Odd line-break :)

Just register the driver on both busses, no big deal.

Stop abusing the platform bus code for things that it is not for.

thanks,

greg k-h

  reply	other threads:[~2020-01-31  9:07 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 15:37 [PATCH v2 0/7] Introduce bus firewall controller framework Benjamin Gaignard
2020-01-28 15:37 ` Benjamin Gaignard
2020-01-28 15:38 ` [PATCH v2 1/7] dt-bindings: bus: Add firewall bindings Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 15:38 ` [PATCH v2 2/7] bus: Introduce firewall controller framework Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 15:52   ` Greg KH
2020-01-28 15:52     ` Greg KH
2020-01-28 16:41     ` Benjamin GAIGNARD
2020-01-28 16:41       ` Benjamin GAIGNARD
2020-01-28 16:57       ` Greg KH
2020-01-28 16:57         ` Greg KH
2020-01-28 20:29         ` Benjamin GAIGNARD
2020-01-28 20:29           ` Benjamin GAIGNARD
2020-01-29  5:49           ` Greg KH
2020-01-29  5:49             ` Greg KH
2020-01-29  9:42           ` Linus Walleij
2020-01-29  9:42             ` Linus Walleij
2020-01-29  9:52             ` Greg KH
2020-01-29  9:52               ` Greg KH
2020-01-29 11:17               ` Mark Brown
2020-01-29 11:17                 ` Mark Brown
2020-01-31  8:37                 ` Benjamin GAIGNARD
2020-01-31  8:37                   ` Benjamin GAIGNARD
2020-01-31  9:06                   ` Greg KH [this message]
2020-01-31  9:06                     ` Greg KH
2020-02-14 16:05                     ` Linus Walleij
2020-02-14 16:05                       ` Linus Walleij
2020-02-14 21:40                       ` Greg KH
2020-02-14 21:40                         ` Greg KH
2020-02-15 12:41                         ` Benjamin GAIGNARD
2020-02-15 12:41                           ` Benjamin GAIGNARD
2020-02-16  7:21                           ` Greg KH
2020-02-16  7:21                             ` Greg KH
2020-01-28 15:38 ` [PATCH v2 3/7] base: Add calls to firewall controller Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 15:38 ` [PATCH v2 4/7] dt-bindings: bus: Add STM32 ETZPC " Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 15:38 ` [PATCH v2 5/7] bus: firewall: Add driver for STM32 ETZPC controller Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 15:38 ` [PATCH v2 6/7] ARM: dts: stm32: Add firewall node for stm32mp157 SoC Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 15:38 ` [PATCH v2 7/7] ARM: dts: stm32: enable firewall controller node on stm32mp157c-ed1 Benjamin Gaignard
2020-01-28 15:38   ` Benjamin Gaignard
2020-01-28 16:36 ` [PATCH v2 0/7] Introduce bus firewall controller framework Sudeep Holla
2020-01-28 16:36   ` Sudeep Holla
2020-01-28 16:46   ` Benjamin GAIGNARD
2020-01-28 16:46     ` Benjamin GAIGNARD
2020-01-28 17:17     ` Sudeep Holla
2020-01-28 17:17       ` Sudeep Holla
2020-01-28 20:06       ` Benjamin GAIGNARD
2020-01-28 20:06         ` Benjamin GAIGNARD
2020-01-28 22:06         ` Robin Murphy
2020-01-28 22:06           ` Robin Murphy
2020-01-29 13:40           ` Benjamin GAIGNARD
2020-01-29 13:40             ` Benjamin GAIGNARD
2020-01-31 18:25             ` Robin Murphy
2020-01-31 18:25               ` Robin Murphy
2020-02-03 13:16               ` Benjamin GAIGNARD
2020-02-03 13:16                 ` Benjamin GAIGNARD
2020-01-31 20:51             ` Florian Fainelli
2020-01-31 20:51               ` Florian Fainelli
2020-02-03 13:41               ` Benjamin GAIGNARD
2020-02-03 13:41                 ` Benjamin GAIGNARD
2020-01-31 20:48         ` Florian Fainelli
2020-01-31 20:48           ` Florian Fainelli
2020-02-02 12:23           ` Mark Brown
2020-02-02 12:23             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200131090650.GA2267325@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=benjamin.gaignard@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    --cc=loic.pallardy@st.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefano.stabellini@xilinx.com \
    --cc=sudeep.holla@arm.com \
    --cc=system-dt@lists.openampproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.