All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
Cc: noralf@tronnes.org, Sam Ravnborg <sam@ravnborg.org>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
Subject: Re: [PATCH v4 2/3] dt-bindings: add binding for tft displays based on ilitek,ili9486
Date: Fri, 31 Jan 2020 08:23:07 -0600	[thread overview]
Message-ID: <20200131142307.GA679@bogus> (raw)
In-Reply-To: <a37d95cbfc9603265ed15916cdd2fb69e8c5f041.1580134320.git.kamlesh.gurudasani@gmail.com>

On Mon, 27 Jan 2020 19:56:14 +0530, Kamlesh Gurudasani wrote:
> This binding is for the tft displays based on ilitek,ili9486.
> ozzmaker,piscreen and waveshare,rpi-lcd-35 are such displays
> 
> Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
> ---
> 
> v2 changes:
> * Changing file from txt to yaml format
> * removed ilitek,ili9486 from compatible string
> 
> v3 changes:
> * no changes
> 
> v4 changes:
> * no changes
> ---
>  .../bindings/display/ilitek,ili9486.yaml           | 79 ++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9486.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ilitek,ili9486.example.dt.yaml: display@0: compatible: ['waveshare,rpi-lcd-35'] is not valid under any of the given schemas (Possible causes of the failure):
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ilitek,ili9486.example.dt.yaml: display@0: compatible: ['waveshare,rpi-lcd-35'] is too short
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ilitek,ili9486.example.dt.yaml: display@0: compatible:0: 'waveshare,rpi-lcd-35' is not one of ['ozzmaker,piscreen']

See https://patchwork.ozlabs.org/patch/1229867
Please check and re-submit.

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
Cc: devicetree@vger.kernel.org,
	Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 2/3] dt-bindings: add binding for tft displays based on ilitek,ili9486
Date: Fri, 31 Jan 2020 08:23:07 -0600	[thread overview]
Message-ID: <20200131142307.GA679@bogus> (raw)
In-Reply-To: <a37d95cbfc9603265ed15916cdd2fb69e8c5f041.1580134320.git.kamlesh.gurudasani@gmail.com>

On Mon, 27 Jan 2020 19:56:14 +0530, Kamlesh Gurudasani wrote:
> This binding is for the tft displays based on ilitek,ili9486.
> ozzmaker,piscreen and waveshare,rpi-lcd-35 are such displays
> 
> Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
> ---
> 
> v2 changes:
> * Changing file from txt to yaml format
> * removed ilitek,ili9486 from compatible string
> 
> v3 changes:
> * no changes
> 
> v4 changes:
> * no changes
> ---
>  .../bindings/display/ilitek,ili9486.yaml           | 79 ++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9486.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ilitek,ili9486.example.dt.yaml: display@0: compatible: ['waveshare,rpi-lcd-35'] is not valid under any of the given schemas (Possible causes of the failure):
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ilitek,ili9486.example.dt.yaml: display@0: compatible: ['waveshare,rpi-lcd-35'] is too short
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ilitek,ili9486.example.dt.yaml: display@0: compatible:0: 'waveshare,rpi-lcd-35' is not one of ['ozzmaker,piscreen']

See https://patchwork.ozlabs.org/patch/1229867
Please check and re-submit.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-01-31 14:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 14:24 [PATCH v4 0/3] Support for tft displays based on ilitek,ili9486 Kamlesh Gurudasani
2020-01-27 14:24 ` Kamlesh Gurudasani
2020-01-27 14:25 ` [PATCH v4 1/3] dt-bindings: add vendor prefix for OzzMaker and Waveshare Electronics Kamlesh Gurudasani
2020-01-27 14:25   ` Kamlesh Gurudasani
2020-01-29 19:48   ` Sam Ravnborg
2020-01-29 19:48     ` Sam Ravnborg
2020-02-05 17:33   ` Rob Herring
2020-02-05 17:33     ` Rob Herring
2020-01-27 14:26 ` [PATCH v4 2/3] dt-bindings: add binding for tft displays based on ilitek,ili9486 Kamlesh Gurudasani
2020-01-27 14:26   ` [PATCH v4 2/3] dt-bindings: add binding for tft displays based on ilitek, ili9486 Kamlesh Gurudasani
2020-01-29 20:14   ` [PATCH v4 2/3] dt-bindings: add binding for tft displays based on ilitek,ili9486 Sam Ravnborg
2020-01-29 20:14     ` Sam Ravnborg
2020-01-31 14:23   ` Rob Herring [this message]
2020-01-31 14:23     ` Rob Herring
2020-01-27 14:26 ` [PATCH v4 3/3] drm/tinydrm: add support " Kamlesh Gurudasani
2020-01-27 14:26   ` [PATCH v4 3/3] drm/tinydrm: add support for tft displays based on ilitek, ili9486 Kamlesh Gurudasani
2020-01-27 15:13   ` [PATCH v4 3/3] drm/tinydrm: add support for tft displays based on ilitek,ili9486 Noralf Trønnes
2020-01-27 15:13     ` Noralf Trønnes
2020-01-29 20:15   ` Sam Ravnborg
2020-01-29 20:15     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200131142307.GA679@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kamlesh.gurudasani@gmail.com \
    --cc=noralf@tronnes.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.