All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: michael.srba@seznam.cz
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Mark Rutland <mark.rutland@arm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Michael Srba <Michael.Srba@seznam.cz>
Subject: Re: [PATCH v3 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01
Date: Fri, 31 Jan 2020 08:25:11 -0600	[thread overview]
Message-ID: <20200131142511.GA6222@bogus> (raw)
In-Reply-To: <20200130203555.316-1-michael.srba@seznam.cz>

On Thu, 30 Jan 2020 21:35:54 +0100, michael.srba@seznam.cz wrote:
> From: Michael Srba <Michael.Srba@seznam.cz>
> 
> This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes
> use of their S6E88A0 controller.
> 
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> ---
> Hi,
> I recall now that tabs cause a syntax error in yaml, should be easy to check 
> in checkpatch.pl?
> I hope there are no more embarassing oversights left.
> 
> Changes in v2: use yaml format for the binding
> Changes in v3: fix oversights too embarassing to admit here
> ---
>  .../panel/samsung,s6e88a0-ams452ef01.yaml     | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml: $id: 'http://devicetree.org/schemas/display/panel/samsung,s6e88a0-ams452ef01#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1231597
Please check and re-submit.

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: michael.srba@seznam.cz
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Michael Srba <Michael.Srba@seznam.cz>,
	Thierry Reding <thierry.reding@gmail.com>,
	~postmarketos/upstreaming@lists.sr.ht,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01
Date: Fri, 31 Jan 2020 08:25:11 -0600	[thread overview]
Message-ID: <20200131142511.GA6222@bogus> (raw)
In-Reply-To: <20200130203555.316-1-michael.srba@seznam.cz>

On Thu, 30 Jan 2020 21:35:54 +0100, michael.srba@seznam.cz wrote:
> From: Michael Srba <Michael.Srba@seznam.cz>
> 
> This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes
> use of their S6E88A0 controller.
> 
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> ---
> Hi,
> I recall now that tabs cause a syntax error in yaml, should be easy to check 
> in checkpatch.pl?
> I hope there are no more embarassing oversights left.
> 
> Changes in v2: use yaml format for the binding
> Changes in v3: fix oversights too embarassing to admit here
> ---
>  .../panel/samsung,s6e88a0-ams452ef01.yaml     | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml: $id: 'http://devicetree.org/schemas/display/panel/samsung,s6e88a0-ams452ef01#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1231597
Please check and re-submit.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-01-31 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 20:35 [PATCH v3 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01 michael.srba
2020-01-30 20:35 ` michael.srba
2020-01-30 20:35 ` [PATCH v3 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel michael.srba
2020-01-30 20:35   ` michael.srba
2020-01-30 21:21   ` Sam Ravnborg
2020-01-30 21:21     ` Sam Ravnborg
2020-01-30 21:19 ` [PATCH v3 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01 Sam Ravnborg
2020-01-30 21:19   ` Sam Ravnborg
2020-01-31 14:25 ` Rob Herring [this message]
2020-01-31 14:25   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200131142511.GA6222@bogus \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mark.rutland@arm.com \
    --cc=michael.srba@seznam.cz \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.