From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
devicetree@vger.kernel.org,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Maxime Ripard <mripard@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 3/3] dt-bindings: display: convert panel-dpi to DT schema
Date: Fri, 31 Jan 2020 20:41:30 +0100 [thread overview]
Message-ID: <20200131194130.GA26925@ravnborg.org> (raw)
In-Reply-To: <CAL_Jsq+JsEk1qz7NQc0ybO0xgmTB+YcmUL_d=u7_Y0A56v18nw@mail.gmail.com>
Hi Rob.
> > +
> > +properties:
> > + compatible:
> > + contains:
> > + const: panel-dpi
> > + description:
> > + Shall contain "panel-dpi" in addition to an optional panel-specific
> > + compatible string defined in individual panel bindings.
> > + "panel-dpi" can be used alone, thus no dedicated binding file
> > + is required for each and every panel.
>
> While this has occurred, I don't think the schema should allow it. I
> think a 'minItems: 2' should be added here.
>
> AFAIK, MIPI DPI just defines a spec for what already existed. Maybe it
> constrains things somewhat, but to the extent why we require a panel
> specific compatible in the first place? Doubtful...
You triggered me to re-read some old thread about this.
And I think I got it now.
Based on a proposal you made some weeks ago I did it like this:
properties:
compatible:
description:
Shall contain a panel specific compatible and "panel-dpi"
in that order.
items:
- {}
- const: panel-dpi
So no constraints on the panel specific compatible, expect that it is present.
And panel-dpi must be listed as the second compatible.
Updated the example too.
Will post a v3.
Thanks!
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: display: convert panel-dpi to DT schema
Date: Fri, 31 Jan 2020 20:41:30 +0100 [thread overview]
Message-ID: <20200131194130.GA26925@ravnborg.org> (raw)
In-Reply-To: <CAL_Jsq+JsEk1qz7NQc0ybO0xgmTB+YcmUL_d=u7_Y0A56v18nw@mail.gmail.com>
Hi Rob.
> > +
> > +properties:
> > + compatible:
> > + contains:
> > + const: panel-dpi
> > + description:
> > + Shall contain "panel-dpi" in addition to an optional panel-specific
> > + compatible string defined in individual panel bindings.
> > + "panel-dpi" can be used alone, thus no dedicated binding file
> > + is required for each and every panel.
>
> While this has occurred, I don't think the schema should allow it. I
> think a 'minItems: 2' should be added here.
>
> AFAIK, MIPI DPI just defines a spec for what already existed. Maybe it
> constrains things somewhat, but to the extent why we require a panel
> specific compatible in the first place? Doubtful...
You triggered me to re-read some old thread about this.
And I think I got it now.
Based on a proposal you made some weeks ago I did it like this:
properties:
compatible:
description:
Shall contain a panel specific compatible and "panel-dpi"
in that order.
items:
- {}
- const: panel-dpi
So no constraints on the panel specific compatible, expect that it is present.
And panel-dpi must be listed as the second compatible.
Updated the example too.
Will post a v3.
Thanks!
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-31 19:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 20:34 [PATCH v2 0/3] dt-bindings: convert timing + panel-dpi to DT schema Sam Ravnborg
2020-01-25 20:34 ` Sam Ravnborg
2020-01-25 20:34 ` [PATCH v2 1/3] dt-bindings: display: add panel-timing.yaml Sam Ravnborg
2020-01-25 20:34 ` Sam Ravnborg
2020-01-31 17:41 ` Rob Herring
2020-01-31 17:41 ` Rob Herring
2020-01-25 20:34 ` [PATCH v2 2/3] dt-bindings: display: convert display-timings to DT schema Sam Ravnborg
2020-01-25 20:34 ` Sam Ravnborg
2020-01-31 17:40 ` Rob Herring
2020-01-31 17:40 ` Rob Herring
2020-01-25 20:34 ` [PATCH v2 3/3] dt-bindings: display: convert panel-dpi " Sam Ravnborg
2020-01-25 20:34 ` Sam Ravnborg
2020-01-31 17:40 ` Rob Herring
2020-01-31 17:40 ` Rob Herring
2020-01-31 19:41 ` Sam Ravnborg [this message]
2020-01-31 19:41 ` Sam Ravnborg
2020-01-31 17:14 ` [PATCH v2 0/3] dt-bindings: convert timing + " Sam Ravnborg
2020-01-31 17:14 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131194130.GA26925@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mripard@kernel.org \
--cc=oleksandr.suvorov@toradex.com \
--cc=p.zabel@pengutronix.de \
--cc=peter.ujfalusi@ti.com \
--cc=robh@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.