From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/32s: Don't flush all TLBs when flushing one page
Date: Sat, 1 Feb 2020 10:17:37 -0600 [thread overview]
Message-ID: <20200201161737.GO22482@gate.crashing.org> (raw)
In-Reply-To: <96671e01-6206-8952-a498-942b42e98ef0@c-s.fr>
On Sat, Feb 01, 2020 at 03:53:12PM +0100, Christophe Leroy wrote:
> >>No, in end the low bits are set, that's a BIT OR with ~PAGE_MASK, so it
> >>sets all low bits to 1.
> >
> >Oh, wow, yes, I cannot read apparently.
> >
> >Maybe there are some ROUND_DOWN and ROUND_UP macros you could use?
>
> Yes but my intention was to modify the existing code as less as possible.
> What do you think about version v2 of the patch ?
It looked fine to me.
Add my
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
if you want.
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/32s: Don't flush all TLBs when flushing one page
Date: Sat, 1 Feb 2020 10:17:37 -0600 [thread overview]
Message-ID: <20200201161737.GO22482@gate.crashing.org> (raw)
In-Reply-To: <96671e01-6206-8952-a498-942b42e98ef0@c-s.fr>
On Sat, Feb 01, 2020 at 03:53:12PM +0100, Christophe Leroy wrote:
> >>No, in end the low bits are set, that's a BIT OR with ~PAGE_MASK, so it
> >>sets all low bits to 1.
> >
> >Oh, wow, yes, I cannot read apparently.
> >
> >Maybe there are some ROUND_DOWN and ROUND_UP macros you could use?
>
> Yes but my intention was to modify the existing code as less as possible.
> What do you think about version v2 of the patch ?
It looked fine to me.
Add my
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
if you want.
Segher
next prev parent reply other threads:[~2020-02-01 16:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 15:37 [PATCH] powerpc/32s: Don't flush all TLBs when flushing one page Christophe Leroy
2020-01-31 15:37 ` Christophe Leroy
2020-01-31 15:51 ` Segher Boessenkool
2020-01-31 15:51 ` Segher Boessenkool
2020-01-31 16:15 ` Christophe Leroy
2020-01-31 16:15 ` Christophe Leroy
2020-01-31 19:38 ` Segher Boessenkool
2020-01-31 19:38 ` Segher Boessenkool
2020-02-01 7:27 ` Christophe Leroy
2020-02-01 7:27 ` Christophe Leroy
2020-02-01 14:06 ` Segher Boessenkool
2020-02-01 14:06 ` Segher Boessenkool
2020-02-01 14:53 ` Christophe Leroy
2020-02-01 14:53 ` Christophe Leroy
2020-02-01 16:17 ` Segher Boessenkool [this message]
2020-02-01 16:17 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201161737.GO22482@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.