All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "zzzzPopa, zzzzStefan Serban" <StefanSerban.Popa@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"colin.king@canonical.com" <colin.king@canonical.com>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar
Date: Sun, 02 Feb 2020 15:53:04 +0000	[thread overview]
Message-ID: <20200202155304.5eb84ee8@archlinux> (raw)
In-Reply-To: <aae729269a5ab110fae379f88b72a8cbca6c8b13.camel@analog.com>

On Thu, 23 Jan 2020 12:16:03 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Thu, 2020-01-23 at 09:19 +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > There is a spelling mistake and grammar mistake in a dev_err
> > message. Fix it.
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>

This crossed with Joe observing there are quite a few other nice little bits
of janitorial work to be done in this driver. 

I merged the two together and fiddled the patch description to cover
the result.  Hope no one minds.  Seemed like it would save everyone
some time rather than asking for a v3.

Shout out if I've messed it up or you would rather I change the
various tags.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks all,

Jonathan

> > ---
> > V2: fix grammar too, thanks to Alexandru Ardelean for spotting this.
> > ---
> >  drivers/iio/dac/ad5755.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> > index b9175fb4c8ab..1359a1a92fdc 100644
> > --- a/drivers/iio/dac/ad5755.c
> > +++ b/drivers/iio/dac/ad5755.c
> > @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> > device *dev)
> >  	for_each_child_of_node(np, pp) {
> >  		if (devnr >= AD5755_NUM_CHANNELS) {
> >  			dev_err(dev,
> > -				"There is to many channels defined in DT\n");
> > +				"There are too many channels defined in DT\n");
> >  			goto error_out;
> >  		}
> >    

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "zzzzPopa, zzzzStefan Serban" <StefanSerban.Popa@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"colin.king@canonical.com" <colin.king@canonical.com>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar
Date: Sun, 2 Feb 2020 15:53:04 +0000	[thread overview]
Message-ID: <20200202155304.5eb84ee8@archlinux> (raw)
In-Reply-To: <aae729269a5ab110fae379f88b72a8cbca6c8b13.camel@analog.com>

On Thu, 23 Jan 2020 12:16:03 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Thu, 2020-01-23 at 09:19 +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > There is a spelling mistake and grammar mistake in a dev_err
> > message. Fix it.
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>

This crossed with Joe observing there are quite a few other nice little bits
of janitorial work to be done in this driver. 

I merged the two together and fiddled the patch description to cover
the result.  Hope no one minds.  Seemed like it would save everyone
some time rather than asking for a v3.

Shout out if I've messed it up or you would rather I change the
various tags.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks all,

Jonathan

> > ---
> > V2: fix grammar too, thanks to Alexandru Ardelean for spotting this.
> > ---
> >  drivers/iio/dac/ad5755.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> > index b9175fb4c8ab..1359a1a92fdc 100644
> > --- a/drivers/iio/dac/ad5755.c
> > +++ b/drivers/iio/dac/ad5755.c
> > @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> > device *dev)
> >  	for_each_child_of_node(np, pp) {
> >  		if (devnr >= AD5755_NUM_CHANNELS) {
> >  			dev_err(dev,
> > -				"There is to many channels defined in DT\n");
> > +				"There are too many channels defined in DT\n");
> >  			goto error_out;
> >  		}
> >    


  reply	other threads:[~2020-02-02 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23  9:19 [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar Colin King
2020-01-23 12:16 ` Ardelean, Alexandru
2020-01-23 12:16   ` Ardelean, Alexandru
2020-02-02 15:53   ` Jonathan Cameron [this message]
2020-02-02 15:53     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200202155304.5eb84ee8@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=StefanSerban.Popa@analog.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=colin.king@canonical.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.