From: Lee Jones <lee.jones@linaro.org>
To: Greg KH <greg@kroah.com>
Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] media: si470x-i2c: Move free() past last use of 'radio'
Date: Mon, 3 Feb 2020 15:12:08 +0000 [thread overview]
Message-ID: <20200203151208.GD15069@dell> (raw)
In-Reply-To: <20200203145831.GA3238182@kroah.com>
On Mon, 03 Feb 2020, Greg KH wrote:
> On Mon, Feb 03, 2020 at 02:32:45PM +0000, Greg KH wrote:
> > On Mon, Feb 03, 2020 at 01:21:30PM +0000, Lee Jones wrote:
> > > A pointer to 'struct si470x_device' is currently used after free:
> > >
> > > drivers/media/radio/si470x/radio-si470x-i2c.c:462:25-30: ERROR: reference
> > > preceded by free on line 460
> > >
> > > Shift the call to free() down past its final use.
> > >
> > > NB: Not sending to Mainline, since the problem does not exist there.
> >
> > It doesn't exist there because of a bad merge? What commit caused the
> > problem?
>
> Ah, found it, it was 2df200ab234a ("media: si470x-i2c: add missed
> operations in remove")
I was about to follow up with a v2:
"NB: Cauased during the backporting of upstream commit 2df200ab234a
("media: si470x-i2c: add missed operations in remove"). This issue does
not exist in Mainline since the kfree() was removed in v5.0 as part of
commit f86c51b66bf6 ("media: si470x-i2c: Use managed resource helpers")."
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] media: si470x-i2c: Move free() past last use of 'radio'
Date: Mon, 3 Feb 2020 15:12:08 +0000 [thread overview]
Message-ID: <20200203151208.GD15069@dell> (raw)
In-Reply-To: <20200203145831.GA3238182@kroah.com>
On Mon, 03 Feb 2020, Greg KH wrote:
> On Mon, Feb 03, 2020 at 02:32:45PM +0000, Greg KH wrote:
> > On Mon, Feb 03, 2020 at 01:21:30PM +0000, Lee Jones wrote:
> > > A pointer to 'struct si470x_device' is currently used after free:
> > >
> > > drivers/media/radio/si470x/radio-si470x-i2c.c:462:25-30: ERROR: reference
> > > preceded by free on line 460
> > >
> > > Shift the call to free() down past its final use.
> > >
> > > NB: Not sending to Mainline, since the problem does not exist there.
> >
> > It doesn't exist there because of a bad merge? What commit caused the
> > problem?
>
> Ah, found it, it was 2df200ab234a ("media: si470x-i2c: add missed
> operations in remove")
I was about to follow up with a v2:
"NB: Cauased during the backporting of upstream commit 2df200ab234a
("media: si470x-i2c: add missed operations in remove"). This issue does
not exist in Mainline since the kfree() was removed in v5.0 as part of
commit f86c51b66bf6 ("media: si470x-i2c: Use managed resource helpers")."
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-02-03 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 13:21 [PATCH 1/1] media: si470x-i2c: Move free() past last use of 'radio' Lee Jones
2020-02-03 13:21 ` Lee Jones
2020-02-03 14:32 ` Greg KH
2020-02-03 14:32 ` Greg KH
2020-02-03 14:58 ` Greg KH
2020-02-03 14:58 ` Greg KH
2020-02-03 15:12 ` Lee Jones [this message]
2020-02-03 15:12 ` Lee Jones
2020-02-03 15:01 ` Patch "media: si470x-i2c: Move free() past last use of 'radio'" has been added to the 4.4-stable tree gregkh
2020-02-03 15:01 ` Patch "media: si470x-i2c: Move free() past last use of 'radio'" has been added to the 4.9-stable tree gregkh
2020-02-03 15:01 ` Patch "media: si470x-i2c: Move free() past last use of 'radio'" has been added to the 4.14-stable tree gregkh
2020-02-03 15:02 ` Patch "media: si470x-i2c: Move free() past last use of 'radio'" has been added to the 4.19-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203151208.GD15069@dell \
--to=lee.jones@linaro.org \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.