All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Coe <bluemrp9@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 4/8] package/mariadb: fix potential error message in sysv startup script
Date: Mon,  3 Feb 2020 17:21:56 -0800	[thread overview]
Message-ID: <20200204012200.7273-4-bluemrp9@gmail.com> (raw)
In-Reply-To: <20200204012200.7273-1-bluemrp9@gmail.com>

In order to check if the initial database needs created, the startup
script calls ls -1 $MYSQL_LIB | wc -l to check the number of files in
the directory. If the directory does not exist, an error is printed.
We fix this by redirecting stderr to /dev/null for the ls call.

Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
---
Changes v2 -> v3:
  - separate changes into seperate patches (suggested by Thomas)
Changes v1 -> v2:
  - no change
---
 package/mariadb/S97mysqld | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/mariadb/S97mysqld b/package/mariadb/S97mysqld
index 62357fa8c4..7f9ced31e9 100644
--- a/package/mariadb/S97mysqld
+++ b/package/mariadb/S97mysqld
@@ -21,7 +21,9 @@ wait_for_ready() {
 }
 
 start() {
-	if [ `ls -1 $MYSQL_LIB | wc -l` = 0 ] ; then
+	# stderr is redirected to prevent a warning
+	# if mysql lib directory doesn't exist
+	if [ `ls -1 $MYSQL_LIB 2> /dev/null | wc -l` = 0 ] ; then
 		printf "Creating mysql system tables ... "
 		$MYSQL_BIN/mysql_install_db --basedir=/usr --user=mysql \
 			--datadir=$MYSQL_LIB > /dev/null 2>&1
-- 
2.25.0

  parent reply	other threads:[~2020-02-04  1:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04  1:21 [Buildroot] [PATCH v3 1/8] package/mariadb: fix permissions of data dir when using systemd Ryan Coe
2020-02-04  1:21 ` [Buildroot] [PATCH v3 2/8] package/mariadb: remove mariadb_config from target Ryan Coe
2020-02-04 13:38   ` Peter Korsgaard
2020-03-10 20:30   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 3/8] package/mariadb: add sysroot path to mariadb_config Ryan Coe
2020-02-04 13:45   ` Peter Korsgaard
2020-02-04  1:21 ` Ryan Coe [this message]
2020-02-04 13:48   ` [Buildroot] [PATCH v3 4/8] package/mariadb: fix potential error message in sysv startup script Peter Korsgaard
2020-03-10 20:30   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 5/8] package/mariadb: rename variable " Ryan Coe
2020-02-04 13:52   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 6/8] package/mariadb: explicitly define logging directory to mysqld Ryan Coe
2020-02-04 13:54   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 7/8] package/mariadb: do not pass --user=mysql to mysql_install_db Ryan Coe
2020-02-04 13:55   ` Peter Korsgaard
2020-02-04  1:22 ` [Buildroot] [PATCH v3 8/8] package/mariadb: security bump version to 10.4.12 Ryan Coe
2020-02-04 14:02   ` Peter Korsgaard
2020-02-04 13:38 ` [Buildroot] [PATCH v3 1/8] package/mariadb: fix permissions of data dir when using systemd Peter Korsgaard
2020-03-07 21:23 ` Peter Korsgaard
2020-03-08  8:39   ` Baruch Siach
2020-03-08  8:52     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204012200.7273-4-bluemrp9@gmail.com \
    --to=bluemrp9@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.