All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/8] package/mariadb: add sysroot path to mariadb_config
Date: Tue, 04 Feb 2020 14:45:02 +0100	[thread overview]
Message-ID: <87a75ylb4x.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200204012200.7273-3-bluemrp9@gmail.com> (Ryan Coe's message of "Mon, 3 Feb 2020 17:21:55 -0800")

>>>>> "Ryan" == Ryan Coe <bluemrp9@gmail.com> writes:

 > This patch adds @CMAKE_SYSROOT@ to mariadb_config.c.in. Without it,
 > mariadb_config incorrectly returns host paths for include paths and
 > library paths.

 > Reported-by: Alexey Lukyanchuk <skif@skif-web.ru>
 > Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
 > ---
 > Changes v2 -> v3:
 >   - remove extra slash between CMAKE_SYSROOT and CMAKE_INSTALL_PREFIX
 > Changes v1 -> v2:
 >   - no change
 > ---
 >  ...3-add-sysroot-path-to-mariadb_config.patch | 28 +++++++++++++++++++
 >  1 file changed, 28 insertions(+)
 >  create mode 100644 package/mariadb/0003-add-sysroot-path-to-mariadb_config.patch

 > diff --git a/package/mariadb/0003-add-sysroot-path-to-mariadb_config.patch b/package/mariadb/0003-add-sysroot-path-to-mariadb_config.patch
 > new file mode 100644
 > index 0000000000..a072b37e29
 > --- /dev/null
 > +++ b/package/mariadb/0003-add-sysroot-path-to-mariadb_config.patch
 > @@ -0,0 +1,28 @@
 > +From 7e1b6aafeb9fe6558da7506b304c0efb5ea82281 Mon Sep 17 00:00:00 2001
 > +From: Ryan Coe <bluemrp9@gmail.com>
 > +Date: Fri, 13 Dec 2019 17:13:26 -0800
 > +Subject: [PATCH 1/1] add sysroot path to mariadb_config

Please use git format-patch -N when creating patches as pointed out by
check-package:

package/mariadb/0003-add-sysroot-path-to-mariadb_config.patch:4: generate your patches with 'git format-patch -N'


It would be good with more sensible commit message (E.G. the toplevel
description).

What is the upstream status of this patch? Has it been submitted
upsteam?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2020-02-04 13:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04  1:21 [Buildroot] [PATCH v3 1/8] package/mariadb: fix permissions of data dir when using systemd Ryan Coe
2020-02-04  1:21 ` [Buildroot] [PATCH v3 2/8] package/mariadb: remove mariadb_config from target Ryan Coe
2020-02-04 13:38   ` Peter Korsgaard
2020-03-10 20:30   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 3/8] package/mariadb: add sysroot path to mariadb_config Ryan Coe
2020-02-04 13:45   ` Peter Korsgaard [this message]
2020-02-04  1:21 ` [Buildroot] [PATCH v3 4/8] package/mariadb: fix potential error message in sysv startup script Ryan Coe
2020-02-04 13:48   ` Peter Korsgaard
2020-03-10 20:30   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 5/8] package/mariadb: rename variable " Ryan Coe
2020-02-04 13:52   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 6/8] package/mariadb: explicitly define logging directory to mysqld Ryan Coe
2020-02-04 13:54   ` Peter Korsgaard
2020-02-04  1:21 ` [Buildroot] [PATCH v3 7/8] package/mariadb: do not pass --user=mysql to mysql_install_db Ryan Coe
2020-02-04 13:55   ` Peter Korsgaard
2020-02-04  1:22 ` [Buildroot] [PATCH v3 8/8] package/mariadb: security bump version to 10.4.12 Ryan Coe
2020-02-04 14:02   ` Peter Korsgaard
2020-02-04 13:38 ` [Buildroot] [PATCH v3 1/8] package/mariadb: fix permissions of data dir when using systemd Peter Korsgaard
2020-03-07 21:23 ` Peter Korsgaard
2020-03-08  8:39   ` Baruch Siach
2020-03-08  8:52     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a75ylb4x.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.