* [bug report] clk: ls1028a: Add clock driver for Display output interface
@ 2020-02-04 5:49 Dan Carpenter
2020-02-04 7:03 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-02-04 5:49 UTC (permalink / raw)
To: wen.he_1; +Cc: linux-clk
Hello Wen He,
This is a semi-automatic email about new static checker warnings.
The patch d37010a3c162: "clk: ls1028a: Add clock driver for Display
output interface" from Dec 13, 2019, leads to the following Smatch
complaint:
drivers/clk/clk-plldig.c:195 plldig_init()
warn: variable dereferenced before check 'parent' (see line 190)
drivers/clk/clk-plldig.c
189 struct clk_hw *parent = clk_hw_get_parent(hw);
190 unsigned long parent_rate = clk_hw_get_rate(parent);
^^^^^^
Dereferenced inside function.
191 unsigned long val;
192 unsigned long long lltmp;
193 unsigned int mfd, fracdiv = 0;
194
195 if (!parent)
^^^^^^^
Check too late.
196 return -EINVAL;
197
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-04 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-04 5:49 [bug report] clk: ls1028a: Add clock driver for Display output interface Dan Carpenter
2020-02-04 7:03 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.