From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/1] autotools: Move simple definitions out of m4/* to configure.ac
Date: Tue, 4 Feb 2020 14:21:52 +0100 [thread overview]
Message-ID: <20200204132152.GC16090@rei> (raw)
In-Reply-To: <20200130110753.20459-1-pvorel@suse.cz>
Hi!
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Tested
> https://travis-ci.org/pevik/ltp/builds/643803931
> NOTE: failure on Debian stable on s390x is due lack of space, reported,
> but nobody cares. We might disable s390x until fixed.
> https://travis-ci.community/t/no-space-left-on-device-for-system-z/5954/10
> + tested on old SLE11 (kernel 3.0, glibc 2.11).
>
> TODO
> on m4 files (in order to use simple declarations which allows to move them to configure.ac):
> * verify and delete if they're old enough (e.g. ltp-ptrace.m4 and ltp-taskstats.m4 reference 2008, kernel commit 016ae219 from v2.6.27; ltp-signalfd.m4)
> * move pkg-config (e.g. ltp-keyutils.m4, ltp-selinux.m4)
> * simplify and move checks to lapi (e.g. ltp-signalfd.m4)
> * AC_MSG_RESULT: simplify if possible
>
> Kind regards,
> Petr
>
> configure.ac | 92 +++++++++++++++++++------
> m4/ltp-acct.m4 | 7 --
> m4/ltp-fanotify.m4 | 8 ---
> m4/ltp-fts.m4 | 7 --
> m4/ltp-if_link.m4 | 6 --
> m4/ltp-ioctl.m4 | 7 --
> m4/ltp-iovec.m4 | 6 --
> m4/ltp-kcmp_type.m4 | 7 --
> m4/ltp-madvise.m4 | 11 ---
> m4/ltp-mkdtemp.m4 | 5 --
> m4/ltp-mmsghdr.m4 | 10 ---
> m4/ltp-modify_ldt.m4 | 13 ----
> m4/ltp-perf_event.m4 | 6 --
> m4/ltp-prctl.m4 | 11 ---
> m4/ltp-quota.m4 | 8 ---
> m4/ltp-rlimit64.m4 | 9 ---
> m4/ltp-signal.m4 | 18 -----
> m4/ltp-statx.m4 | 14 ----
> m4/ltp-termio.m4 | 6 --
> m4/ltp-timerfd.m4 | 7 --
> m4/ltp-tpacket-v3.m4 | 10 ---
> m4/ltp-uname.m4 | 8 ---
> m4/ltp-x_tables.m4 | 25 -------
> testcases/kernel/mem/ksm/ksm05.c | 2 +-
> testcases/kernel/mem/lib/mem.c | 6 +-
> testcases/kernel/syscalls/mmap/mmap10.c | 4 +-
> 26 files changed, 76 insertions(+), 237 deletions(-)
> delete mode 100644 m4/ltp-acct.m4
> delete mode 100644 m4/ltp-fanotify.m4
> delete mode 100644 m4/ltp-fts.m4
> delete mode 100644 m4/ltp-if_link.m4
> delete mode 100644 m4/ltp-ioctl.m4
> delete mode 100644 m4/ltp-iovec.m4
> delete mode 100644 m4/ltp-kcmp_type.m4
> delete mode 100644 m4/ltp-madvise.m4
> delete mode 100644 m4/ltp-mkdtemp.m4
> delete mode 100644 m4/ltp-mmsghdr.m4
> delete mode 100644 m4/ltp-modify_ldt.m4
> delete mode 100644 m4/ltp-perf_event.m4
> delete mode 100644 m4/ltp-prctl.m4
> delete mode 100644 m4/ltp-quota.m4
> delete mode 100644 m4/ltp-rlimit64.m4
> delete mode 100644 m4/ltp-signal.m4
> delete mode 100644 m4/ltp-statx.m4
> delete mode 100644 m4/ltp-termio.m4
> delete mode 100644 m4/ltp-timerfd.m4
> delete mode 100644 m4/ltp-tpacket-v3.m4
> delete mode 100644 m4/ltp-uname.m4
> delete mode 100644 m4/ltp-x_tables.m4
>
> diff --git a/configure.ac b/configure.ac
> index b860bdacc..1c9ef38eb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -32,13 +32,19 @@ AC_PROG_YACC
>
> AC_PREFIX_DEFAULT(/opt/ltp)
>
> +AC_CHECK_DECLS([IFLA_NET_NS_PID],,,[#include <linux/if_link.h>])
> +AC_CHECK_DECLS([MADV_MERGEABLE],,,[#include <sys/mman.h>])
> +AC_CHECK_DECLS([PR_CAPBSET_DROP, PR_CAPBSET_READ],,,[#include <sys/prctl.h>])
> +
> AC_CHECK_HEADERS([ \
> + asm/ldt.h \
> ifaddrs.h \
> keyutils.h \
> linux/can.h \
> linux/cgroupstats.h \
> linux/cryptouser.h \
> linux/dccp.h \
> + linux/fs.h \
> linux/genetlink.h \
> linux/if_alg.h \
> linux/if_packet.h \
> @@ -59,11 +65,14 @@ AC_CHECK_HEADERS([ \
> sys/inotify.h \
> sys/prctl.h \
> sys/shm.h \
> + sys/timerfd.h \
> sys/ustat.h \
> sys/utsname.h \
> sys/xattr.h \
> xfs/xqm.h \
> ])
> +AC_CHECK_HEADERS(fts.h, [have_fts=1])
> +AC_SUBST(HAVE_FTS_H, $have_fts)
How is that different from simple AC_CHECK_HEADERS() ?
Can't we just put the hader into the call above?
Other than this the changes looks fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-02-04 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 11:07 [LTP] [RFC PATCH 1/1] autotools: Move simple definitions out of m4/* to configure.ac Petr Vorel
2020-02-04 13:21 ` Cyril Hrubis [this message]
2020-02-04 14:19 ` Petr Vorel
2020-02-04 14:29 ` Petr Vorel
2020-02-04 15:44 ` Cyril Hrubis
2020-02-04 15:52 ` Petr Vorel
2020-02-04 14:23 ` Yang Xu
2020-02-04 15:57 ` Petr Vorel
2020-02-04 16:09 ` Cyril Hrubis
2020-02-05 2:30 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204132152.GC16090@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.