From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/1] autotools: Move simple definitions out of m4/* to configure.ac
Date: Tue, 4 Feb 2020 16:57:03 +0100 [thread overview]
Message-ID: <20200204155703.GA16838@dell5510> (raw)
In-Reply-To: <e6f7f611-7c2e-04cb-afd9-e11c4423dc3f@cn.fujitsu.com>
Hi Xu,
> > TODO
> > on m4 files (in order to use simple declarations which allows to move them to configure.ac):
> > * verify and delete if they're old enough (e.g. ltp-ptrace.m4 and ltp-taskstats.m4 reference 2008, kernel commit 016ae219 from v2.6.27; ltp-signalfd.m4)
> ltp-prctl.m4 for PR_CAPBSET_DROP and PR_CAPBSET_READ also can be removed
> because it introduced since 2.6.25(it is old enough).
OK, that might go next time.
> IMO, move all simple definitions to configure.ac will make this file mess
> likce old .gitnore file. I perfer to add function or header or macro but not
> include struct in configure.ac.
I think .gitignore files are different because it's content cannot be duplicated
when they're split, but m4/ repeated some checks.
+ we already started to move configuration into configure.ac before
(AC_CHECK_HEADERS and AC_CHECK_FUNCS).
IMHO it's easier to search/work with single file than in many files with very little
content.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-04 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 11:07 [LTP] [RFC PATCH 1/1] autotools: Move simple definitions out of m4/* to configure.ac Petr Vorel
2020-02-04 13:21 ` Cyril Hrubis
2020-02-04 14:19 ` Petr Vorel
2020-02-04 14:29 ` Petr Vorel
2020-02-04 15:44 ` Cyril Hrubis
2020-02-04 15:52 ` Petr Vorel
2020-02-04 14:23 ` Yang Xu
2020-02-04 15:57 ` Petr Vorel [this message]
2020-02-04 16:09 ` Cyril Hrubis
2020-02-05 2:30 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204155703.GA16838@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.