From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Steven Price <steven.price@arm.com>, Icecream95 <ixn@keemail.me>,
dri-devel@lists.freedesktop.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler
Date: Tue, 4 Feb 2020 09:37:32 -0500 [thread overview]
Message-ID: <20200204143732.GA4525@kevin> (raw)
In-Reply-To: <20200204143504.135388-2-boris.brezillon@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 1027 bytes --]
Patch 2 is `Reviewed-by: Alyssa Rosenzweig
<alyssa.rosenzweig@collabora.com>`
On Tue, Feb 04, 2020 at 03:35:04PM +0100, Boris Brezillon wrote:
> ->job_run() can return an ERR_PTR() if somethings fails. Let's
> propagate the error returned by panfrost_fence_create() instead of
> returning NULL.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index b0716e49eeca..242147b36d8e 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -349,7 +349,7 @@ static struct dma_fence *panfrost_job_run(struct drm_sched_job *sched_job)
>
> fence = panfrost_fence_create(pfdev, slot);
> if (IS_ERR(fence))
> - return NULL;
> + return fence;
>
> if (job->done_fence)
> dma_fence_put(job->done_fence);
> --
> 2.24.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-05 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 14:35 [PATCH 1/2] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv Boris Brezillon
2020-02-04 14:35 ` Boris Brezillon
2020-02-04 14:35 ` [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler Boris Brezillon
2020-02-04 14:37 ` Alyssa Rosenzweig [this message]
2020-02-05 13:47 ` Steven Price
2020-02-05 14:21 ` Boris Brezillon
2020-02-05 14:28 ` Steven Price
2020-02-04 14:47 ` [PATCH 1/2] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv Boris Brezillon
2020-02-04 14:47 ` Boris Brezillon
2020-02-05 13:39 ` Steven Price
2020-02-05 13:39 ` Steven Price
2020-02-05 14:01 ` Boris Brezillon
2020-02-05 14:01 ` Boris Brezillon
2020-02-05 14:08 ` Steven Price
2020-02-05 14:08 ` Steven Price
2020-02-05 15:45 ` Robin Murphy
2020-02-05 15:45 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204143732.GA4525@kevin \
--to=alyssa.rosenzweig@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ixn@keemail.me \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.