All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [linux-arm:cex7 97/97] drivers/net/phy/qsfp.c:653 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_curr_labels' 4 <= 4
Date: Wed, 05 Feb 2020 13:36:53 +0300	[thread overview]
Message-ID: <20200205103652.GA24804@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 4013 bytes --]

tree:   git://git.armlinux.org.uk/~rmk/linux-arm cex7
head:   2f8726526ed0fd189f8a945c06f8b9850777a5ca
commit: 2f8726526ed0fd189f8a945c06f8b9850777a5ca [97/97] net: add qsfp support                              [*experimental*]

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/phy/qsfp.c:653 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_curr_labels' 4 <= 4
drivers/net/phy/qsfp.c:659 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_power_labels' 8 <= 8
drivers/net/phy/qsfp.c:1229 qsfp_sm_mod_present() warn: curly braces intended?
drivers/net/phy/qsfp.c:1299 qsfp_sm_power_up() warn: impossible condition '(qsfp->module_power_class >= 8) => (0-1 >= 8)'

Old smatch warnings:
drivers/net/phy/qsfp.c:1097 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1097 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1100 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1100 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1103 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1103 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1106 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1106 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1109 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1109 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'

git remote add linux-arm git://git.armlinux.org.uk/~rmk/linux-arm
git remote update linux-arm
git checkout 2f8726526ed0fd189f8a945c06f8b9850777a5ca
vim +/qsfp_hwmon_curr_labels +653 drivers/net/phy/qsfp.c

2f8726526ed0fd Russell King 2019-10-04  644  
2f8726526ed0fd Russell King 2019-10-04  645  static int qsfp_hwmon_read_str(struct device *dev, enum hwmon_sensor_types type,
2f8726526ed0fd Russell King 2019-10-04  646  			       u32 attr, int channel, const char **str)
2f8726526ed0fd Russell King 2019-10-04  647  {
2f8726526ed0fd Russell King 2019-10-04  648  	switch (type) {
2f8726526ed0fd Russell King 2019-10-04  649  	case hwmon_curr:
2f8726526ed0fd Russell King 2019-10-04  650  		if (attr != hwmon_curr_label || channel < 0 ||
2f8726526ed0fd Russell King 2019-10-04  651  		    channel > ARRAY_SIZE(qsfp_hwmon_curr_labels))
                                                                    ^
Off by one

2f8726526ed0fd Russell King 2019-10-04  652  			break;
2f8726526ed0fd Russell King 2019-10-04 @653  		*str = qsfp_hwmon_curr_labels[channel];
2f8726526ed0fd Russell King 2019-10-04  654  		return 0;
2f8726526ed0fd Russell King 2019-10-04  655  	case hwmon_power:
2f8726526ed0fd Russell King 2019-10-04  656  		if (attr != hwmon_power_label || channel < 0 ||
2f8726526ed0fd Russell King 2019-10-04  657  		    channel > ARRAY_SIZE(qsfp_hwmon_power_labels))
                                                                    ^

2f8726526ed0fd Russell King 2019-10-04  658  			break;
2f8726526ed0fd Russell King 2019-10-04 @659  		*str = qsfp_hwmon_power_labels[channel];
2f8726526ed0fd Russell King 2019-10-04  660  		return 0;
2f8726526ed0fd Russell King 2019-10-04  661  	default:
2f8726526ed0fd Russell King 2019-10-04  662  		break;
2f8726526ed0fd Russell King 2019-10-04  663  	}
2f8726526ed0fd Russell King 2019-10-04  664  	return -EOPNOTSUPP;
2f8726526ed0fd Russell King 2019-10-04  665  }

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [linux-arm:cex7 97/97] drivers/net/phy/qsfp.c:653 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_curr_labels' 4 <= 4
Date: Wed, 05 Feb 2020 13:36:53 +0300	[thread overview]
Message-ID: <20200205103652.GA24804@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 4013 bytes --]

tree:   git://git.armlinux.org.uk/~rmk/linux-arm cex7
head:   2f8726526ed0fd189f8a945c06f8b9850777a5ca
commit: 2f8726526ed0fd189f8a945c06f8b9850777a5ca [97/97] net: add qsfp support                              [*experimental*]

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/phy/qsfp.c:653 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_curr_labels' 4 <= 4
drivers/net/phy/qsfp.c:659 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_power_labels' 8 <= 8
drivers/net/phy/qsfp.c:1229 qsfp_sm_mod_present() warn: curly braces intended?
drivers/net/phy/qsfp.c:1299 qsfp_sm_power_up() warn: impossible condition '(qsfp->module_power_class >= 8) => (0-1 >= 8)'

Old smatch warnings:
drivers/net/phy/qsfp.c:1097 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1097 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1100 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1100 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1103 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1103 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1106 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1106 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'
drivers/net/phy/qsfp.c:1109 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xc2'
drivers/net/phy/qsfp.c:1109 qsfp_sm_mod_print() warn: format string contains non-ascii character '\xb5'

git remote add linux-arm git://git.armlinux.org.uk/~rmk/linux-arm
git remote update linux-arm
git checkout 2f8726526ed0fd189f8a945c06f8b9850777a5ca
vim +/qsfp_hwmon_curr_labels +653 drivers/net/phy/qsfp.c

2f8726526ed0fd Russell King 2019-10-04  644  
2f8726526ed0fd Russell King 2019-10-04  645  static int qsfp_hwmon_read_str(struct device *dev, enum hwmon_sensor_types type,
2f8726526ed0fd Russell King 2019-10-04  646  			       u32 attr, int channel, const char **str)
2f8726526ed0fd Russell King 2019-10-04  647  {
2f8726526ed0fd Russell King 2019-10-04  648  	switch (type) {
2f8726526ed0fd Russell King 2019-10-04  649  	case hwmon_curr:
2f8726526ed0fd Russell King 2019-10-04  650  		if (attr != hwmon_curr_label || channel < 0 ||
2f8726526ed0fd Russell King 2019-10-04  651  		    channel > ARRAY_SIZE(qsfp_hwmon_curr_labels))
                                                                    ^
Off by one

2f8726526ed0fd Russell King 2019-10-04  652  			break;
2f8726526ed0fd Russell King 2019-10-04 @653  		*str = qsfp_hwmon_curr_labels[channel];
2f8726526ed0fd Russell King 2019-10-04  654  		return 0;
2f8726526ed0fd Russell King 2019-10-04  655  	case hwmon_power:
2f8726526ed0fd Russell King 2019-10-04  656  		if (attr != hwmon_power_label || channel < 0 ||
2f8726526ed0fd Russell King 2019-10-04  657  		    channel > ARRAY_SIZE(qsfp_hwmon_power_labels))
                                                                    ^

2f8726526ed0fd Russell King 2019-10-04  658  			break;
2f8726526ed0fd Russell King 2019-10-04 @659  		*str = qsfp_hwmon_power_labels[channel];
2f8726526ed0fd Russell King 2019-10-04  660  		return 0;
2f8726526ed0fd Russell King 2019-10-04  661  	default:
2f8726526ed0fd Russell King 2019-10-04  662  		break;
2f8726526ed0fd Russell King 2019-10-04  663  	}
2f8726526ed0fd Russell King 2019-10-04  664  	return -EOPNOTSUPP;
2f8726526ed0fd Russell King 2019-10-04  665  }

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

             reply	other threads:[~2020-02-05 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 10:36 Dan Carpenter [this message]
2020-02-05 10:36 ` [linux-arm:cex7 97/97] drivers/net/phy/qsfp.c:653 qsfp_hwmon_read_str() error: buffer overflow 'qsfp_hwmon_curr_labels' 4 <= 4 Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205103652.GA24804@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.