From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Liang Li <liang.z.li@intel.com>,
virtualization@lists.linux-foundation.org,
Tyler Sanderson <tysand@google.com>,
linux-mm@kvack.org, "Michael S. Tsirkin" <mst@redhat.com>,
David Rientjes <rientjes@google.com>,
Nadav Amit <namit@vmware.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Michal Hocko <mhocko@kernel.org>
Subject: [PATCH v1 0/3] virtio-balloon: Fixes + switch back to OOM handler
Date: Wed, 5 Feb 2020 17:33:59 +0100 [thread overview]
Message-ID: <20200205163402.42627-1-david@redhat.com> (raw)
Two fixes for issues I stumbled over while working on patch #3.
Switch back to the good ol' OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM
as the switch to the shrinker introduce some undesired side effects. Keep
the shrinker in place to handle VIRTIO_BALLOON_F_FREE_PAGE_HINT.
Lengthy discussion under [1].
I tested with QEMU and "deflate-on-oom=on". Works as expected. Did not
test the shrinker for VIRTIO_BALLOON_F_FREE_PAGE_HINT, as it is
hard to trigger (only when migrating a VM, and even then, it might not
trigger).
[1] https://www.spinics.net/lists/linux-virtualization/msg40863.html
David Hildenbrand (3):
virtio-balloon: Fix memory leak when unloading while hinting is in
progress
virtio_balloon: Fix memory leaks on errors in virtballoon_probe()
virtio-balloon: Switch back to OOM handler for
VIRTIO_BALLOON_F_DEFLATE_ON_OOM
drivers/virtio/virtio_balloon.c | 124 +++++++++++++++-----------------
1 file changed, 57 insertions(+), 67 deletions(-)
--
2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org,
David Hildenbrand <david@redhat.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
David Rientjes <rientjes@google.com>,
Jason Wang <jasowang@redhat.com>, Liang Li <liang.z.li@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Michal Hocko <mhocko@kernel.org>, Nadav Amit <namit@vmware.com>,
Tyler Sanderson <tysand@google.com>,
Wei Wang <wei.w.wang@intel.com>
Subject: [PATCH v1 0/3] virtio-balloon: Fixes + switch back to OOM handler
Date: Wed, 5 Feb 2020 17:33:59 +0100 [thread overview]
Message-ID: <20200205163402.42627-1-david@redhat.com> (raw)
Two fixes for issues I stumbled over while working on patch #3.
Switch back to the good ol' OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM
as the switch to the shrinker introduce some undesired side effects. Keep
the shrinker in place to handle VIRTIO_BALLOON_F_FREE_PAGE_HINT.
Lengthy discussion under [1].
I tested with QEMU and "deflate-on-oom=on". Works as expected. Did not
test the shrinker for VIRTIO_BALLOON_F_FREE_PAGE_HINT, as it is
hard to trigger (only when migrating a VM, and even then, it might not
trigger).
[1] https://www.spinics.net/lists/linux-virtualization/msg40863.html
David Hildenbrand (3):
virtio-balloon: Fix memory leak when unloading while hinting is in
progress
virtio_balloon: Fix memory leaks on errors in virtballoon_probe()
virtio-balloon: Switch back to OOM handler for
VIRTIO_BALLOON_F_DEFLATE_ON_OOM
drivers/virtio/virtio_balloon.c | 124 +++++++++++++++-----------------
1 file changed, 57 insertions(+), 67 deletions(-)
--
2.24.1
next reply other threads:[~2020-02-05 16:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:33 David Hildenbrand [this message]
2020-02-05 16:33 ` [PATCH v1 0/3] virtio-balloon: Fixes + switch back to OOM handler David Hildenbrand
2020-02-05 16:34 ` [PATCH v1 1/3] virtio-balloon: Fix memory leak when unloading while hinting is in progress David Hildenbrand
2020-02-06 8:36 ` Michael S. Tsirkin
2020-02-05 16:34 ` [PATCH v1 2/3] virtio_balloon: Fix memory leaks on errors in virtballoon_probe() David Hildenbrand
2020-02-06 8:36 ` Michael S. Tsirkin
2020-02-05 16:34 ` [PATCH v1 3/3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM David Hildenbrand
2020-02-05 22:37 ` Tyler Sanderson via Virtualization
2020-02-05 22:37 ` Tyler Sanderson
2020-02-05 22:52 ` David Hildenbrand
2020-02-05 22:52 ` David Hildenbrand
2020-02-05 23:06 ` Tyler Sanderson via Virtualization
2020-02-05 23:06 ` Tyler Sanderson
2020-02-06 7:40 ` Michael S. Tsirkin
2020-02-06 7:40 ` Michael S. Tsirkin
2020-02-06 8:42 ` David Hildenbrand
2020-02-06 8:57 ` Michael S. Tsirkin
2020-02-06 9:05 ` David Hildenbrand
2020-02-06 9:09 ` Michael S. Tsirkin
2020-02-06 8:57 ` Wang, Wei W
2020-02-06 9:11 ` Michael S. Tsirkin
2020-02-06 9:12 ` Michael S. Tsirkin
2020-02-06 9:21 ` David Hildenbrand
2020-02-14 9:51 ` David Hildenbrand
2020-02-14 13:31 ` Wang, Wei W
2020-02-16 9:47 ` Michael S. Tsirkin
2020-02-16 9:47 ` Michael S. Tsirkin
2020-02-21 3:29 ` Tyler Sanderson via Virtualization
2020-02-21 3:29 ` Tyler Sanderson
2020-03-08 4:47 ` Tyler Sanderson via Virtualization
2020-03-08 4:47 ` Tyler Sanderson
2020-03-09 9:03 ` David Hildenbrand
2020-03-09 10:14 ` Michael S. Tsirkin
2020-03-09 10:59 ` David Hildenbrand
2020-03-09 10:24 ` Michael S. Tsirkin
2020-02-14 14:06 ` Michal Hocko
2020-02-14 14:06 ` Michal Hocko
2020-02-14 14:18 ` David Hildenbrand
2020-02-14 20:48 ` Tyler Sanderson via Virtualization
2020-02-14 20:48 ` Tyler Sanderson
2020-02-14 21:17 ` David Hildenbrand
2020-02-14 21:17 ` David Hildenbrand
2020-02-16 9:46 ` Michael S. Tsirkin
2020-02-16 9:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205163402.42627-1-david@redhat.com \
--to=david@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=liang.z.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=rientjes@google.com \
--cc=tysand@google.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.