From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Silvan Murer <silvan.murer@gmail.com>,
linux-iio@vger.kernel.org,
Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 4/3] iio: dac: ltc2632: remove some unused defines
Date: Thu, 6 Feb 2020 10:29:15 +0000 [thread overview]
Message-ID: <20200206102915.2e32cb5e@archlinux> (raw)
In-Reply-To: <20200203203126.7003-1-u.kleine-koenig@pengutronix.de>
On Mon, 3 Feb 2020 21:31:26 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> These two defines are unused since the driver was introduced in commit
> 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs").
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
A bit of fuzz and the mysterious bit of this being patch 4 of 3 aside all good.
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ltc2632.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
> index 1e7ffa0f6071..7adc91056aa1 100644
> --- a/drivers/iio/dac/ltc2632.c
> +++ b/drivers/iio/dac/ltc2632.c
> @@ -12,9 +12,6 @@
> #include <linux/iio/iio.h>
> #include <linux/regulator/consumer.h>
>
> -#define LTC2632_ADDR_DAC0 0x0
> -#define LTC2632_ADDR_DAC1 0x1
> -
> #define LTC2632_CMD_WRITE_INPUT_N 0x0
> #define LTC2632_CMD_UPDATE_DAC_N 0x1
> #define LTC2632_CMD_WRITE_INPUT_N_UPDATE_ALL 0x2
next prev parent reply other threads:[~2020-02-06 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 13:15 [PATCH 1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support Uwe Kleine-König
2020-01-30 13:15 ` [PATCH 2/3] iio: dac: ltc2632: drop some duplicated data Uwe Kleine-König
2020-02-06 10:54 ` Jonathan Cameron
2020-01-30 13:15 ` [PATCH 3/3] iio: dac: ltc2632: add support for LTC2636 family Uwe Kleine-König
2020-02-02 9:54 ` Jonathan Cameron
2020-02-06 10:54 ` Jonathan Cameron
2020-02-02 9:52 ` [PATCH 1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support Jonathan Cameron
2020-02-06 10:42 ` Jonathan Cameron
2020-02-03 20:31 ` [PATCH 4/3] iio: dac: ltc2632: remove some unused defines Uwe Kleine-König
2020-02-06 10:29 ` Jonathan Cameron [this message]
2020-02-06 10:34 ` Uwe Kleine-König
2020-02-06 10:44 ` Jonathan Cameron
2020-02-25 9:32 ` Uwe Kleine-König
2020-03-07 11:17 ` Jonathan Cameron
2020-02-06 18:11 ` [PATCH 1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206102915.2e32cb5e@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.roussinbelanger@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=silvan.murer@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.