From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [android-goldfish:android-3.18 260/303] net/ipv4/tcp_input.c:875 tcp_verify_retransmit_hint() warn: if statement not indented
Date: Fri, 07 Feb 2020 06:33:50 +0300 [thread overview]
Message-ID: <20200207033350.GL24804@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: 00127200e529357755b80e4ccdd1e956a2014e0f
commit: aead6225458bac4a4cf6329bc8accf3c68863495 [260/303] tcp: fix marked lost packets not being retransmitted
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/ipv4/tcp_input.c:875 tcp_verify_retransmit_hint() warn: if statement not indented
Old smatch warnings:
include/linux/netdevice.h:3585 net_gso_ok() warn: should 'gso_type << 16' be a 64 bit type?
git remote add android-goldfish https://android.googlesource.com/kernel/goldfish
git remote update android-goldfish
git checkout aead6225458bac4a4cf6329bc8accf3c68863495
vim +875 net/ipv4/tcp_input.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 871
006f582c73f4eda Ilpo Järvinen 2008-09-20 872 /* This must be called before lost_out is incremented */
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 873 static void tcp_verify_retransmit_hint(struct tcp_sock *tp, struct sk_buff *skb)
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 874 {
aead6225458bac4 Pengcheng Yang 2020-01-14 @875 if (((tp->retransmit_skb_hint == NULL) && tp->retrans_out >= tp->lost_out) ||
aead6225458bac4 Pengcheng Yang 2020-01-14 876 (tp->retransmit_skb_hint &&
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 877 before(TCP_SKB_CB(skb)->seq,
aead6225458bac4 Pengcheng Yang 2020-01-14 878 TCP_SKB_CB(tp->retransmit_skb_hint)->seq)))
006f582c73f4eda Ilpo Järvinen 2008-09-20 879
What was this if statement supposed to do?
006f582c73f4eda Ilpo Järvinen 2008-09-20 880 if (!tp->lost_out ||
006f582c73f4eda Ilpo Järvinen 2008-09-20 881 after(TCP_SKB_CB(skb)->end_seq, tp->retransmit_high))
006f582c73f4eda Ilpo Järvinen 2008-09-20 882 tp->retransmit_high = TCP_SKB_CB(skb)->end_seq;
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 883 }
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 884
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [android-goldfish:android-3.18 260/303] net/ipv4/tcp_input.c:875 tcp_verify_retransmit_hint() warn: if statement not indented
Date: Fri, 07 Feb 2020 06:33:50 +0300 [thread overview]
Message-ID: <20200207033350.GL24804@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: 00127200e529357755b80e4ccdd1e956a2014e0f
commit: aead6225458bac4a4cf6329bc8accf3c68863495 [260/303] tcp: fix marked lost packets not being retransmitted
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/ipv4/tcp_input.c:875 tcp_verify_retransmit_hint() warn: if statement not indented
Old smatch warnings:
include/linux/netdevice.h:3585 net_gso_ok() warn: should 'gso_type << 16' be a 64 bit type?
git remote add android-goldfish https://android.googlesource.com/kernel/goldfish
git remote update android-goldfish
git checkout aead6225458bac4a4cf6329bc8accf3c68863495
vim +875 net/ipv4/tcp_input.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 871
006f582c73f4eda Ilpo Järvinen 2008-09-20 872 /* This must be called before lost_out is incremented */
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 873 static void tcp_verify_retransmit_hint(struct tcp_sock *tp, struct sk_buff *skb)
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 874 {
aead6225458bac4 Pengcheng Yang 2020-01-14 @875 if (((tp->retransmit_skb_hint == NULL) && tp->retrans_out >= tp->lost_out) ||
aead6225458bac4 Pengcheng Yang 2020-01-14 876 (tp->retransmit_skb_hint &&
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 877 before(TCP_SKB_CB(skb)->seq,
aead6225458bac4 Pengcheng Yang 2020-01-14 878 TCP_SKB_CB(tp->retransmit_skb_hint)->seq)))
006f582c73f4eda Ilpo Järvinen 2008-09-20 879
What was this if statement supposed to do?
006f582c73f4eda Ilpo Järvinen 2008-09-20 880 if (!tp->lost_out ||
006f582c73f4eda Ilpo Järvinen 2008-09-20 881 after(TCP_SKB_CB(skb)->end_seq, tp->retransmit_high))
006f582c73f4eda Ilpo Järvinen 2008-09-20 882 tp->retransmit_high = TCP_SKB_CB(skb)->end_seq;
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 883 }
c8c213f20ce97c6 Ilpo Järvinen 2008-09-20 884
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2020-02-07 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 3:33 Dan Carpenter [this message]
2020-02-07 3:33 ` [android-goldfish:android-3.18 260/303] net/ipv4/tcp_input.c:875 tcp_verify_retransmit_hint() warn: if statement not indented Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207033350.GL24804@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.