From: Krishnamraju Eraparaju <krishna2@chelsio.com>
To: jgg@ziepe.ca, dledford@redhat.com, bmt@zurich.ibm.com
Cc: linux-rdma@vger.kernel.org, bharat@chelsio.com,
nirranjan@chelsio.com, krishna2@chelsio.com
Subject: [PATCH for-review/for-rc/for-rc] RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready()
Date: Fri, 7 Feb 2020 17:22:09 +0530 [thread overview]
Message-ID: <20200207115209.25933-1-krishna2@chelsio.com> (raw)
Warnings like below can fill up the dmesg while disconnecting RDMA
connections.
Hence, removing the unwanted WARN_ON.
[72103.557612] WARNING: CPU: 6 PID: 0 at
drivers/infiniband/sw/siw/siw_cm.c:1229 siw_cm_llp_data_ready+0xc1/0xd0
[siw]
[72103.557677] RIP: 0010:siw_cm_llp_data_ready+0xc1/0xd0 [siw]
[72103.557693] Call Trace:
[72103.557711] tcp_data_queue+0x226/0xb40
[72103.557714] tcp_rcv_established+0x220/0x620
[72103.557720] tcp_v4_do_rcv+0x12a/0x1e0
[72103.557722] tcp_v4_rcv+0xb05/0xc00
[72103.557728] ip_local_deliver_finish+0x69/0x210
[72103.557730] ip_local_deliver+0x6b/0xe0
[72103.557735] ip_rcv+0x273/0x362
[72103.557740] __netif_receive_skb_core+0xb35/0xc30
[72103.557752] netif_receive_skb_internal+0x3d/0xb0
[72103.557754] napi_gro_frags+0x13b/0x200
[72103.557788] t4_ethrx_handler+0x433/0x7d0 [cxgb4]
[72103.557800] process_responses+0x318/0x580 [cxgb4]
[72103.557820] napi_rx_handler+0x14/0x100 [cxgb4]
[72103.557822] net_rx_action+0x149/0x3b0
[72103.557826] __do_softirq+0xe3/0x30a
[72103.557831] irq_exit+0x100/0x110
[72103.557834] do_IRQ+0x7f/0xe0
[72103.557837] common_interrupt+0xf/0xf
Signed-off-by: Krishnamraju Eraparaju <krishna2@chelsio.com>
---
drivers/infiniband/sw/siw/siw_cm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/sw/siw/siw_cm.c b/drivers/infiniband/sw/siw/siw_cm.c
index 3bccfef40e7e..bcbc54998ace 100644
--- a/drivers/infiniband/sw/siw/siw_cm.c
+++ b/drivers/infiniband/sw/siw/siw_cm.c
@@ -1226,7 +1226,6 @@ static void siw_cm_llp_data_ready(struct sock *sk)
cep = sk_to_cep(sk);
if (!cep) {
- WARN_ON(1);
goto out;
}
siw_dbg_cep(cep, "state: %d\n", cep->state);
--
2.23.0.rc0
next reply other threads:[~2020-02-07 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 11:52 Krishnamraju Eraparaju [this message]
2020-02-07 13:22 ` [PATCH for-review/for-rc/for-rc] RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready() Krishnamraju Eraparaju
2020-02-07 14:18 ` Jason Gunthorpe
2020-02-07 15:07 ` Bernard Metzler
2020-02-10 18:00 ` Krishnamraju Eraparaju
2020-02-11 15:18 ` Bernard Metzler
2020-02-11 18:14 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207115209.25933-1-krishna2@chelsio.com \
--to=krishna2@chelsio.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.