All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@mellanox.com>
To: Krishnamraju Eraparaju <krishna2@chelsio.com>
Cc: dledford@redhat.com, bmt@zurich.ibm.com,
	linux-rdma@vger.kernel.org, bharat@chelsio.com,
	nirranjan@chelsio.com
Subject: Re: [PATCH for-review/for-rc/for-rc] RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready()
Date: Fri, 7 Feb 2020 10:18:20 -0400	[thread overview]
Message-ID: <20200207141820.GF4509@mellanox.com> (raw)
In-Reply-To: <20200207115209.25933-1-krishna2@chelsio.com>

On Fri, Feb 07, 2020 at 05:22:09PM +0530, Krishnamraju Eraparaju wrote:
> Warnings like below can fill up the dmesg while disconnecting RDMA
> connections.
> Hence, removing the unwanted WARN_ON.

Please explain why it the code is correct to take this error
path. Bernard clearly thought this shouldn't be happening

Jason

  parent reply	other threads:[~2020-02-07 14:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 11:52 [PATCH for-review/for-rc/for-rc] RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready() Krishnamraju Eraparaju
2020-02-07 13:22 ` Krishnamraju Eraparaju
2020-02-07 14:18 ` Jason Gunthorpe [this message]
2020-02-07 15:07   ` Bernard Metzler
2020-02-10 18:00   ` Krishnamraju Eraparaju
2020-02-11 15:18     ` Bernard Metzler
2020-02-11 18:14     ` Bernard Metzler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207141820.GF4509@mellanox.com \
    --to=jgg@mellanox.com \
    --cc=bharat@chelsio.com \
    --cc=bmt@zurich.ibm.com \
    --cc=dledford@redhat.com \
    --cc=krishna2@chelsio.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.