Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Kevin Wolf <kwolf@redhat.com>]

Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
> > List this file in the proper section, so maintainers get
> > notified when it is modified.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Max Reitz <mreitz@redhat.com>
> > Cc: qemu-block@nongnu.org
> > ---
> >  MAINTAINERS | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 903831e0a4..e269e9092c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1842,6 +1842,8 @@ S: Supported
>    Block layer core
>    M: Kevin Wolf <kwolf@redhat.com>
>    M: Max Reitz <mreitz@redhat.com>
>    L: qemu-block@nongnu.org
>    S: Supported
> >  F: block*
> >  F: block/
> >  F: hw/block/
> > +F: qapi/block.json
> > +F: qapi/block-core.json
> >  F: include/block/
> >  F: qemu-img*
> >  F: docs/interop/qemu-img.rst
> 
> This is in addition to
> 
>     Block QAPI, monitor, command line
>     M: Markus Armbruster <armbru@redhat.com>
>     S: Supported
>     F: blockdev.c
>     F: block/qapi.c
>     F: qapi/block*.json
>     F: qapi/transaction.json
>     T: git https://repo.or.cz/qemu/armbru.git block-next
> 
> I'm not sure this section makes much sense anymore.

This is probably for you to decide.

Though the block-next branch from the T: line doesn't even exist any
more...

> Should qapi/transaction.json also be added to "Block layer core"?  Or
> should it go into John's section "Block Jobs"?

I think at the moment it only supports actions that are more related to
block jobs, so moving it there would make sense to me.

Kevin