From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 0/3] Add support for suspend clk for Exynos5422 SoC
Date: Mon, 10 Feb 2020 14:56:12 +0100 [thread overview]
Message-ID: <20200210135612.GB2163@pi3> (raw)
In-Reply-To: <20200210105108.1128-1-linux.amoon@gmail.com>
On Mon, Feb 10, 2020 at 10:51:05AM +0000, Anand Moon wrote:
> Long time ago I tried to add suspend clk for dwc3 phy
> which was wrong appoch, see below.
>
> [0] https://lore.kernel.org/patchwork/patch/837635/
> [1] https://lore.kernel.org/patchwork/patch/837636/
>
You ignored parts of my review from these previous patches. I asked for
describing WHY are you doing this and WHAT problem are you trying to
solve. I asked for this multiple times. Unfortunately I cannot find the
answers to my questions in this patchset...
Best regards,
Krzysztof
> This patch series tries to enable suspend clk using
> exynos dwc3 driver, for this I have added new
> compatible string "samsung,exynos5420-dwusb3"
> so that we could add new suspend clk in addition
> to the core clk. exynos dwc3 driver will help
> enable/disable these clk.
>
> -Anand
>
> Anand Moon (3):
> devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3
> clocks support
> ARM: dts: exynos: Add missing usbdrd3 suspend clk
> usb: dwc3: exynos: Add support for Exynos5422 suspend clk
>
> Documentation/devicetree/bindings/usb/exynos-usb.txt | 4 +++-
> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++----
> arch/arm/boot/dts/exynos54xx.dtsi | 4 ++--
> drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
> 4 files changed, 18 insertions(+), 7 deletions(-)
>
> --
> 2.25.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCHv3 0/3] Add support for suspend clk for Exynos5422 SoC
Date: Mon, 10 Feb 2020 14:56:12 +0100 [thread overview]
Message-ID: <20200210135612.GB2163@pi3> (raw)
In-Reply-To: <20200210105108.1128-1-linux.amoon@gmail.com>
On Mon, Feb 10, 2020 at 10:51:05AM +0000, Anand Moon wrote:
> Long time ago I tried to add suspend clk for dwc3 phy
> which was wrong appoch, see below.
>
> [0] https://lore.kernel.org/patchwork/patch/837635/
> [1] https://lore.kernel.org/patchwork/patch/837636/
>
You ignored parts of my review from these previous patches. I asked for
describing WHY are you doing this and WHAT problem are you trying to
solve. I asked for this multiple times. Unfortunately I cannot find the
answers to my questions in this patchset...
Best regards,
Krzysztof
> This patch series tries to enable suspend clk using
> exynos dwc3 driver, for this I have added new
> compatible string "samsung,exynos5420-dwusb3"
> so that we could add new suspend clk in addition
> to the core clk. exynos dwc3 driver will help
> enable/disable these clk.
>
> -Anand
>
> Anand Moon (3):
> devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3
> clocks support
> ARM: dts: exynos: Add missing usbdrd3 suspend clk
> usb: dwc3: exynos: Add support for Exynos5422 suspend clk
>
> Documentation/devicetree/bindings/usb/exynos-usb.txt | 4 +++-
> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++----
> arch/arm/boot/dts/exynos54xx.dtsi | 4 ++--
> drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
> 4 files changed, 18 insertions(+), 7 deletions(-)
>
> --
> 2.25.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-10 13:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:51 [PATCHv3 0/3] Add support for suspend clk for Exynos5422 SoC Anand Moon
2020-02-10 10:51 ` Anand Moon
2020-02-10 10:51 ` [PATCHv3 1/3] devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3 clocks support Anand Moon
2020-02-10 10:51 ` Anand Moon
2020-02-10 10:51 ` [PATCHv3 2/3] ARM: dts: exynos: Add missing usbdrd3 suspend clk Anand Moon
2020-02-10 10:51 ` Anand Moon
2020-02-10 13:50 ` Krzysztof Kozlowski
2020-02-10 13:50 ` Krzysztof Kozlowski
2020-02-10 17:13 ` Anand Moon
2020-02-10 17:13 ` Anand Moon
2020-02-10 18:54 ` Krzysztof Kozlowski
2020-02-10 18:54 ` Krzysztof Kozlowski
2020-02-10 10:51 ` [PATCHv3 3/3] usb: dwc3: exynos: Add support for Exynos5422 " Anand Moon
2020-02-10 10:51 ` Anand Moon
2020-02-10 10:56 ` [PATCHv3 0/3] Add support for suspend clk for Exynos5422 SoC Anand Moon
2020-02-10 10:56 ` Anand Moon
2020-02-10 13:56 ` Krzysztof Kozlowski [this message]
2020-02-10 13:56 ` Krzysztof Kozlowski
2020-02-10 17:08 ` Anand Moon
2020-02-10 17:08 ` Anand Moon
2020-02-10 19:02 ` Krzysztof Kozlowski
2020-02-10 19:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210135612.GB2163@pi3 \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.