* [Buildroot] [EXT] Re: [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options
@ 2020-02-10 14:30 Gervais, Francois
2020-02-10 14:42 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Gervais, Francois @ 2020-02-10 14:30 UTC (permalink / raw)
To: buildroot
> > two new options for arm-trusted-firmware:
> > 1. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS
> >?????? - for additional targets, E.G. "pbl".
>
> This option was already added in commit
> 05b8c7da6de863561d66717735a4870f2766454c, which is part of Buildroot
> master.
Somebody reported a problem with my patch last week. I'm still investigating with
him but it seems that the qstrip wrapping might be required which
05b8c7da6de863561d66717735a4870f2766454c is missing.
Jerry maybe you can try on your side? You could rebase your v5 on top
of master and try to build arm-trusted-firmware from scratch with
BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS empty.
You might see this error message:
make: *** empty string invalid as file name. Stop.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v4 1/9] package/nxp: new package directory
@ 2020-02-05 10:52 Changming Huang
2020-02-05 10:52 ` [Buildroot] [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options Changming Huang
0 siblings, 1 reply; 3+ messages in thread
From: Changming Huang @ 2020-02-05 10:52 UTC (permalink / raw)
To: buildroot
The "nxp" directory is intended to contain all NXP
QorIQ (including PowerPC and LayerScape serial) related packages,
together with their download site and version info.
Signed-off-by: Changming Huang <jerry.huang@nxp.com>
---
changes since v3:
no changes.
changes since v2:
1. change the sub-direcotry to "nxp".
2. add helper.mk macro to extract compressed file.
changes since v1:
no changes.
---
package/Config.in | 1 +
package/nxp/Config.in | 4 ++++
package/nxp/helper.mk | 32 ++++++++++++++++++++++++++++++++
3 files changed, 37 insertions(+)
create mode 100644 package/nxp/Config.in
create mode 100644 package/nxp/helper.mk
diff --git a/package/Config.in b/package/Config.in
index 37861387e8..c697962ac0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -494,6 +494,7 @@ endmenu
source "package/nvidia-driver/Config.in"
source "package/nvidia-tegra23/Config.in"
source "package/nvme/Config.in"
+ source "package/nxp/Config.in"
source "package/ofono/Config.in"
source "package/on2-8170-modules/Config.in"
source "package/open2300/Config.in"
diff --git a/package/nxp/Config.in b/package/nxp/Config.in
new file mode 100644
index 0000000000..575542c7ab
--- /dev/null
+++ b/package/nxp/Config.in
@@ -0,0 +1,4 @@
+menu "NXP QorIQ libraries"
+ depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc
+
+endmenu
diff --git a/package/nxp/helper.mk b/package/nxp/helper.mk
new file mode 100644
index 0000000000..79e4236249
--- /dev/null
+++ b/package/nxp/helper.mk
@@ -0,0 +1,32 @@
+################################################################################
+#
+# helper
+#
+################################################################################
+
+# Helper for self-extracting binaries distributed by NXP.
+#
+# The --force option makes sure it doesn't fail if the source
+# directory already exists. The --auto-accept skips the license check,
+# as it is not needed in Buildroot because we have legal-info. Since
+# there's a EULA in the binary file, we extract it in this macro, and
+# it should therefore be added to the LICENSE_FILES variable of
+# packages using this macro. Also, remember to set REDISTRIBUTE to
+# "NO". Indeed, this is a legal minefield: the EULA specifies that the
+# Board Support Package includes software and hardware (sic!) for
+# which a separate license is needed...
+#
+# $(1): full path to the archive file
+#
+define NXP_EXTRACT_HELPER
+ awk 'BEGIN { start = 0; } \
+ /^EOEULA/ { start = 0; } \
+ { if (start) print; } \
+ /<<EOEULA/ { start = 1; }' \
+ $(1) > $(@D)/EULA
+ cd $(@D) && sh $(1) --force --auto-accept
+ find $(@D)/$(basename $(notdir $(1))) -mindepth 1 -maxdepth 1 -exec mv {} $(@D) \;
+ rmdir $(@D)/$(basename $(notdir $(1)))
+endef
+
+include $(sort $(wildcard package/nxp/*/*.mk))
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options
2020-02-05 10:52 [Buildroot] [PATCH v4 1/9] package/nxp: new package directory Changming Huang
@ 2020-02-05 10:52 ` Changming Huang
2020-02-05 12:29 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Changming Huang @ 2020-02-05 10:52 UTC (permalink / raw)
To: buildroot
two new options for arm-trusted-firmware:
1. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS
- for additional targets, E.G. "pbl".
2. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_DEPENDENCIES
- for additional dependencies, E.G. "host-qoriq-rcw"
Signed-off-by: Changming Huang <jerry.huang@nxp.com>
---
changes since v3:
no changes.
changes since v2:
1. introduce option BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS.
2. introduce option BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_DEPENDENCIES.
3. rewrite the makefile with these two options
changes since v1:
1. Use option BR2_PACKAGE_HOST_RCW_ATF as the condition for RCW used by ATF.
---
boot/arm-trusted-firmware/Config.in | 11 +++++++++++
boot/arm-trusted-firmware/arm-trusted-firmware.mk | 6 ++++++
2 files changed, 17 insertions(+)
diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
index 96861c3f4d..635bda2e86 100644
--- a/boot/arm-trusted-firmware/Config.in
+++ b/boot/arm-trusted-firmware/Config.in
@@ -153,4 +153,15 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
Names of generated image files that are installed in the
output images/ directory.
+config BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS
+ string "Additional ATF targets options"
+ help
+ Additional target options for ATF build
+ E.G. 'pbl'
+
+config BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_DEPENDENCIES
+ string "Additional AFT dependencies"
+ help
+ Additional dependencies for ATF build, E.G. "host-qoriq-rcw"
+
endif
diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index 2133d39e6d..2c22d49de5 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -92,6 +92,12 @@ endif
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all
+ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += \
+ $(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS))
+
+ARM_TRUSTED_FIRMWARE_DEPENDENCIES += \
+ $(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_DEPENDENCIES))
+
ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y)
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-openssl
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options
2020-02-05 10:52 ` [Buildroot] [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options Changming Huang
@ 2020-02-05 12:29 ` Thomas Petazzoni
2020-02-07 1:21 ` [Buildroot] [EXT] " Jerry Huang
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2020-02-05 12:29 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 5 Feb 2020 18:52:23 +0800
Changming Huang <jerry.huang@nxp.com> wrote:
> two new options for arm-trusted-firmware:
> 1. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS
> - for additional targets, E.G. "pbl".
This option was already added in commit
05b8c7da6de863561d66717735a4870f2766454c, which is part of Buildroot
master.
> 2. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_DEPENDENCIES
> - for additional dependencies, E.G. "host-qoriq-rcw"
>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
No need to resend just for that, though, it can be fixed when applying.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [EXT] Re: [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options
2020-02-05 12:29 ` Thomas Petazzoni
@ 2020-02-07 1:21 ` Jerry Huang
0 siblings, 0 replies; 3+ messages in thread
From: Jerry Huang @ 2020-02-07 1:21 UTC (permalink / raw)
To: buildroot
Best Regards
Jerry Huang
> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Sent: Wednesday, February 5, 2020 8:29 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot at busybox.net; olteanv at gmail.com; michael at walle.cc;
> geomatsi at gmail.com; matthew.weber at collins.com
> Subject: [EXT] Re: [Buildroot] [PATCH v4 5/9] boot/arm-trusted-firmware:
> introduce two new options
>
> Caution: EXT Email
>
> Hello,
>
> On Wed, 5 Feb 2020 18:52:23 +0800
> Changming Huang <jerry.huang@nxp.com> wrote:
>
> > two new options for arm-trusted-firmware:
> > 1. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS
> > - for additional targets, E.G. "pbl".
>
> This option was already added in commit
> 05b8c7da6de863561d66717735a4870f2766454c, which is part of Buildroot
> master.
>
> > 2. BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_DEPENDENCIES
> > - for additional dependencies, E.G. "host-qoriq-rcw"
> >
> > Signed-off-by: Changming Huang <jerry.huang@nxp.com>
>
> No need to resend just for that, though, it can be fixed when applying.
Sure, I will remove this options from next version.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
> om&data=02%7C01%7Cjerry.huang%40nxp.com%7Cc92f05de22194ab439
> ff08d7aa3709bc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371
> 65025674223306&sdata=wsI3e76EHN6NNtKknPiZpBnWAn1FyALHUgbjp4
> LKAdw%3D&reserved=0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-10 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-10 14:30 [Buildroot] [EXT] Re: [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options Gervais, Francois
2020-02-10 14:42 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2020-02-05 10:52 [Buildroot] [PATCH v4 1/9] package/nxp: new package directory Changming Huang
2020-02-05 10:52 ` [Buildroot] [PATCH v4 5/9] boot/arm-trusted-firmware: introduce two new options Changming Huang
2020-02-05 12:29 ` Thomas Petazzoni
2020-02-07 1:21 ` [Buildroot] [EXT] " Jerry Huang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.