From: Bjorn Helgaas <helgaas@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Wilczynski <kw@linux.com>
Subject: Re: [PATCH] PCI/ACPI: make array pcie_to_hpx3_type static const, makes object smaller
Date: Mon, 10 Feb 2020 22:39:22 +0000 [thread overview]
Message-ID: <20200210223922.GA76091@google.com> (raw)
In-Reply-To: <20200210085256.319424-1-colin.king@canonical.com>
In-Reply-To: <20200210085256.319424-1-colin.king@canonical.com>
[+cc Krzysztof]
On Mon, Feb 10, 2020 at 08:52:56AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array pcie_to_hpx3_type on the stack but instead
> make it static const. Makes the object code smaller by 6 bytes:
>
> Before:
> text data bss dec hex filename
> 19247 3048 64 22359 5757 drivers/pci/pci-acpi.o
>
> After:
> text data bss dec hex filename
> 19177 3112 64 22353 5751 drivers/pci/pci-acpi.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Nice cleanup, thanks! Applied to pci/misc for v5.7.
> ---
> drivers/pci/pci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index 0c02d500158f..d914f8bc31ea 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -439,7 +439,7 @@ enum hpx_type3_dev_type {
> static u16 hpx3_device_type(struct pci_dev *dev)
> {
> u16 pcie_type = pci_pcie_type(dev);
> - const int pcie_to_hpx3_type[] = {
> + static const int pcie_to_hpx3_type[] = {
> [PCI_EXP_TYPE_ENDPOINT] = HPX_TYPE_ENDPOINT,
> [PCI_EXP_TYPE_LEG_END] = HPX_TYPE_LEG_END,
> [PCI_EXP_TYPE_RC_END] = HPX_TYPE_RC_END,
> --
> 2.25.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Wilczynski <kw@linux.com>
Subject: Re: [PATCH] PCI/ACPI: make array pcie_to_hpx3_type static const, makes object smaller
Date: Mon, 10 Feb 2020 16:39:22 -0600 [thread overview]
Message-ID: <20200210223922.GA76091@google.com> (raw)
In-Reply-To: <20200210085256.319424-1-colin.king@canonical.com>
[+cc Krzysztof]
On Mon, Feb 10, 2020 at 08:52:56AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array pcie_to_hpx3_type on the stack but instead
> make it static const. Makes the object code smaller by 6 bytes:
>
> Before:
> text data bss dec hex filename
> 19247 3048 64 22359 5757 drivers/pci/pci-acpi.o
>
> After:
> text data bss dec hex filename
> 19177 3112 64 22353 5751 drivers/pci/pci-acpi.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Nice cleanup, thanks! Applied to pci/misc for v5.7.
> ---
> drivers/pci/pci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index 0c02d500158f..d914f8bc31ea 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -439,7 +439,7 @@ enum hpx_type3_dev_type {
> static u16 hpx3_device_type(struct pci_dev *dev)
> {
> u16 pcie_type = pci_pcie_type(dev);
> - const int pcie_to_hpx3_type[] = {
> + static const int pcie_to_hpx3_type[] = {
> [PCI_EXP_TYPE_ENDPOINT] = HPX_TYPE_ENDPOINT,
> [PCI_EXP_TYPE_LEG_END] = HPX_TYPE_LEG_END,
> [PCI_EXP_TYPE_RC_END] = HPX_TYPE_RC_END,
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-02-10 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 8:52 [PATCH] PCI/ACPI: make array pcie_to_hpx3_type static const, makes object smaller Colin King
2020-02-10 22:39 ` Bjorn Helgaas [this message]
2020-02-10 22:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210223922.GA76091@google.com \
--to=helgaas@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.