* [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback
@ 2020-02-11 16:15 Chris Wilson
2020-02-11 16:50 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2020-02-11 16:15 UTC (permalink / raw)
To: igt-dev
The principle test for kms_busy is checking the synchronisation between
on-going rendering to a framebuffer and its flip, that is independent of
the pipe. As such for our fast feedback on driver health, we can look at
the first pipe and assume any errors on the rest will be picked up later
in the shards/idle runs.
Each pass of kms_busy is about 25s.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/intel-ci/fast-feedback.testlist | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 467e11267..c0a2cce52 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -89,8 +89,6 @@ igt@kms_addfb_basic@unused-modifier
igt@kms_addfb_basic@unused-offsets
igt@kms_addfb_basic@unused-pitches
igt@kms_busy@basic-flip-pipe-a
-igt@kms_busy@basic-flip-pipe-b
-igt@kms_busy@basic-flip-pipe-c
igt@kms_chamelium@dp-hpd-fast
igt@kms_chamelium@dp-edid-read
igt@kms_chamelium@dp-crc-fast
--
2.25.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback 2020-02-11 16:15 [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback Chris Wilson @ 2020-02-11 16:50 ` Ville Syrjälä 2020-02-11 17:01 ` Chris Wilson 2020-02-11 17:03 ` [igt-dev] [PATCH i-g-t v2] " Chris Wilson 2020-02-11 17:08 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2 siblings, 1 reply; 5+ messages in thread From: Ville Syrjälä @ 2020-02-11 16:50 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev On Tue, Feb 11, 2020 at 04:15:08PM +0000, Chris Wilson wrote: > The principle test for kms_busy is checking the synchronisation between > on-going rendering to a framebuffer and its flip, that is independent of > the pipe. As such for our fast feedback on driver health, we can look at > the first pipe and assume any errors on the rest will be picked up later > in the shards/idle runs. > > Each pass of kms_busy is about 25s. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/intel-ci/fast-feedback.testlist | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist > index 467e11267..c0a2cce52 100644 > --- a/tests/intel-ci/fast-feedback.testlist > +++ b/tests/intel-ci/fast-feedback.testlist > @@ -89,8 +89,6 @@ igt@kms_addfb_basic@unused-modifier > igt@kms_addfb_basic@unused-offsets > igt@kms_addfb_basic@unused-pitches > igt@kms_busy@basic-flip-pipe-a > -igt@kms_busy@basic-flip-pipe-b > -igt@kms_busy@basic-flip-pipe-c We will lose a bit of coverage on fi-bsw-n3050 since it has HDMI plugged into port D which can only be driven by pipe C. The other similar restrictions we have only affect gen2/3 lvds and vlv/chv dsi, so meh on those. I guess slightly better solutions migh be: a) change the test to not be per-pipe but instead have it stop as soon as it has found any working pipe+output b) support some form of logical OR with short cicuit in the testlist (ie. igt@kms_busy@basic-flip-pipe-a || igt@kms_busy@basic-flip-pipe-b || ...) But not sure how worried we should be about the loss of coverage on that single bsw. I guess we will hit it via the idle runs anyway, assuming anyone looks at those. And I can't recall kms_busy being a problem in the past for us, so it's probably fine. Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > igt@kms_chamelium@dp-hpd-fast > igt@kms_chamelium@dp-edid-read > igt@kms_chamelium@dp-crc-fast > -- > 2.25.0 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev -- Ville Syrjälä Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback 2020-02-11 16:50 ` Ville Syrjälä @ 2020-02-11 17:01 ` Chris Wilson 0 siblings, 0 replies; 5+ messages in thread From: Chris Wilson @ 2020-02-11 17:01 UTC (permalink / raw) To: Ville Syrjälä; +Cc: igt-dev Quoting Ville Syrjälä (2020-02-11 16:50:15) > On Tue, Feb 11, 2020 at 04:15:08PM +0000, Chris Wilson wrote: > > The principle test for kms_busy is checking the synchronisation between > > on-going rendering to a framebuffer and its flip, that is independent of > > the pipe. As such for our fast feedback on driver health, we can look at > > the first pipe and assume any errors on the rest will be picked up later > > in the shards/idle runs. > > > > Each pass of kms_busy is about 25s. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > --- > > tests/intel-ci/fast-feedback.testlist | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist > > index 467e11267..c0a2cce52 100644 > > --- a/tests/intel-ci/fast-feedback.testlist > > +++ b/tests/intel-ci/fast-feedback.testlist > > @@ -89,8 +89,6 @@ igt@kms_addfb_basic@unused-modifier > > igt@kms_addfb_basic@unused-offsets > > igt@kms_addfb_basic@unused-pitches > > igt@kms_busy@basic-flip-pipe-a > > -igt@kms_busy@basic-flip-pipe-b > > -igt@kms_busy@basic-flip-pipe-c > > We will lose a bit of coverage on fi-bsw-n3050 since it has HDMI > plugged into port D which can only be driven by pipe C. The other > similar restrictions we have only affect gen2/3 lvds and vlv/chv > dsi, so meh on those. > > I guess slightly better solutions migh be: > a) change the test to not be per-pipe but instead have it > stop as soon as it has found any working pipe+output > b) support some form of logical OR with short cicuit in the testlist > (ie. igt@kms_busy@basic-flip-pipe-a || igt@kms_busy@basic-flip-pipe-b || ...) > > But not sure how worried we should be about the loss of coverage on > that single bsw. I guess we will hit it via the idle runs anyway, > assuming anyone looks at those. And I can't recall kms_busy being a > problem in the past for us, so it's probably fine. The other aspect is why do we need 20s to determine if a flip/modeset is too late? I haven't worked out why this test is as slow as it is. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t v2] intel-ci: Drop b/c pipes from kms_busy fast feedback 2020-02-11 16:15 [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback Chris Wilson 2020-02-11 16:50 ` Ville Syrjälä @ 2020-02-11 17:03 ` Chris Wilson 2020-02-11 17:08 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Chris Wilson @ 2020-02-11 17:03 UTC (permalink / raw) To: igt-dev The principle test for kms_busy is checking the synchronisation between on-going rendering to a framebuffer and its flip, that is independent of the pipe. As such for our fast feedback on driver health, we can look at the first pipe and assume any errors on the rest will be picked up later in the shards/idle runs. Each pass of kms_busy is about 25s. v2: Use the first pipe connected; combine flip/modeset testing into a single dynamic group. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> --- tests/intel-ci/fast-feedback.testlist | 4 +--- tests/kms_busy.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index 467e11267..739e2d46b 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -88,9 +88,7 @@ igt@kms_addfb_basic@unused-handle igt@kms_addfb_basic@unused-modifier igt@kms_addfb_basic@unused-offsets igt@kms_addfb_basic@unused-pitches -igt@kms_busy@basic-flip-pipe-a -igt@kms_busy@basic-flip-pipe-b -igt@kms_busy@basic-flip-pipe-c +igt@kms_busy@basic igt@kms_chamelium@dp-hpd-fast igt@kms_chamelium@dp-edid-read igt@kms_chamelium@dp-crc-fast diff --git a/tests/kms_busy.c b/tests/kms_busy.c index 0172fcb61..7e495fe2c 100644 --- a/tests/kms_busy.c +++ b/tests/kms_busy.c @@ -302,6 +302,21 @@ igt_main /* XXX Extend to cover atomic rendering tests to all planes + legacy */ + igt_subtest_with_dynamic("basic") { /* just run on the first pipe */ + enum pipe pipe; + igt_output_t *output; + + igt_require(gem_has_ring(display.drm_fd, eb_ring(e))); + + for_each_pipe_with_valid_output(&display, pipe, output) { + igt_dynamic("flip") + test_flip(&display, eb_ring(e), pipe, false); + igt_dynamic("modeset") + test_flip(&display, eb_ring(e), pipe, true); + break; + } + } + for_each_pipe_static(n) igt_subtest_group { igt_hang_t hang; -- 2.25.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for intel-ci: Drop b/c pipes from kms_busy fast feedback 2020-02-11 16:15 [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback Chris Wilson 2020-02-11 16:50 ` Ville Syrjälä 2020-02-11 17:03 ` [igt-dev] [PATCH i-g-t v2] " Chris Wilson @ 2020-02-11 17:08 ` Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-02-11 17:08 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: intel-ci: Drop b/c pipes from kms_busy fast feedback URL : https://patchwork.freedesktop.org/series/73314/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7913 -> IGTPW_4129 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_4129 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4129, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4129: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live_blt: - fi-snb-2520m: [PASS][1] -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-snb-2520m/igt@i915_selftest@live_blt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-snb-2520m/igt@i915_selftest@live_blt.html Known issues ------------ Here are the changes found in IGTPW_4129 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-byt-n2820: [PASS][3] -> [INCOMPLETE][4] ([i915#45]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-byt-n2820/igt@gem_close_race@basic-threads.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-byt-n2820/igt@gem_close_race@basic-threads.html * igt@i915_module_load@reload: - fi-skl-6770hq: [PASS][5] -> [DMESG-WARN][6] ([i915#92]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-skl-6770hq/igt@i915_module_load@reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-skl-6770hq/igt@i915_module_load@reload.html * igt@i915_selftest@live_gem_contexts: - fi-cfl-guc: [PASS][7] -> [INCOMPLETE][8] ([CI#80] / [fdo#106070] / [i915#424]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_gtt: - fi-skl-6600u: [PASS][9] -> [TIMEOUT][10] ([fdo#111732] / [fdo#112271]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-skl-6600u/igt@i915_selftest@live_gtt.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-skl-6600u/igt@i915_selftest@live_gtt.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][11] -> [FAIL][12] ([fdo#111096] / [i915#323]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-skl-6770hq: [PASS][13] -> [SKIP][14] ([fdo#109271]) +5 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html * igt@kms_pipe_crc_basic@read-crc-pipe-b: - fi-skl-6770hq: [PASS][15] -> [DMESG-WARN][16] ([i915#106]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7913/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-b.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-b.html [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80 [fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#106]: https://gitlab.freedesktop.org/drm/intel/issues/106 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424 [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 Participating hosts (46 -> 46) ------------------------------ Additional (6): fi-hsw-peppy fi-bdw-gvtdvm fi-bwr-2160 fi-bsw-kefka fi-skl-lmem fi-skl-6700k2 Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5435 -> IGTPW_4129 CI-20190529: 20190529 CI_DRM_7913: 79a47aba009d3a6d94a900c557a11cb7af59afaf @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4129: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/index.html IGT_5435: 2b6d4476dde53c363b8808ed9f0dd5547ac78641 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4129/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-11 17:08 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-11 16:15 [igt-dev] [PATCH i-g-t] intel-ci: Drop b/c pipes from kms_busy fast feedback Chris Wilson 2020-02-11 16:50 ` Ville Syrjälä 2020-02-11 17:01 ` Chris Wilson 2020-02-11 17:03 ` [igt-dev] [PATCH i-g-t v2] " Chris Wilson 2020-02-11 17:08 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.