All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: Clement Leger <cleger@kalray.eu>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-remoteproc@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Andy Gross <agross@kernel.org>,
	Patrice Chotard <patrice.chotard@st.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Loic PALLARDY <loic.pallardy@st.com>, s-anna <s-anna@ti.com>
Subject: Re: [PATCH v4 0/5] remoteproc: Add elf64 support
Date: Tue, 11 Feb 2020 16:12:53 -0700	[thread overview]
Message-ID: <20200211231253.GC27770@xps15> (raw)
In-Reply-To: <5b8045be-0942-2ecf-5dba-dad58071f6af@st.com>

On Tue, Feb 11, 2020 at 04:57:18PM +0100, Arnaud POULIQUEN wrote:
> Hi Clement,
> 
> I tested the series on the stm32 platform for remote proc firmwre load: no regression found.
> I do not test the da_to_va feature as not implemented on stm32 platform.

It would be very interesting if you could test the coredump, that would give us
a lot more confidence in the implementation.

Thanks,
Mathieu

> 
> Regards,
> Arnaud
> 
> 
> 
> On 2/10/20 5:22 PM, Clement Leger wrote:
> > This serie add support for elf64 in remoteproc (elf loader, coredump). 
> > First two patches modifies the type of len argument (in da_to_va) and
> > boot_addr in order to allow loading elf64 segment with a u64 size
> > and a u64 entry point.
> > Next patch introduce a set of macros to access elf64 and elf32
> > transparently.
> > Last two patches are the actual modification in the elf loader and
> > remoteproc coredump support to add elf64 support.
> > 
> > Changes from V3:
> >  - Adapt coredump to elf64 file format
> >  - Rename remoteproc_elf_loader.h to remoteproc_elf_helpers.h
> >  - Update copyright year in remoteproc_elf_helpers.h
> >  - Rename macros elf_hdr_* to elf_get_hdr_* for coherency with elf_hdr_set_*
> >  - Split elf64 loader patch in 3:
> >    - boot_addr u64 change
> >    - remoteproc_elf_helpers.h creation
> >    - elf64 loading
> > 
> > Clement Leger (5):
> >   remoteproc: Use u64 len for da_to_va
> >   remoteproc: Use u64 type for boot_addr
> >   remoteproc: Add elf helpers to access elf64 and elf32 fields
> >   remoteproc: Add elf64 support in elf loader
> >   remoteproc: Adapt coredump to generate correct elf type
> > 
> >  Documentation/remoteproc.txt                |   2 +-
> >  drivers/remoteproc/imx_rproc.c              |  11 +-
> >  drivers/remoteproc/keystone_remoteproc.c    |   4 +-
> >  drivers/remoteproc/qcom_q6v5_adsp.c         |   2 +-
> >  drivers/remoteproc/qcom_q6v5_mss.c          |   2 +-
> >  drivers/remoteproc/qcom_q6v5_pas.c          |   2 +-
> >  drivers/remoteproc/qcom_q6v5_wcss.c         |   2 +-
> >  drivers/remoteproc/qcom_wcnss.c             |   2 +-
> >  drivers/remoteproc/remoteproc_core.c        |  69 +++++++------
> >  drivers/remoteproc/remoteproc_elf_helpers.h |  95 ++++++++++++++++++
> >  drivers/remoteproc/remoteproc_elf_loader.c  | 150 ++++++++++++++++++----------
> >  drivers/remoteproc/remoteproc_internal.h    |   4 +-
> >  drivers/remoteproc/st_remoteproc.c          |   2 +-
> >  drivers/remoteproc/st_slim_rproc.c          |   4 +-
> >  drivers/remoteproc/wkup_m3_rproc.c          |   4 +-
> >  include/linux/remoteproc.h                  |   7 +-
> >  16 files changed, 252 insertions(+), 110 deletions(-)
> >  create mode 100644 drivers/remoteproc/remoteproc_elf_helpers.h
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Loic PALLARDY <loic.pallardy@st.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-doc@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	Patrice Chotard <patrice.chotard@st.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Clement Leger <cleger@kalray.eu>, Andy Gross <agross@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-arm-msm@vger.kernel.org, s-anna <s-anna@ti.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 0/5] remoteproc: Add elf64 support
Date: Tue, 11 Feb 2020 16:12:53 -0700	[thread overview]
Message-ID: <20200211231253.GC27770@xps15> (raw)
In-Reply-To: <5b8045be-0942-2ecf-5dba-dad58071f6af@st.com>

On Tue, Feb 11, 2020 at 04:57:18PM +0100, Arnaud POULIQUEN wrote:
> Hi Clement,
> 
> I tested the series on the stm32 platform for remote proc firmwre load: no regression found.
> I do not test the da_to_va feature as not implemented on stm32 platform.

It would be very interesting if you could test the coredump, that would give us
a lot more confidence in the implementation.

Thanks,
Mathieu

> 
> Regards,
> Arnaud
> 
> 
> 
> On 2/10/20 5:22 PM, Clement Leger wrote:
> > This serie add support for elf64 in remoteproc (elf loader, coredump). 
> > First two patches modifies the type of len argument (in da_to_va) and
> > boot_addr in order to allow loading elf64 segment with a u64 size
> > and a u64 entry point.
> > Next patch introduce a set of macros to access elf64 and elf32
> > transparently.
> > Last two patches are the actual modification in the elf loader and
> > remoteproc coredump support to add elf64 support.
> > 
> > Changes from V3:
> >  - Adapt coredump to elf64 file format
> >  - Rename remoteproc_elf_loader.h to remoteproc_elf_helpers.h
> >  - Update copyright year in remoteproc_elf_helpers.h
> >  - Rename macros elf_hdr_* to elf_get_hdr_* for coherency with elf_hdr_set_*
> >  - Split elf64 loader patch in 3:
> >    - boot_addr u64 change
> >    - remoteproc_elf_helpers.h creation
> >    - elf64 loading
> > 
> > Clement Leger (5):
> >   remoteproc: Use u64 len for da_to_va
> >   remoteproc: Use u64 type for boot_addr
> >   remoteproc: Add elf helpers to access elf64 and elf32 fields
> >   remoteproc: Add elf64 support in elf loader
> >   remoteproc: Adapt coredump to generate correct elf type
> > 
> >  Documentation/remoteproc.txt                |   2 +-
> >  drivers/remoteproc/imx_rproc.c              |  11 +-
> >  drivers/remoteproc/keystone_remoteproc.c    |   4 +-
> >  drivers/remoteproc/qcom_q6v5_adsp.c         |   2 +-
> >  drivers/remoteproc/qcom_q6v5_mss.c          |   2 +-
> >  drivers/remoteproc/qcom_q6v5_pas.c          |   2 +-
> >  drivers/remoteproc/qcom_q6v5_wcss.c         |   2 +-
> >  drivers/remoteproc/qcom_wcnss.c             |   2 +-
> >  drivers/remoteproc/remoteproc_core.c        |  69 +++++++------
> >  drivers/remoteproc/remoteproc_elf_helpers.h |  95 ++++++++++++++++++
> >  drivers/remoteproc/remoteproc_elf_loader.c  | 150 ++++++++++++++++++----------
> >  drivers/remoteproc/remoteproc_internal.h    |   4 +-
> >  drivers/remoteproc/st_remoteproc.c          |   2 +-
> >  drivers/remoteproc/st_slim_rproc.c          |   4 +-
> >  drivers/remoteproc/wkup_m3_rproc.c          |   4 +-
> >  include/linux/remoteproc.h                  |   7 +-
> >  16 files changed, 252 insertions(+), 110 deletions(-)
> >  create mode 100644 drivers/remoteproc/remoteproc_elf_helpers.h
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-11 23:12 UTC|newest]

Thread overview: 164+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  8:28 [RFC PATCH] rproc: Add elf64 support in elf loader Clément Leger
2019-05-07 12:09 ` Clément Leger
2019-05-07 13:37   ` Arnaud Pouliquen
2019-05-09  8:59     ` Clément Leger
2019-08-19 11:45     ` [PATCH] " Clement Leger
2019-09-13 10:58       ` Clément Leger
2019-10-04  8:27         ` Clément Leger
2019-10-04 18:42       ` [PATCH v2] remoteproc: " Clement Leger
2020-01-09  9:31         ` Clément Leger
2020-01-24  0:53         ` Mathieu Poirier
2020-01-24  8:24           ` Clément Leger
2020-01-24 18:10             ` Mathieu Poirier
2020-01-24 18:10               ` Mathieu Poirier
2020-01-24 21:58             ` Mathieu Poirier
2020-01-24 21:58               ` Mathieu Poirier
2020-01-27  8:33               ` Clément Leger
2020-01-28 17:14                 ` Mathieu Poirier
2020-01-29  8:55                   ` Clément Leger
2020-01-29 16:30                     ` Mathieu Poirier
2020-01-29 16:30                       ` Mathieu Poirier
2020-02-04 14:33                       ` [PATCH v2 1/2] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-04 14:33                         ` Clement Leger
2020-02-04 14:33                         ` [PATCH v2 2/2] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-04 14:33                           ` Clement Leger
2020-02-04 16:27                         ` [PATCH v2 1/2] remoteproc: Use u64 len for da_to_va Arnaud POULIQUEN
2020-02-04 16:27                           ` Arnaud POULIQUEN
2020-02-04 16:27                           ` Arnaud POULIQUEN
2020-02-04 17:10                           ` Clément Leger
2020-02-04 17:10                             ` Clément Leger
2020-02-04 17:42                             ` Arnaud POULIQUEN
2020-02-04 17:42                               ` Arnaud POULIQUEN
2020-02-04 17:42                               ` Arnaud POULIQUEN
2020-02-04 17:44                       ` [PATCH v3 0/2] remoteproc: Add elf64 support to elf loader Clement Leger
2020-02-04 17:44                         ` Clement Leger
2020-02-04 17:44                         ` [PATCH v3 1/2] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-04 17:44                           ` Clement Leger
2020-02-05 21:06                           ` Mathieu Poirier
2020-02-05 21:06                             ` Mathieu Poirier
2020-02-04 17:44                         ` [PATCH v3 2/2] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-04 17:44                           ` Clement Leger
2020-02-05 22:49                           ` Mathieu Poirier
2020-02-05 22:49                             ` Mathieu Poirier
2020-02-06  8:37                             ` Clément Leger
2020-02-06  8:37                               ` Clément Leger
2020-02-06 15:05                               ` Clément Leger
2020-02-06 15:05                                 ` Clément Leger
2020-02-06 17:48                                 ` Mathieu Poirier
2020-02-06 17:48                                   ` Mathieu Poirier
2020-02-06 17:48                                   ` Mathieu Poirier
2020-02-07  7:57                                   ` Clément Leger
2020-02-07  7:57                                     ` Clément Leger
2020-02-10 16:22                                     ` [PATCH v4 0/5] remoteproc: Add elf64 support Clement Leger
2020-02-10 16:22                                       ` Clement Leger
2020-02-10 16:22                                       ` [PATCH v4 1/5] remoteproc: Use u64 len for da_to_va Clement Leger
2020-02-10 16:22                                         ` Clement Leger
2020-02-11 15:53                                         ` Arnaud POULIQUEN
2020-02-11 15:53                                           ` Arnaud POULIQUEN
2020-02-11 15:53                                           ` Arnaud POULIQUEN
2020-02-11 16:39                                           ` Clément Leger
2020-02-11 16:39                                             ` Clément Leger
2020-02-11 17:24                                             ` Arnaud POULIQUEN
2020-02-11 17:24                                               ` Arnaud POULIQUEN
2020-02-11 22:37                                             ` Mathieu Poirier
2020-02-11 22:37                                               ` Mathieu Poirier
2020-02-11 22:37                                               ` Mathieu Poirier
2020-02-12 10:37                                               ` Clément Leger
2020-02-12 10:37                                                 ` Clément Leger
2020-02-12 21:59                                                 ` Mathieu Poirier
2020-02-12 21:59                                                   ` Mathieu Poirier
2020-02-18 10:10                                                   ` Clément Leger
2020-02-18 10:10                                                     ` Clément Leger
2020-02-18 17:01                                                     ` Mathieu Poirier
2020-02-18 17:01                                                       ` Mathieu Poirier
2020-02-10 16:22                                       ` [PATCH v4 2/5] remoteproc: Use u64 type for boot_addr Clement Leger
2020-02-10 16:22                                         ` Clement Leger
2020-02-10 16:22                                       ` [PATCH v4 3/5] remoteproc: Add elf helpers to access elf64 and elf32 fields Clement Leger
2020-02-10 16:22                                         ` Clement Leger
2020-02-10 16:22                                       ` [PATCH v4 4/5] remoteproc: Add elf64 support in elf loader Clement Leger
2020-02-10 16:22                                         ` Clement Leger
2020-02-10 16:22                                       ` [PATCH v4 5/5] remoteproc: Adapt coredump to generate correct elf type Clement Leger
2020-02-10 16:22                                         ` Clement Leger
2020-02-11 23:11                                         ` Mathieu Poirier
2020-02-11 23:11                                           ` Mathieu Poirier
2020-02-11 15:57                                       ` [PATCH v4 0/5] remoteproc: Add elf64 support Arnaud POULIQUEN
2020-02-11 15:57                                         ` Arnaud POULIQUEN
2020-02-11 15:57                                         ` Arnaud POULIQUEN
2020-02-11 23:12                                         ` Mathieu Poirier [this message]
2020-02-11 23:12                                           ` Mathieu Poirier
2020-02-12  8:15                                           ` Arnaud POULIQUEN
2020-02-12  8:15                                             ` Arnaud POULIQUEN
2020-02-12  8:15                                             ` Arnaud POULIQUEN
2020-03-02  9:38                                       ` [PATCH v5 0/8] " Clement Leger
2020-03-02  9:38                                         ` Clement Leger
2020-03-02  9:38                                         ` [PATCH v5 1/8] remoteproc: Use size_t type for len in da_to_va Clement Leger
2020-03-02  9:38                                           ` Clement Leger
2020-03-02 23:06                                           ` Bjorn Andersson
2020-03-02 23:06                                             ` Bjorn Andersson
2020-03-02 23:06                                             ` Bjorn Andersson
2020-03-09 17:52                                           ` Mathieu Poirier
2020-03-09 17:52                                             ` Mathieu Poirier
2020-03-27  7:37                                           ` Oleksij Rempel
2020-03-27  7:37                                             ` Oleksij Rempel
2020-03-02  9:38                                         ` [PATCH v5 2/8] remoteproc: Use size_t instead of int for rproc_mem_entry len Clement Leger
2020-03-02  9:38                                           ` Clement Leger
2020-03-02 23:07                                           ` Bjorn Andersson
2020-03-02 23:07                                             ` Bjorn Andersson
2020-03-02 23:07                                             ` Bjorn Andersson
2020-03-09 19:21                                           ` Mathieu Poirier
2020-03-09 19:21                                             ` Mathieu Poirier
2020-03-02  9:38                                         ` [PATCH v5 3/8] remoteproc: Use u64 type for boot_addr Clement Leger
2020-03-02  9:38                                           ` Clement Leger
2020-03-02 23:08                                           ` Bjorn Andersson
2020-03-02 23:08                                             ` Bjorn Andersson
2020-03-02 23:08                                             ` Bjorn Andersson
2020-03-09 19:52                                           ` Mathieu Poirier
2020-03-09 19:52                                             ` Mathieu Poirier
2020-03-10  7:59                                             ` Clément Leger
2020-03-10  7:59                                               ` Clément Leger
2020-03-10 19:32                                               ` Bjorn Andersson
2020-03-10 19:32                                                 ` Bjorn Andersson
2020-03-10 19:32                                                 ` Bjorn Andersson
2020-03-02  9:38                                         ` [PATCH v5 4/8] remoteproc: Add elf helpers to access elf64 and elf32 fields Clement Leger
2020-03-02  9:38                                           ` Clement Leger
2020-03-02 23:12                                           ` Bjorn Andersson
2020-03-02 23:12                                             ` Bjorn Andersson
2020-03-02 23:12                                             ` Bjorn Andersson
2020-03-09 19:56                                           ` Mathieu Poirier
2020-03-09 19:56                                             ` Mathieu Poirier
2020-03-02  9:38                                         ` [PATCH v5 5/8] remoteproc: Rename rproc_elf_sanity_check for elf32 Clement Leger
2020-03-02  9:38                                           ` Clement Leger
2020-03-02 23:13                                           ` Bjorn Andersson
2020-03-02 23:13                                             ` Bjorn Andersson
2020-03-02 23:13                                             ` Bjorn Andersson
2020-03-03  8:02                                             ` Clément Leger
2020-03-03  8:02                                               ` Clément Leger
2020-03-10  0:00                                               ` Bjorn Andersson
2020-03-10  0:00                                                 ` Bjorn Andersson
2020-03-10  0:00                                                 ` Bjorn Andersson
2020-03-10 15:20                                                 ` Mathieu Poirier
2020-03-10 15:20                                                   ` Mathieu Poirier
2020-03-10 15:20                                                   ` Mathieu Poirier
2020-03-10 15:38                                                   ` Clément Leger
2020-03-10 15:38                                                     ` Clément Leger
2020-03-10 19:18                                                     ` Mathieu Poirier
2020-03-10 19:18                                                       ` Mathieu Poirier
2020-03-10 19:30                                                     ` Bjorn Andersson
2020-03-10 19:30                                                       ` Bjorn Andersson
2020-03-10 19:30                                                       ` Bjorn Andersson
2020-03-02  9:39                                         ` [PATCH v5 6/8] remoteproc: Add elf64 support in elf loader Clement Leger
2020-03-02  9:39                                           ` Clement Leger
2020-03-02  9:39                                         ` [PATCH v5 7/8] remoteproc: Allow overriding only sanity_check Clement Leger
2020-03-02  9:39                                           ` Clement Leger
2020-03-02  9:39                                         ` [PATCH v5 8/8] remoteproc: Adapt coredump to generate correct elf type Clement Leger
2020-03-02  9:39                                           ` Clement Leger
2020-03-03 22:01                                           ` Bjorn Andersson
2020-03-03 22:01                                             ` Bjorn Andersson
2020-03-03 22:01                                             ` Bjorn Andersson
2020-03-09 20:32                                           ` Mathieu Poirier
2020-03-09 20:32                                             ` Mathieu Poirier
2020-03-09 23:57                                             ` Bjorn Andersson
2020-03-09 23:57                                               ` Bjorn Andersson
2020-03-09 23:57                                               ` Bjorn Andersson
2020-03-10  8:12                                               ` Clément Leger
2020-03-10  8:12                                                 ` Clément Leger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211231253.GC27770@xps15 \
    --to=mathieu.poirier@linaro.org \
    --cc=agross@kernel.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=cleger@kalray.eu \
    --cc=corbet@lwn.net \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=loic.pallardy@st.com \
    --cc=ohad@wizery.com \
    --cc=patrice.chotard@st.com \
    --cc=s-anna@ti.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.