From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
Zha Bin <zhabin@linux.alibaba.com>,
slp@redhat.com, "Liu, Jing2" <jing2.liu@linux.intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
chao.p.peng@linux.intel.com, gerry@linux.alibaba.com
Subject: Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support
Date: Wed, 12 Feb 2020 04:15:01 -0500 [thread overview]
Message-ID: <20200212041317-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <4557a5e8-74eb-f238-1579-b7b558cb2969@redhat.com>
On Wed, Feb 12, 2020 at 05:03:00PM +0800, Jason Wang wrote:
>
> On 2020/2/11 下午10:00, Michael S. Tsirkin wrote:
> > > Yes, it can work but it may bring extra effort when you want to mask a
> > > vector which is was shared by a lot of queues.
> > >
> > > Thanks
> > >
> > masking should be per vq too.
> >
> > --
>
>
> Yes, but if the vector is shard by e.g 16 queues, then all those virtqueues
> needs to be masked which is expensive.
>
> Thanks
I think that's ok - masking is rare. in fact if vectors can be
changed atomically I'm no longer sure they are needed,
maybe a destructive "disable" which can lose interrupts
is enough.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
Zha Bin <zhabin@linux.alibaba.com>,
slp@redhat.com, "Liu, Jing2" <jing2.liu@linux.intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
chao.p.peng@linux.intel.com, gerry@linux.alibaba.com
Subject: Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support
Date: Wed, 12 Feb 2020 04:15:01 -0500 [thread overview]
Message-ID: <20200212041317-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <4557a5e8-74eb-f238-1579-b7b558cb2969@redhat.com>
On Wed, Feb 12, 2020 at 05:03:00PM +0800, Jason Wang wrote:
>
> On 2020/2/11 下午10:00, Michael S. Tsirkin wrote:
> > > Yes, it can work but it may bring extra effort when you want to mask a
> > > vector which is was shared by a lot of queues.
> > >
> > > Thanks
> > >
> > masking should be per vq too.
> >
> > --
>
>
> Yes, but if the vector is shard by e.g 16 queues, then all those virtqueues
> needs to be masked which is expensive.
>
> Thanks
I think that's ok - masking is rare. in fact if vectors can be
changed atomically I'm no longer sure they are needed,
maybe a destructive "disable" which can lose interrupts
is enough.
--
MST
next prev parent reply other threads:[~2020-02-12 9:15 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 9:05 [PATCH v2 0/5] virtio mmio specification enhancement Zha Bin
2020-02-10 9:05 ` Zha Bin
2020-02-10 9:05 ` [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue Zha Bin
2020-02-10 9:05 ` Zha Bin
2020-02-11 10:50 ` [virtio-dev] " Michael S. Tsirkin
2020-02-11 10:50 ` Michael S. Tsirkin
2020-02-11 10:50 ` Michael S. Tsirkin
2020-02-11 11:33 ` [virtio-dev] " Michael S. Tsirkin
2020-02-11 11:33 ` Michael S. Tsirkin
2020-02-11 11:33 ` Michael S. Tsirkin
2020-02-12 3:39 ` [virtio-dev] " Jason Wang
2020-02-12 3:39 ` Jason Wang
2020-02-12 8:18 ` [virtio-dev] " Michael S. Tsirkin
2020-02-12 8:18 ` Michael S. Tsirkin
2020-02-12 8:18 ` Michael S. Tsirkin
2020-02-12 8:53 ` [virtio-dev] " Jason Wang
2020-02-12 8:53 ` Jason Wang
2020-02-12 8:53 ` Jason Wang
2020-02-12 9:33 ` [virtio-dev] " Jason Wang
2020-02-12 9:33 ` Jason Wang
2020-02-12 9:33 ` Jason Wang
2020-02-12 9:55 ` [virtio-dev] " Michael S. Tsirkin
2020-02-12 9:55 ` Michael S. Tsirkin
2020-02-12 9:55 ` Michael S. Tsirkin
2020-02-13 3:38 ` [virtio-dev] " Jason Wang
2020-02-13 3:38 ` Jason Wang
2020-02-10 9:05 ` [PATCH v2 2/5] virtio-mmio: refactor common functionality Zha Bin
2020-02-10 9:05 ` Zha Bin
2020-02-11 11:19 ` [virtio-dev] " Michael S. Tsirkin
2020-02-11 11:19 ` Michael S. Tsirkin
2020-02-11 11:19 ` Michael S. Tsirkin
2020-02-12 2:58 ` [virtio-dev] " Liu, Jing2
2020-02-12 2:58 ` Liu, Jing2
2020-02-12 2:58 ` Liu, Jing2
2020-02-12 7:29 ` Michael S. Tsirkin
2020-02-12 7:29 ` Michael S. Tsirkin
2020-02-12 7:29 ` Michael S. Tsirkin
2020-02-10 9:05 ` [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain Zha Bin
2020-02-10 9:05 ` Zha Bin
2020-02-11 11:16 ` [virtio-dev] " Michael S. Tsirkin
2020-02-11 11:16 ` Michael S. Tsirkin
2020-02-11 11:16 ` Michael S. Tsirkin
2020-02-12 7:40 ` [virtio-dev] " Michael S. Tsirkin
2020-02-12 7:40 ` Michael S. Tsirkin
2020-02-12 7:40 ` Michael S. Tsirkin
2020-02-10 9:05 ` [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support Zha Bin
2020-02-10 9:05 ` Zha Bin
2020-02-11 3:17 ` [virtio-dev] " Jason Wang
2020-02-11 3:17 ` Jason Wang
2020-02-11 3:35 ` [virtio-dev] " Liu, Jing2
2020-02-11 3:35 ` Liu, Jing2
2020-02-11 4:02 ` Jason Wang
2020-02-11 4:02 ` Jason Wang
2020-02-11 6:02 ` Liu, Jing2
2020-02-11 6:02 ` Liu, Jing2
2020-02-11 7:40 ` Jason Wang
2020-02-11 7:40 ` Jason Wang
2020-02-11 11:58 ` Michael S. Tsirkin
2020-02-11 11:58 ` Michael S. Tsirkin
2020-02-11 11:58 ` Michael S. Tsirkin
2020-02-11 12:04 ` Jason Wang
2020-02-11 12:04 ` Jason Wang
2020-02-11 12:08 ` Michael S. Tsirkin
2020-02-11 12:08 ` Michael S. Tsirkin
2020-02-11 12:18 ` Jason Wang
2020-02-11 12:18 ` Jason Wang
2020-02-11 14:00 ` Michael S. Tsirkin
2020-02-11 14:00 ` Michael S. Tsirkin
2020-02-12 9:03 ` Jason Wang
2020-02-12 9:03 ` Jason Wang
2020-02-12 9:15 ` Michael S. Tsirkin [this message]
2020-02-12 9:15 ` Michael S. Tsirkin
2020-02-12 3:54 ` Liu, Jing2
2020-02-12 3:54 ` Liu, Jing2
2020-02-12 7:33 ` Michael S. Tsirkin
2020-02-12 7:33 ` Michael S. Tsirkin
2020-02-12 7:33 ` Michael S. Tsirkin
2020-02-12 9:06 ` Jason Wang
2020-02-12 9:06 ` Jason Wang
2020-02-12 9:16 ` Michael S. Tsirkin
2020-02-12 9:16 ` Michael S. Tsirkin
2020-02-12 9:16 ` Michael S. Tsirkin
2020-02-13 3:40 ` Jason Wang
2020-02-13 3:40 ` Jason Wang
2020-02-13 3:40 ` Jason Wang
2020-02-11 11:21 ` Michael S. Tsirkin
2020-02-11 11:21 ` Michael S. Tsirkin
2020-02-11 11:21 ` Michael S. Tsirkin
2020-02-11 11:11 ` Michael S. Tsirkin
2020-02-11 11:11 ` Michael S. Tsirkin
2020-02-11 11:11 ` Michael S. Tsirkin
2020-02-10 9:05 ` [PATCH v2 5/5] x86: virtio-mmio: support virtio-mmio with MSI for x86 Zha Bin
2020-02-10 9:05 ` Zha Bin
2020-02-11 11:14 ` [virtio-dev] " Michael S. Tsirkin
2020-02-11 11:14 ` Michael S. Tsirkin
2020-02-11 11:14 ` Michael S. Tsirkin
2020-02-10 11:44 ` [virtio-dev] Re: [PATCH v2 0/5] virtio mmio specification enhancement Michael S. Tsirkin
2020-02-10 11:44 ` Michael S. Tsirkin
2020-02-10 11:44 ` Michael S. Tsirkin
2020-02-11 16:05 ` Chao Peng
2020-02-11 16:05 ` Chao Peng
2020-02-11 10:57 ` [virtio-dev] " Michael S. Tsirkin
2020-02-11 10:57 ` Michael S. Tsirkin
2020-02-11 10:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212041317-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=gerry@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=jing2.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=zhabin@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.