All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Anson Huang <Anson.Huang@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"Angus Ainslie \(Purism\)" <angus@akkea.ca>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Martin Kepplinger <martink@posteo.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add proximity sensor
Date: Fri, 14 Feb 2020 10:24:51 +0800	[thread overview]
Message-ID: <20200214022450.GD22842@dragon> (raw)
In-Reply-To: <e0434a87d8d46211a076c8a7c75c9f47b9e963c7.1579536647.git.agx@sigxcpu.org>

On Mon, Jan 20, 2020 at 05:12:55PM +0100, Guido Günther wrote:
> Support for the vcnl4040 landet a while ago so add it and the
> corresponding pinmux. The irq is currently unused in the driver so don't
> configure it yet.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  .../boot/dts/freescale/imx8mq-librem5-devkit.dts     | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index c8627f6614ae..b87c2e39b16c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -448,6 +448,12 @@
>  		VDDIO-supply = <&reg_1v8_p>;
>  	};
>  
> +	prox@60 {

I changed node name to proximity-sensor and applied the patch.

Shawn

> +		compatible = "vishay,vcnl4040";
> +		reg = <0x60>;
> +		pinctrl-0 = <&pinctrl_prox>;
> +	};
> +
>  	accel-gyro@6a {
>  		compatible = "st,lsm9ds1-imu";
>  		reg = <0x6a>;
> @@ -550,6 +556,12 @@
>  		>;
>  	};
>  
> +	pinctrl_prox: proxgrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_GPIO1_IO12_GPIO1_IO12	0x80  /* prox intr */
> +		>;
> +	};
> +
>  	pinctrl_pwr_en: pwrengrp {
>  		fsl,pins = <
>  			MX8MQ_IOMUXC_GPIO1_IO08_GPIO1_IO8	0x06
> -- 
> 2.23.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	Martin Kepplinger <martink@posteo.de>,
	Anson Huang <Anson.Huang@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add proximity sensor
Date: Fri, 14 Feb 2020 10:24:51 +0800	[thread overview]
Message-ID: <20200214022450.GD22842@dragon> (raw)
In-Reply-To: <e0434a87d8d46211a076c8a7c75c9f47b9e963c7.1579536647.git.agx@sigxcpu.org>

On Mon, Jan 20, 2020 at 05:12:55PM +0100, Guido Günther wrote:
> Support for the vcnl4040 landet a while ago so add it and the
> corresponding pinmux. The irq is currently unused in the driver so don't
> configure it yet.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  .../boot/dts/freescale/imx8mq-librem5-devkit.dts     | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index c8627f6614ae..b87c2e39b16c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -448,6 +448,12 @@
>  		VDDIO-supply = <&reg_1v8_p>;
>  	};
>  
> +	prox@60 {

I changed node name to proximity-sensor and applied the patch.

Shawn

> +		compatible = "vishay,vcnl4040";
> +		reg = <0x60>;
> +		pinctrl-0 = <&pinctrl_prox>;
> +	};
> +
>  	accel-gyro@6a {
>  		compatible = "st,lsm9ds1-imu";
>  		reg = <0x6a>;
> @@ -550,6 +556,12 @@
>  		>;
>  	};
>  
> +	pinctrl_prox: proxgrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_GPIO1_IO12_GPIO1_IO12	0x80  /* prox intr */
> +		>;
> +	};
> +
>  	pinctrl_pwr_en: pwrengrp {
>  		fsl,pins = <
>  			MX8MQ_IOMUXC_GPIO1_IO08_GPIO1_IO8	0x06
> -- 
> 2.23.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-14  2:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 16:12 [PATCH] arm64: dts: imx8mq-librem5-devkit: Add proximity sensor Guido Günther
2020-01-20 16:12 ` Guido Günther
2020-02-14  2:24 ` Shawn Guo [this message]
2020-02-14  2:24   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214022450.GD22842@dragon \
    --to=shawnguo@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=agx@sigxcpu.org \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martink@posteo.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.