From: "Ján Tomko" <jtomko@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
alex.williamson@redhat.com
Subject: Re: [PATCH v2] Report stringified errno in VFIO related errors
Date: Fri, 14 Feb 2020 11:04:32 +0100 [thread overview]
Message-ID: <20200214100432.GX11103@lpt> (raw)
In-Reply-To: <4949c3ecf1a32189b8a4b5eb4b0fd04c1122501d.1581674006.git.mprivozn@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Fri, Feb 14, 2020 at 10:55:19AM +0100, Michal Privoznik wrote:
>In a few places we report errno formatted as a negative integer.
>This is not as user friendly as it can be. Use strerror() and/or
>error_setg_errno() instead.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
>
>v1 posted here:
>
>https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html
>
>diff to v1:
> - Change error reporting in vfio_dma_unmap() too as I missed it in v1.
>
> hw/vfio/common.c | 4 ++--
> util/vfio-helpers.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Ján Tomko" <jtomko@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-trivial@nongnu.org, alex.williamson@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2] Report stringified errno in VFIO related errors
Date: Fri, 14 Feb 2020 11:04:32 +0100 [thread overview]
Message-ID: <20200214100432.GX11103@lpt> (raw)
In-Reply-To: <4949c3ecf1a32189b8a4b5eb4b0fd04c1122501d.1581674006.git.mprivozn@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Fri, Feb 14, 2020 at 10:55:19AM +0100, Michal Privoznik wrote:
>In a few places we report errno formatted as a negative integer.
>This is not as user friendly as it can be. Use strerror() and/or
>error_setg_errno() instead.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
>
>v1 posted here:
>
>https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html
>
>diff to v1:
> - Change error reporting in vfio_dma_unmap() too as I missed it in v1.
>
> hw/vfio/common.c | 4 ++--
> util/vfio-helpers.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-14 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 9:55 [PATCH v2] Report stringified errno in VFIO related errors Michal Privoznik
2020-02-14 9:55 ` Michal Privoznik
2020-02-14 10:04 ` Ján Tomko [this message]
2020-02-14 10:04 ` Ján Tomko
2020-02-14 10:37 ` Cornelia Huck
2020-02-14 10:37 ` Cornelia Huck
2020-02-14 11:14 ` Auger Eric
2020-02-14 11:49 ` Philippe Mathieu-Daudé
2020-02-14 11:49 ` Philippe Mathieu-Daudé
2020-02-14 15:35 ` Alex Williamson
2020-02-14 15:35 ` Alex Williamson
2020-02-14 16:50 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214100432.GX11103@lpt \
--to=jtomko@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.